2008-03-10 klockan 20:44 skrev Brian Cameron:
Thanks for explaining. I updated the patch as you suggest, and removed
the gui/gdmcommon.c part of the previous patch. The new patch which I
did apply is attached for reference.
See my comments below.
Index: daemon/gdm.h
2008-03-11 klockan 15:05 skrev Wouter Bolsterlee:
I'd suggest:
#define GDM_DEFAULT_WELCOME_MSG N_(Welcome)
#define GDM_DEFAULT_REMOTE_WELCOME_MSG N_(Welcome to %n)
...leaving the TRANSLATED variants out. Whenever you use the string for
display, just pass it through gettext().
2008-03-09 klockan 23:23 skrev Brian Cameron:
Can I get approval to add translations for these two strings?
Oops, forgot to answer this part of your message. If it's about fixing up
i18n for strings that were already in the package (i.e. no new strings
introduced), this is not a string freeze
Le dimanche 09 mars 2008, à 17:23 -0500, Brian Cameron a écrit :
Wouter:
Great idea. I wrote the attached patch to fix the problem more
cleanly based on your suggestion. Does this look right to you?
Can I get approval to add translations for these two strings?
Has the patch been tested?
2008-03-09 klockan 23:23 skrev Brian Cameron:
Great idea. I wrote the attached patch to fix the problem more
cleanly based on your suggestion. Does this look right to you?
No, the gui/gdmcommon.c part of the patch is wrong. The N_() macro only
*marks* for translation, without actually doing
Wouter:
Great idea. I wrote the attached patch to fix the problem more
cleanly based on your suggestion. Does this look right to you?
Can I get approval to add translations for these two strings?
Thanks,
Brian
2008-03-07 klockan 23:06 skrev Brian Cameron:
I think you are looking at the
2008-03-07 klockan 23:06 skrev Brian Cameron:
I think you are looking at the wrong patch. I was meaning this patch:
http://bugzilla.gnome.org/attachment.cgi?id=106612action=view
These patches were improperly marked as translation in the existing
code like this. From daemon/gdm.h:
Am Freitag, den 07.03.2008, 13:48 -0600 schrieb Brian Cameron:
It was recently reported that there is a problem translating two strings
in GDM. The two strings are the default welcome and remote welcome
strings that are shown to the user on the GDM dialog.
These strings are currently marked
Andre:
I think you are looking at the wrong patch. I was meaning this patch:
http://bugzilla.gnome.org/attachment.cgi?id=106612action=view
These patches were improperly marked as translation in the existing
code like this. From daemon/gdm.h:
#define GDM_DEFAULT_WELCOME_MSG Welcome
