Re: Code freeze break request for gnome-shell

2011-03-26 Thread Vincent Untz
Le vendredi 25 mars 2011, à 10:11 -0400, Matthias Clasen a écrit : On Fri, Mar 25, 2011 at 8:50 AM, Lucian Adrian Grijincu lucian.griji...@gmail.com wrote: On Fri, Mar 25, 2011 at 9:43 AM, David Zeuthen dav...@redhat.com wrote: this._errorMessageLabel.set_text(_(Sorry, that didn\'t work.

Re: Code freeze break request for gnome-shell

2011-03-25 Thread David Zeuthen
Hi, On Thu, 2011-03-24 at 18:05 -0400, Owen Taylor wrote: On Thu, 2011-03-24 at 22:54 +0100, Luca Ferretti wrote: Il giorno mer, 23/03/2011 alle 21.55 +0100, Kjartan Maraas ha scritto: this._errorMessageLabel.set_text(_(Sorry, that didn\'t work. Please try again.)); Sorry for

Re: Code freeze break request for gnome-shell

2011-03-25 Thread Lucian Adrian Grijincu
On Fri, Mar 25, 2011 at 9:43 AM, David Zeuthen dav...@redhat.com wrote: this._errorMessageLabel.set_text(_(Sorry, that didn\'t work. Please try again.)); The string is from  https://live.gnome.org/GnomeShell/Design/Whiteboards/AuthorizationDialog From the screenshots Incorrect password.

Re: Code freeze break request for gnome-shell

2011-03-25 Thread Matthias Clasen
On Fri, Mar 25, 2011 at 8:50 AM, Lucian Adrian Grijincu lucian.griji...@gmail.com wrote: On Fri, Mar 25, 2011 at 9:43 AM, David Zeuthen dav...@redhat.com wrote: this._errorMessageLabel.set_text(_(Sorry, that didn\'t work. Please try again.)); The string is from  

Re: Code freeze break request for gnome-shell

2011-03-24 Thread Johannes Schmid
Hi! No freeze break for i18n - I guess nobody would object code changes are minimal but I am not the release-team. Regards, Johannes signature.asc Description: This is a digitally signed message part ___ gnome-i18n mailing list gnome-i18n@gnome.org

Re: Code freeze break request for gnome-shell

2011-03-24 Thread Luca Ferretti
Il giorno mer, 23/03/2011 alle 21.55 +0100, Kjartan Maraas ha scritto: this._errorMessageLabel.set_text(_(Sorry, that didn\'t work. Please try again.)); Sorry for the late reply, I've seen this change was yet committed, but this message is really really really hard to translate. That what??

Re: Code freeze break request for gnome-shell

2011-03-24 Thread Owen Taylor
On Thu, 2011-03-24 at 22:54 +0100, Luca Ferretti wrote: Il giorno mer, 23/03/2011 alle 21.55 +0100, Kjartan Maraas ha scritto: this._errorMessageLabel.set_text(_(Sorry, that didn\'t work. Please try again.)); Sorry for the late reply, I've seen this change was yet committed, but this

Re: Code freeze break request for gnome-shell

2011-03-24 Thread Andre Klapper
On Thu, 2011-03-24 at 22:54 +0100, Luca Ferretti wrote: Il giorno mer, 23/03/2011 alle 21.55 +0100, Kjartan Maraas ha scritto: this._errorMessageLabel.set_text(_(Sorry, that didn\'t work. Please try again.)); Sorry for the late reply, I've seen this change was yet committed, but this

Re: Code freeze break request for gnome-shell

2011-03-23 Thread Andre Klapper
On Wed, 2011-03-23 at 21:55 +0100, Kjartan Maraas wrote: + text: _(), I don't think that line makes sense. Apart from that see http://live.gnome.org/TranslationProject/HandlingStringFreezes : The following types of changes do not need explicit

Re: Code freeze break request for gnome-shell

2011-03-23 Thread Andre Klapper
On Wed, 2011-03-23 at 21:58 +0100, Andre Klapper wrote: On Wed, 2011-03-23 at 21:55 +0100, Kjartan Maraas wrote: + text: _(), I don't think that line makes sense. Actually it's even wrong:

Re: Code freeze break request for gnome-shell

2011-03-23 Thread Matthias Clasen
On Wed, Mar 23, 2011 at 4:58 PM, Andre Klapper ak...@gmx.net wrote: On Wed, 2011-03-23 at 21:55 +0100, Kjartan Maraas wrote: +                                             text: _(), I don't think that line makes sense. Yeah, that will bring in the translation metadata... Apart from that see

Re: Code freeze break request for gnome-shell

2011-03-23 Thread Owen Taylor
On Wed, 2011-03-23 at 21:55 +0100, Kjartan Maraas wrote: Hi. Found some strings that weren't marked for translation in the correct way in gnome-shell. Patch attached...ok to commit? OK with me to commit, except for the pointed out _('') which should be changed to and not translated at

Re: Code freeze break request for gnome-shell

2011-03-23 Thread Vincent Untz
Le mercredi 23 mars 2011, à 17:06 -0400, Matthias Clasen a écrit : On Wed, Mar 23, 2011 at 4:58 PM, Andre Klapper ak...@gmx.net wrote: On Wed, 2011-03-23 at 21:55 +0100, Kjartan Maraas wrote: +                                             text: _(), I don't think that line makes sense.