Re: Fwd: Submit Help Translation on GNOME Terminal
Le 04.11.20 à 14:51, Michael Catanzaro a écrit : On Wed, Nov 4, 2020 at 2:31 pm, Daniel Mustieles García wrote: Ok, I agree with you in the procedure but there still a remaining question. Could someone help us improving/fixing missing features in Damned Lies, so we will not need to directly commit into git? Looks like Damned Lies is actively maintained here: https://gitlab.gnome.org/Infrastructure/damned-lies. So you can ask Claude. Isn't adding a new help translation fairly rare, though? I don't think it's so hard to commit it all at once when this happens? That's correct, new language codes should be committed along with the respective po files, not independently. Damned Lies is able to add new help files at the condition the help directory contains a LINGUAS file (on the same model as for UI po files). Regards, Claude -- www.2xlibre.net ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Fwd: Submit Help Translation on GNOME Terminal
On Wed, Nov 4, 2020 at 2:31 pm, Daniel Mustieles García wrote: Ok, I agree with you in the procedure but there still a remaining question. Could someone help us improving/fixing missing features in Damned Lies, so we will not need to directly commit into git? Looks like Damned Lies is actively maintained here: https://gitlab.gnome.org/Infrastructure/damned-lies. So you can ask Claude. Isn't adding a new help translation fairly rare, though? I don't think it's so hard to commit it all at once when this happens? ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Fwd: Submit Help Translation on GNOME Terminal
Ok, I agree with you in the procedure but there still a remaining question. Could someone help us improving/fixing missing features in Damned Lies, so we will not need to directly commit into git? Adding a new language for help files should be directly resolved thought DL and being able to upload/commit a bunch of translations would ease our work a lot (think about 20+ PO files to be commited manually...) We only want some useful tools to do our work, don't want to bother nor interfere in other's tasks, but we don't have enough tools to do it. Again, sorry for the mistake, but please hear our requests to improve our translation tasks. Regards El mié., 4 nov. 2020 a las 14:12, Emmanuele Bassi () escribió: > On Wed, 4 Nov 2020 at 12:51, Daniel Mustieles García via gnome-i18n < > gnome-i18n@gnome.org> wrote: > >> Hi Andika, >> >> Yes, it seems that my commit broke some continuous build in Gitlab, so >> Michael reverted it. To avoid wasting time, could someone indicate us how >> to proceed? >> > > To avoid wasting time, you should open a merge request against the > project, instead of pushing directly to the main or stable branches. > Otherwise, any breakage will be uncaught, and somebody will have to revert > the commit. > > For instance: > > > https://gitlab.gnome.org/GNOME/gnome-user-docs/-/commit/2486d2414a0239ad02cb54d1b28447ffdce5f4df > > the change was pushed to Git and the CI pipeline broke because of a > missing file: > > https://gitlab.gnome.org/GNOME/gnome-user-docs/-/jobs/970067 > > If you had opened a merge request, instead, you would have noticed the > missing file, and you could have amended the commit to your merge request > branch. > > Another example: > > > https://gitlab.gnome.org/GNOME/five-or-more/-/commit/cfde961fd479906826832e23033deba6f9f751ce > > Another failure: > > https://gitlab.gnome.org/GNOME/five-or-more/-/jobs/970068 > > ``` > FileNotFoundError: [Errno 2] No such file or directory: > '/run/build/five-or-more/_flatpak_build/help/id/bug-filing.page' > ``` > > Again, opening a merge request would have found this issue before it hit > the main development branch. > > That commit (and the similar one in iagno) ought to be reversed as well, > but at least the games are not part of core GNOME. > > I don't mind to do it again (even adding the PO files in the commit) but I >> think that's not the proper way to do things. >> > > Micheal is part of the release team; the release team is empowered to > revert any commit that breaks the continuous integration build of GNOME, > because that continuous integration is what generates: > > - the nightly and stable application flatpaks > - the nightly and stable run times (also used for CI in various > applications) > - the release VM builds > > Breaking those means stalling the work of a lot of other projects. > > Maybe someone could review DL's way to add new languages for help or, at >> least, grant team coordinators commit access to be able to solve this >> issues without breaking anything (nor depend on other people) >> > > The appropriate way to commit changes is to have them run through the > per-module continuous integration. If that passes, but things still break > when we try to build the whole of GNOME core modules and applications, then > we can discuss about that; but if you work around the measures we have in > place *precisely* to catch these issues, then I'm afraid you're going to > get more commits reverted. Or the release team might simply decide to > revoke direct commit access to localisation team coordinators, and avoid > reverting broken commits. > > Ciao, > Emmanuele. > > >> Regards >> >> El mié., 4 nov. 2020 a las 13:20, Andika Triwidada () >> escribió: >> >>> Hi Daniel, >>> >>> Thanks for your help. It seems that Michael Catanzaro revert all your >>> modifications before I have chance to commit files. Please advice how to >>> proceed? >>> >>> On Tue, Nov 3, 2020 at 4:50 PM Daniel Mustieles García < >>> daniel.mustie...@gmail.com> wrote: >>> Hi Andika, I've added 'id' language to those modules. Please check if you can now commit translations for them using DL. Let us know if you have any problem with it. Regards El dom., 1 nov. 2020 a las 2:48, Andika Triwidada () escribió: > Hello, I think this problem is well known for Documentation > translation. If a language has not been translated, required directory > help/language-code will not be there, and DL can not automatically create > it. Then in turn, DL will not present "submit to repository" on pull down > options. > > Currently, we face this problem on these modules: > * > https://l10n.gnome.org/vertimus/gnome-user-docs/master/system-admin-guide/id/ > * https://l10n.gnome.org/vertimus/five-or-more/master/help/id/ > * https://l10n.gnome.org/vertimus/iagno/master/help/id/ > * https://l10n.gnome.org/vertimus/31/27/89/ (gnome system monitor) > *
Re: Fwd: Submit Help Translation on GNOME Terminal
On Wed, 4 Nov 2020 at 12:51, Daniel Mustieles García via gnome-i18n < gnome-i18n@gnome.org> wrote: > Hi Andika, > > Yes, it seems that my commit broke some continuous build in Gitlab, so > Michael reverted it. To avoid wasting time, could someone indicate us how > to proceed? > To avoid wasting time, you should open a merge request against the project, instead of pushing directly to the main or stable branches. Otherwise, any breakage will be uncaught, and somebody will have to revert the commit. For instance: https://gitlab.gnome.org/GNOME/gnome-user-docs/-/commit/2486d2414a0239ad02cb54d1b28447ffdce5f4df the change was pushed to Git and the CI pipeline broke because of a missing file: https://gitlab.gnome.org/GNOME/gnome-user-docs/-/jobs/970067 If you had opened a merge request, instead, you would have noticed the missing file, and you could have amended the commit to your merge request branch. Another example: https://gitlab.gnome.org/GNOME/five-or-more/-/commit/cfde961fd479906826832e23033deba6f9f751ce Another failure: https://gitlab.gnome.org/GNOME/five-or-more/-/jobs/970068 ``` FileNotFoundError: [Errno 2] No such file or directory: '/run/build/five-or-more/_flatpak_build/help/id/bug-filing.page' ``` Again, opening a merge request would have found this issue before it hit the main development branch. That commit (and the similar one in iagno) ought to be reversed as well, but at least the games are not part of core GNOME. I don't mind to do it again (even adding the PO files in the commit) but I > think that's not the proper way to do things. > Micheal is part of the release team; the release team is empowered to revert any commit that breaks the continuous integration build of GNOME, because that continuous integration is what generates: - the nightly and stable application flatpaks - the nightly and stable run times (also used for CI in various applications) - the release VM builds Breaking those means stalling the work of a lot of other projects. Maybe someone could review DL's way to add new languages for help or, at > least, grant team coordinators commit access to be able to solve this > issues without breaking anything (nor depend on other people) > The appropriate way to commit changes is to have them run through the per-module continuous integration. If that passes, but things still break when we try to build the whole of GNOME core modules and applications, then we can discuss about that; but if you work around the measures we have in place *precisely* to catch these issues, then I'm afraid you're going to get more commits reverted. Or the release team might simply decide to revoke direct commit access to localisation team coordinators, and avoid reverting broken commits. Ciao, Emmanuele. > Regards > > El mié., 4 nov. 2020 a las 13:20, Andika Triwidada () > escribió: > >> Hi Daniel, >> >> Thanks for your help. It seems that Michael Catanzaro revert all your >> modifications before I have chance to commit files. Please advice how to >> proceed? >> >> On Tue, Nov 3, 2020 at 4:50 PM Daniel Mustieles García < >> daniel.mustie...@gmail.com> wrote: >> >>> Hi Andika, >>> >>> I've added 'id' language to those modules. Please check if you can now >>> commit translations for them using DL. >>> >>> Let us know if you have any problem with it. >>> >>> Regards >>> >>> El dom., 1 nov. 2020 a las 2:48, Andika Triwidada () >>> escribió: >>> Hello, I think this problem is well known for Documentation translation. If a language has not been translated, required directory help/language-code will not be there, and DL can not automatically create it. Then in turn, DL will not present "submit to repository" on pull down options. Currently, we face this problem on these modules: * https://l10n.gnome.org/vertimus/gnome-user-docs/master/system-admin-guide/id/ * https://l10n.gnome.org/vertimus/five-or-more/master/help/id/ * https://l10n.gnome.org/vertimus/iagno/master/help/id/ * https://l10n.gnome.org/vertimus/31/27/89/ (gnome system monitor) * https://l10n.gnome.org/vertimus/gnote/master/help/id/ * https://l10n.gnome.org/vertimus/gthumb/master/help/id/ * https://l10n.gnome.org/vertimus/gucharmap/master/help/id/ * https://l10n.gnome.org/vertimus/shotwell/master/help/id/ We would be very grateful if someone who has git write access to those modules can help us create those prerequisite directories and language entry in config files. Regards, Andika >>> ___ > gnome-i18n mailing list > gnome-i18n@gnome.org > https://mail.gnome.org/mailman/listinfo/gnome-i18n > -- https://www.bassi.io [@] ebassi [@gmail.com] ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Fwd: Submit Help Translation on GNOME Terminal
Hi Andika, Yes, it seems that my commit broke some continuous build in Gitlab, so Michael reverted it. To avoid wasting time, could someone indicate us how to proceed? I don't mind to do it again (even adding the PO files in the commit) but I think that's not the proper way to do things. Maybe someone could review DL's way to add new languages for help or, at least, grant team coordinators commit access to be able to solve this issues without breaking anything (nor depend on other people) Regards El mié., 4 nov. 2020 a las 13:20, Andika Triwidada () escribió: > Hi Daniel, > > Thanks for your help. It seems that Michael Catanzaro revert all your > modifications before I have chance to commit files. Please advice how to > proceed? > > On Tue, Nov 3, 2020 at 4:50 PM Daniel Mustieles García < > daniel.mustie...@gmail.com> wrote: > >> Hi Andika, >> >> I've added 'id' language to those modules. Please check if you can now >> commit translations for them using DL. >> >> Let us know if you have any problem with it. >> >> Regards >> >> El dom., 1 nov. 2020 a las 2:48, Andika Triwidada () >> escribió: >> >>> Hello, I think this problem is well known for Documentation translation. >>> If a language has not been translated, required directory >>> help/language-code will not be there, and DL can not automatically create >>> it. Then in turn, DL will not present "submit to repository" on pull down >>> options. >>> >>> Currently, we face this problem on these modules: >>> * >>> https://l10n.gnome.org/vertimus/gnome-user-docs/master/system-admin-guide/id/ >>> * https://l10n.gnome.org/vertimus/five-or-more/master/help/id/ >>> * https://l10n.gnome.org/vertimus/iagno/master/help/id/ >>> * https://l10n.gnome.org/vertimus/31/27/89/ (gnome system monitor) >>> * https://l10n.gnome.org/vertimus/gnote/master/help/id/ >>> * https://l10n.gnome.org/vertimus/gthumb/master/help/id/ >>> * https://l10n.gnome.org/vertimus/gucharmap/master/help/id/ >>> * https://l10n.gnome.org/vertimus/shotwell/master/help/id/ >>> >>> We would be very grateful if someone who has git write access to those >>> modules can help us create those prerequisite directories and language >>> entry in config files. >>> >>> Regards, >>> Andika >>> >> ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Fwd: Submit Help Translation on GNOME Terminal
Hi Daniel, Thanks for your help. It seems that Michael Catanzaro revert all your modifications before I have chance to commit files. Please advice how to proceed? On Tue, Nov 3, 2020 at 4:50 PM Daniel Mustieles García < daniel.mustie...@gmail.com> wrote: > Hi Andika, > > I've added 'id' language to those modules. Please check if you can now > commit translations for them using DL. > > Let us know if you have any problem with it. > > Regards > > El dom., 1 nov. 2020 a las 2:48, Andika Triwidada () > escribió: > >> Hello, I think this problem is well known for Documentation translation. >> If a language has not been translated, required directory >> help/language-code will not be there, and DL can not automatically create >> it. Then in turn, DL will not present "submit to repository" on pull down >> options. >> >> Currently, we face this problem on these modules: >> * >> https://l10n.gnome.org/vertimus/gnome-user-docs/master/system-admin-guide/id/ >> * https://l10n.gnome.org/vertimus/five-or-more/master/help/id/ >> * https://l10n.gnome.org/vertimus/iagno/master/help/id/ >> * https://l10n.gnome.org/vertimus/31/27/89/ (gnome system monitor) >> * https://l10n.gnome.org/vertimus/gnote/master/help/id/ >> * https://l10n.gnome.org/vertimus/gthumb/master/help/id/ >> * https://l10n.gnome.org/vertimus/gucharmap/master/help/id/ >> * https://l10n.gnome.org/vertimus/shotwell/master/help/id/ >> >> We would be very grateful if someone who has git write access to those >> modules can help us create those prerequisite directories and language >> entry in config files. >> >> Regards, >> Andika >> > ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
