Re: [GNC-dev] Can a module call a function from another module?

2020-04-18 Thread jean laroche
Thanks for all the background, I understand it a lot better now. Indeed, I've noticed the intermingled UI/logic code in places, and I agree that's not good. What I want to try is launch the reconcile from the import, exactly like aqbanking, so that shouldn't be a problem. No specific

Re: [GNC-dev] Can a module call a function from another module?

2020-04-18 Thread John Ralls
One other consideration: The dependency should make sense architecturally: A dependency on code in libgnucash/engine nearly always makes sense; a dependency in the register on a function in import/export does not. That doesn't mean that you should copy-and-paste the code instead, it means that

Re: [GNC-dev] Can a module call a function from another module?

2020-04-18 Thread Geert Janssens
First off, modules are mostly on the way out. I have been working on removing most uses of those and plan to eliminate even more. The gnc_module code itself will remain until we have a better alternative. Other than that, yes, you are allowed to include headers from other "modules". Or more

[GNC-dev] Can a module call a function from another module?

2020-04-17 Thread jeanl
Devs, I have a question to which I can't find an answer. It is possible for a function from a module (say import-ofx) to call a function from another module (declared in "reconcile-window.h" for example). I'm not able to include reconcile-window.h from gnc-ofx-import.cpp , I assume the build isn't