Re: DBI windows compile problems: gmtime_r

2008-07-14 Thread Derek Atkins
Thanks. I didn't look to see if it was being used elsewhere. I'm quite surprised how often we use it. Well, I suppose for now we should just live with it. I'll try to remember to file a bug report at some point. -derek Phil Longstaff <[EMAIL PROTECTED]> writes: > OK. However, gmtime() is u

Re: DBI windows compile problems: gmtime_r

2008-07-14 Thread Phil Longstaff
OK. However, gmtime() is used in many other places in gnucash, so I am not introducing a problem. Why don't you log a bug so we won't forget it :) Phil Derek Atkins wrote: > Hi, > > One problem with using gmtime() is that it is not multi-threaded > so a second call to gmtime() will scribble ov

Re: DBI windows compile problems: gmtime_r

2008-07-14 Thread Derek Atkins
Hi, One problem with using gmtime() is that it is not multi-threaded so a second call to gmtime() will scribble over the space used in the first call. I think a better approach would be to add gmtime_r to AC_REPLACE_FUNCS in configure and then we can add an implementation in libs/libc on win32.

Re: DBI windows compile problems: gmtime_r

2008-07-14 Thread Phil Longstaff
Hi Nathan, sorry for taking so long. I just committed this change. Phil Nathan Buchanan wrote: > Hi Phil! > > I get a warning about gmtime_r being undefined in > src/backend/sql/gnc-backend-sql.c:1550 From what I read, the gmtime_r > function is not available in mingw. How about we use gmtime

DBI windows compile problems: gmtime_r

2008-06-14 Thread Nathan Buchanan
Hi Phil! I get a warning about gmtime_r being undefined in src/backend/sql/gnc-backend-sql.c:1550 From what I read, the gmtime_r function is not available in mingw. How about we use gmtime? Nathan -- <><><><><><><><><><><><><><><> "Even if you are on the right track, you'll get run over if you