Re: [GNC-dev] Auto reconcile from register window

2020-10-28 Thread Cristian Klein
Hi all, The missing auto-clear menu in gnc-plugin-page-register-ui.xml and gnc-plugin-page-register2-ui.xml were an omission. I used to right-click the account from the tree view, so I never noticed the missing menu items. I fixed this in the previously mentioned PR [1]. I checked how this

Re: [GNC-dev] Auto reconcile from register window

2020-10-28 Thread Christopher Lam
I see no objections myself. Auto-clear will have increased test coverage[1] and visibility, and I have a plan to modify so that the hash-table is generated once as soon as the dialog is created, saved within the dialog, and updated when the end_value is changed. Thus the user could have live

Re: [GNC-dev] Auto reconcile from register window

2020-10-28 Thread Mike Alexander
Yes, but, Autoclear doesn't need an account any more than reconcile needs one. Both gnc_plugin_page_register_cmd_reconcile and gnc_plugin_page_register_cmd_autoclear call gnc_plugin_page_register_get_account to get the account to work on. This may return a null pointer if the register