Re: [GNC-dev] Auto reconcile from register window

2020-10-28 Thread Cristian Klein
Hi all, The missing auto-clear menu in gnc-plugin-page-register-ui.xml and gnc-plugin-page-register2-ui.xml were an omission. I used to right-click the account from the tree view, so I never noticed the missing menu items. I fixed this in the previously mentioned PR [1]. I checked how this

Re: [GNC-dev] Auto reconcile from register window

2020-10-28 Thread Christopher Lam
I see no objections myself. Auto-clear will have increased test coverage[1] and visibility, and I have a plan to modify so that the hash-table is generated once as soon as the dialog is created, saved within the dialog, and updated when the end_value is changed. Thus the user could have live

Re: [GNC-dev] Auto reconcile from register window

2020-10-28 Thread Mike Alexander
Yes, but, Autoclear doesn't need an account any more than reconcile needs one. Both gnc_plugin_page_register_cmd_reconcile and gnc_plugin_page_register_cmd_autoclear call gnc_plugin_page_register_get_account to get the account to work on. This may return a null pointer if the register

Re: [GNC-dev] Auto reconcile from register window

2020-10-26 Thread Christopher Lam
Having said that, when we type into the blank entry it knows which account to tie the split to... So, the account could be found somewhere... On Mon, 26 Oct 2020, 2:38 pm Christopher Lam, wrote: > From my understanding, this code is not hooked up to the register because: > a register is always

Re: [GNC-dev] Auto reconcile from register window

2020-10-26 Thread Christopher Lam
>From my understanding, this code is not hooked up to the register because: a register is always a search list, and not necessarily tied to an account. Proof: the blank transaction register entry has no account. I gather the original coder noticed the same, therefore didn't hook it. On Mon, 26

[GNC-dev] Auto reconcile from register window

2020-10-26 Thread Mike Alexander
I noticed the recent checkins related to the auto reconcile feature. This intrigued me since I didn't know such a feature existed. After looking around for a while it appears that this is because it is only available for the account tree and I always start a reconcile from the register