Pull Requests
I had some time to go through the pull requests I had created and extract the fixes that I think should be included before the code freeze and created PR 251. Others can be included if deemed appropriate and good enough otherwise I will work on them in the new year. Regards, Bob ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Patches versus Pull Requests
Thanks John. I will look at ways to rewrite these sections to reflect current practices and preferences. It probably will mostly entail switching the sequence of information (putting pull requests first), and then offloading the details of the patch process into a separate page for those still wishing to find that. David > On Jul 27, 2017, at 10:28 PM, John Ralls <jra...@ceridwen.us> wrote: > > >> On Jul 27, 2017, at 9:45 AM, David T. via gnucash-devel >> <gnucash-devel@gnucash.org> wrote: >> >> Hello, >> >> In going over some of the wiki information, I ran into a section that goes >> into some detail about preparing patches for submission. >> >> While this is, no doubt, still a valid way of submitting changes, is this: >> a) how the project prefers such changes to be submitted, and b) something >> that anyone is actively using? >> >> If the answers are “no” and “not many,” then perhaps this information could >> be removed from the wiki? > > It's still valid and although we do see more pull requests than patches on > bugs we still need the procedure available as long as we continue to use > Gnome's bugzilla. > > Besides if one is doing a drive-by patch for a bug it's a lot easier to just > run git format-patch than to fork gnucash in Github and create a PR. > > Regards, > John Ralls > ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Patches versus Pull Requests
+1, it's a lot easier to just format-patch and send it to some place related to the project than using GitHub. :) ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Patches versus Pull Requests
> On Jul 27, 2017, at 9:45 AM, David T. via gnucash-devel > <gnucash-devel@gnucash.org> wrote: > > Hello, > > In going over some of the wiki information, I ran into a section that goes > into some detail about preparing patches for submission. > > While this is, no doubt, still a valid way of submitting changes, is this: a) > how the project prefers such changes to be submitted, and b) something that > anyone is actively using? > > If the answers are “no” and “not many,” then perhaps this information could > be removed from the wiki? It's still valid and although we do see more pull requests than patches on bugs we still need the procedure available as long as we continue to use Gnome's bugzilla. Besides if one is doing a drive-by patch for a bug it's a lot easier to just run git format-patch than to fork gnucash in Github and create a PR. Regards, John Ralls ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Patches versus Pull Requests
Hello, In going over some of the wiki information, I ran into a section that goes into some detail about preparing patches for submission. While this is, no doubt, still a valid way of submitting changes, is this: a) how the project prefers such changes to be submitted, and b) something that anyone is actively using? If the answers are “no” and “not many,” then perhaps this information could be removed from the wiki? David ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: github pull requests
Even as a pull request! :-) -derek Sent on my mobile. Please forgive any typos. - Reply message - From: "Geert Janssens" <geert.gnuc...@kobaltwit.be> To: <gnucash-devel@gnucash.org> Cc: "Chris Good" <chris.g...@ozemail.com.au> Subject: github pull requests Date: Tue, May 31, 2016 1:12 PM Hi Chris, Good catch. We do accept pull requests indeed and I believe we even prefer them for large change sets now. I have made a minimal change to the README. It could use a better wording than mine so feel free to express it more clearly. Thanks Geert On Tuesday 31 May 2016 19:07:43 Chris Good wrote: > Hi, > > > > Just pointing out an inconsistency if you think it worth fixing. > > I believe the following from the github README file is out of date. > > > > ## > > Getting Source with Git > > -- > > > > We maintain a mirror of our master repository on Github. You can > > browse the code at https://github.com/Gnucash/gnucash. Clone URIs are > > on that page, or if you have a Github account you can fork it > > there. Note, however, that we do *not* accept Github pull requests: > > All patches should be submitted via Bugzilla, see below. > > > > > > Whereas http://wiki.gnucash.org/wiki/Git#Pull_Requests says > > > > > Pull Requests[edit > <http://wiki.gnucash.org/wiki/index.php?title=Git=edit= > 9> ] > > > If you prefer, you can use a GitHub Pull Request instead of attaching > a patch to a bug. > > Regards, > > Chris Good ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: github pull requests
Hi Chris, Good catch. We do accept pull requests indeed and I believe we even prefer them for large change sets now. I have made a minimal change to the README. It could use a better wording than mine so feel free to express it more clearly. Thanks Geert On Tuesday 31 May 2016 19:07:43 Chris Good wrote: > Hi, > > > > Just pointing out an inconsistency if you think it worth fixing. > > I believe the following from the github README file is out of date. > > > > ## > > Getting Source with Git > > -- > > > > We maintain a mirror of our master repository on Github. You can > > browse the code at https://github.com/Gnucash/gnucash. Clone URIs are > > on that page, or if you have a Github account you can fork it > > there. Note, however, that we do *not* accept Github pull requests: > > All patches should be submitted via Bugzilla, see below. > > > > > > Whereas http://wiki.gnucash.org/wiki/Git#Pull_Requests says > > > > > Pull Requests[edit > <http://wiki.gnucash.org/wiki/index.php?title=Git=edit= > 9> ] > > > If you prefer, you can use a GitHub Pull Request instead of attaching > a patch to a bug. > > Regards, > > Chris Good ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
github pull requests
Hi, Just pointing out an inconsistency if you think it worth fixing. I believe the following from the github README file is out of date. ## Getting Source with Git -- We maintain a mirror of our master repository on Github. You can browse the code at https://github.com/Gnucash/gnucash. Clone URIs are on that page, or if you have a Github account you can fork it there. Note, however, that we do *not* accept Github pull requests: All patches should be submitted via Bugzilla, see below. Whereas http://wiki.gnucash.org/wiki/Git#Pull_Requests says Pull Requests[edit <http://wiki.gnucash.org/wiki/index.php?title=Git=edit=9> ] If you prefer, you can use a GitHub Pull Request instead of attaching a patch to a bug. Regards, Chris Good smime.p7s Description: S/MIME cryptographic signature ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Pull requests via github
Hello, do you accept patches as pull requests on github? I made one today, but after that I found another one, initiated a year ago, where it's said, that I need to send a patch to this list. It is still true or something changed after complete migration to git? Best regards, Dmitry Pavlov ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Pull requests via github
On Saturday 22 February 2014 18:43:31 Dmitry Pavlov wrote: Hello, do you accept patches as pull requests on github? I made one today, but after that I found another one, initiated a year ago, where it's said, that I need to send a patch to this list. It is still true or something changed after complete migration to git? Hi Dmitry, This has not formally been decided upon yet. The git migration is very recent and there are still parts of the development process that are in flux due to this change. But I think most of us are open to at least try the github pull request mechanism and see how that will work out. So in this case you don't need to do anything extra in particular. Thank you for your patch. One of us will look into it. Regards, Geert Best regards, Dmitry Pavlov ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
