Re: [GNC-dev] gnucash maint: Multiple changes pushed

2021-10-16 Thread Geert Janssens
Oops, this push inadvertently added unfinished work on GSettings. I have reverted it for now. Regards, Geert Op zaterdag 16 oktober 2021 10:49:14 CEST schreef Geert Janssens: > Updatedvia https://github.com/Gnucash/gnucash/commit/d4e4062c > (commit) >via https://github.com/Gn

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2020-11-16 Thread John Ralls
> On Nov 13, 2020, at 2:13 AM, Geert Janssens > wrote: > > Op vrijdag 13 november 2020 00:52:44 CET schreef John Ralls: >> Updated via https://github.com/Gnucash/gnucash/commit/d751913c >> (commit) >> via https://github.com/Gnucash/gnucash/commit/4e91a33b (commit) >> from

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2020-11-13 Thread Geert Janssens
Op vrijdag 13 november 2020 00:52:44 CET schreef John Ralls: > Updatedvia https://github.com/Gnucash/gnucash/commit/d751913c > (commit) >via https://github.com/Gnucash/gnucash/commit/4e91a33b (commit) > from https://github.com/Gnucash/gnucash/commit/a519b913 (commit) > >

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2020-07-31 Thread Christopher Lam
Unfortunately cleaning up advanced-portfolio.scm is much more challenging than I expected, so, I've now reverted it to its original (as of 4.0) state, with suitable changes to support guile-3.0 only. On Sat, 1 Aug 2020 at 05:55, Christopher Lam wrote: > Updated via https://github.com/Gnucash/g

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-07-19 Thread John Ralls
Testing the Swig bindings would be a good thing, the more thorough the better. For the most part the Swig binding tests just make sure that they can load a module, which isn't much of a test. Regards, John Ralls > On Jul 19, 2019, at 8:44 AM, Christopher Lam > wrote: > > Hi, not sure if .sc

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-02-27 Thread Wm via gnucash-devel
On 26/02/2019 11:56, Christopher Lam wrote: Hi Geert, Sharp eye indeed. I haven't used the new gnc:gui-error function because report.scm is being simulateously attacked: (1) refactoring in maint-scheme-progress (2) slowly creating nearly 100% coverage for tests (3) fixing an invalid code path int

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-02-26 Thread Geert Janssens
Op dinsdag 26 februari 2019 12:56:47 CET schreef Christopher Lam: > Hi Geert, > Sharp eye indeed. > I haven't used the new gnc:gui-error function because report.scm is being > simulateously attacked: > (1) refactoring in maint-scheme-progress > (2) slowly creating nearly 100% coverage for tests > (

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-02-26 Thread Christopher Lam
Hi Geert, Sharp eye indeed. I haven't used the new gnc:gui-error function because report.scm is being simulateously attacked: (1) refactoring in maint-scheme-progress (2) slowly creating nearly 100% coverage for tests (3) fixing an invalid code path introduced about 8 months ago, which was returnin

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-02-26 Thread Geert Janssens
Op dinsdag 26 februari 2019 11:24:26 CET schreef Christopher Lam: > Updatedvia https://github.com/Gnucash/gnucash/commit/d980bb50 > (commit) >via https://github.com/Gnucash/gnucash/commit/0ce6999f (commit) >via https://github.com/Gnucash/gnucash/commit/5cdc5158 (commit)

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-19 Thread Geert Janssens
Op vrijdag 18 januari 2019 23:54:07 CET schreef Christian Stimming: > commit 6f34995901dcfc999c675e5a4bc095eaf52a2d6f > Author: Christian Stimming > Date: Fri Jan 18 23:32:31 2019 +0100 > > Usability improvements for Bayes editor window > > Remove the "Are you sure" question as it is s

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-11 Thread Geert Janssens
Op vrijdag 11 januari 2019 01:42:41 CET schreef John Ralls: > > On Jan 10, 2019, at 12:44 PM, Geert Janssens > > wrote:> > > Op donderdag 10 januari 2019 21:11:26 CET schreef John Ralls: > >>> On Jan 10, 2019, at 8:32 AM, Geert Janssens > >>> wrote:> > >>> > >>> Op donderdag 10 januari 2019 16:

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-10 Thread John Ralls
> On Jan 10, 2019, at 5:25 PM, Derek Atkins wrote: > > > On Thu, January 10, 2019 7:42 pm, John Ralls wrote: >> > [snip] >> >> Gtk has gtk_init. You call it, set up your GUI, then call gtk_main to >> start the event loop. libguile has several initialization functions to >> choose from: >> h

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-10 Thread Derek Atkins
On Thu, January 10, 2019 7:42 pm, John Ralls wrote: > [snip] > > Gtk has gtk_init. You call it, set up your GUI, then call gtk_main to > start the event loop. libguile has several initialization functions to > choose from: > https://www.gnu.org/software/guile/manual/html_node/Initialization.html#

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-10 Thread John Ralls
> On Jan 10, 2019, at 12:44 PM, Geert Janssens > wrote: > > Op donderdag 10 januari 2019 21:11:26 CET schreef John Ralls: >>> On Jan 10, 2019, at 8:32 AM, Geert Janssens >>> wrote:> >>> Op donderdag 10 januari 2019 16:35:57 CET schreef John Ralls: > On Jan 10, 2019, at 2:12 AM, Geert Jan

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-10 Thread Geert Janssens
Op donderdag 10 januari 2019 21:11:26 CET schreef John Ralls: > > On Jan 10, 2019, at 8:32 AM, Geert Janssens > > wrote:> > > Op donderdag 10 januari 2019 16:35:57 CET schreef John Ralls: > >>> On Jan 10, 2019, at 2:12 AM, Geert Janssens > >>> wrote:> > >>> > >>> Op donderdag 10 januari 2019 06

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-10 Thread John Ralls
> On Jan 10, 2019, at 8:32 AM, Geert Janssens > wrote: > > Op donderdag 10 januari 2019 16:35:57 CET schreef John Ralls: >>> On Jan 10, 2019, at 2:12 AM, Geert Janssens >>> wrote:> >>> Op donderdag 10 januari 2019 06:45:15 CET schreef John Ralls: > On Jan 9, 2019, at 9:06 AM, Geert Janss

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-10 Thread Geert Janssens
Op donderdag 10 januari 2019 16:35:57 CET schreef John Ralls: > > On Jan 10, 2019, at 2:12 AM, Geert Janssens > > wrote:> > > Op donderdag 10 januari 2019 06:45:15 CET schreef John Ralls: > >>> On Jan 9, 2019, at 9:06 AM, Geert Janssens > >>> wrote:> > >>> > >>> Op woensdag 9 januari 2019 15:45

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-10 Thread John Ralls
> On Jan 10, 2019, at 2:12 AM, Geert Janssens > wrote: > > Op donderdag 10 januari 2019 06:45:15 CET schreef John Ralls: >>> On Jan 9, 2019, at 9:06 AM, Geert Janssens >>> wrote:> >>> Op woensdag 9 januari 2019 15:45:31 CET schreef John Ralls: > On Jan 9, 2019, at 6:17 AM, Derek Atkins

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-10 Thread Geert Janssens
Op donderdag 10 januari 2019 06:45:15 CET schreef John Ralls: > > On Jan 9, 2019, at 9:06 AM, Geert Janssens > > wrote:> > > Op woensdag 9 januari 2019 15:45:31 CET schreef John Ralls: > >>> On Jan 9, 2019, at 6:17 AM, Derek Atkins wrote: > >>> > >>> HI, > >>> > >>> On Wed, January 9, 2019 9:1

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-10 Thread Geert Janssens
Op donderdag 10 januari 2019 02:08:29 CET schreef John Ralls: > > On Jan 9, 2019, at 11:52 AM, Geert Janssens > > wrote:> > > Op woensdag 9 januari 2019 18:06:49 CET schreef Geert Janssens: > >> Op woensdag 9 januari 2019 15:57:07 CET schreef John Ralls: > On Jan 9, 2019, at 4:24 AM, Geert J

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-09 Thread John Ralls
> On Jan 9, 2019, at 9:06 AM, Geert Janssens wrote: > > Op woensdag 9 januari 2019 15:45:31 CET schreef John Ralls: >>> On Jan 9, 2019, at 6:17 AM, Derek Atkins wrote: >>> >>> HI, >>> >>> On Wed, January 9, 2019 9:12 am, Geert Janssens wrote: I like the idea of caching the system locale

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-09 Thread John Ralls
> On Jan 9, 2019, at 11:52 AM, Geert Janssens > wrote: > > Op woensdag 9 januari 2019 18:06:49 CET schreef Geert Janssens: >> Op woensdag 9 januari 2019 15:57:07 CET schreef John Ralls: On Jan 9, 2019, at 4:24 AM, Geert Janssens wrote:> Op dinsdag 1 januari 2019 22:14:16

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-09 Thread Geert Janssens
Op woensdag 9 januari 2019 18:06:49 CET schreef Geert Janssens: > Op woensdag 9 januari 2019 15:57:07 CET schreef John Ralls: > > > On Jan 9, 2019, at 4:24 AM, Geert Janssens > > > wrote:> > > > > > > Op dinsdag 1 januari 2019 22:14:16 CET schreef John Ralls: > > >> Updated via https://github.

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-09 Thread Geert Janssens
Op woensdag 9 januari 2019 15:57:07 CET schreef John Ralls: > > On Jan 9, 2019, at 4:24 AM, Geert Janssens > > wrote:> > > Op dinsdag 1 januari 2019 22:14:16 CET schreef John Ralls: > >> Updated via https://github.com/Gnucash/gnucash/commit/3a105f07 (commit) > >> > >> via https://gith

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-09 Thread Geert Janssens
Op woensdag 9 januari 2019 15:45:31 CET schreef John Ralls: > > On Jan 9, 2019, at 6:17 AM, Derek Atkins wrote: > > > > HI, > > > > On Wed, January 9, 2019 9:12 am, Geert Janssens wrote: > >> I like the idea of caching the system locale for future use. Too bad the > >> std::locale is working so

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-09 Thread John Ralls
> On Jan 9, 2019, at 4:24 AM, Geert Janssens wrote: > > Op dinsdag 1 januari 2019 22:14:16 CET schreef John Ralls: >> Updated via https://github.com/Gnucash/gnucash/commit/3a105f07 >> (commit) >> via https://github.com/Gnucash/gnucash/commit/95bee405 (commit) >> via https:

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-09 Thread John Ralls
> On Jan 9, 2019, at 6:17 AM, Derek Atkins wrote: > > HI, > > On Wed, January 9, 2019 9:12 am, Geert Janssens wrote: >> I like the idea of caching the system locale for future use. Too bad the >> std::locale is working so poorly on Windows :( >> >> Op zondag 6 januari 2019 19:13:28 CET schre

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-09 Thread Derek Atkins
HI, On Wed, January 9, 2019 9:12 am, Geert Janssens wrote: > I like the idea of caching the system locale for future use. Too bad the > std::locale is working so poorly on Windows :( > > Op zondag 6 januari 2019 19:13:28 CET schreef John Ralls: >> +const std::locale& >> +gnc_get_locale() >> +{ >>

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-09 Thread Geert Janssens
I like the idea of caching the system locale for future use. Too bad the std::locale is working so poorly on Windows :( Op zondag 6 januari 2019 19:13:28 CET schreef John Ralls: > +const std::locale& > +gnc_get_locale() > +{ > + static std::locale cached; > + static bool tried_already = false;

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2019-01-09 Thread Geert Janssens
Op dinsdag 1 januari 2019 22:14:16 CET schreef John Ralls: > Updatedvia https://github.com/Gnucash/gnucash/commit/3a105f07 > (commit) >via https://github.com/Gnucash/gnucash/commit/95bee405 (commit) >via https://github.com/Gnucash/gnucash/commit/cc3bb4ef (commit) >

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2018-11-29 Thread John Ralls
> On Nov 30, 2018, at 4:27 PM, Geert Janssens > wrote: > > Op vrijdag 30 november 2018 08:12:02 CET schreef John Ralls: >> Updated via https://github.com/Gnucash/gnucash/commit/3f09e5c6 >> (commit) >> via https://github.com/Gnucash/gnucash/commit/e81bcf6e (commit) >> via

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2018-11-29 Thread Geert Janssens
Op vrijdag 30 november 2018 08:12:02 CET schreef John Ralls: > Updatedvia https://github.com/Gnucash/gnucash/commit/3f09e5c6 > (commit) >via https://github.com/Gnucash/gnucash/commit/e81bcf6e (commit) >via https://github.com/Gnucash/gnucash/commit/bf55c30a (commit) >

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2018-11-03 Thread Frank H. Ellenberger
That is the reason, why I inserted the TODO. Because my search for URLs already resulted in 2 different patches, I did not start it, too. If you are ready with your other errands, you can go for it. Regards Frank Am 03.11.18 um 10:36 schrieb Geert Janssens: > Op zaterdag 3 november 2018 10:15:48

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2018-11-03 Thread Geert Janssens
Op zaterdag 3 november 2018 10:15:48 CET schreef Frank H. Ellenberger: > @@ -4892,8 +4892,8 @@ dgettext_swapped (const gchar *msgid, > * This is copied into GnuCash from Gtk in order to fix problems when > * empty msgids were passed through gettext(). > * > - * See https://bugs.gnucash.org/sh

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2018-09-09 Thread Geert Janssens
Op zondag 9 september 2018 23:04:26 CEST schreef Kevin Hale Boyes: > The indentation (and logic) here: > https://github.com/Gnucash/gnucash/commit/3845611f#diff-ee628819286d2dd65d45 > baf2c5ef4bbdR454 suggests that the if applies to both indented lines but > there are no braces to form a block. >

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2018-09-09 Thread Kevin Hale Boyes
The indentation (and logic) here: https://github.com/Gnucash/gnucash/commit/3845611f#diff-ee628819286d2dd65d45baf2c5ef4bbdR454 suggests that the if applies to both indented lines but there are no braces to form a block. If gsr->reg is NULL then line line 456 will throw. Kevin On Sun, 9 Sep 2018

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2018-04-10 Thread John Ralls
> On Apr 10, 2018, at 1:22 AM, Geert Janssens > wrote: > > Op dinsdag 10 april 2018 00:18:07 CEST schreef John Ralls: >> Updated via https://github.com/Gnucash/gnucash/commit/c3f528b8 >> (commit) >> via https://github.com/Gnucash/gnucash/commit/aea33ca5 (commit) >> from ht

Re: [GNC-dev] gnucash maint: Multiple changes pushed

2018-04-10 Thread Geert Janssens
Op dinsdag 10 april 2018 00:18:07 CEST schreef John Ralls: > Updatedvia https://github.com/Gnucash/gnucash/commit/c3f528b8 > (commit) >via https://github.com/Gnucash/gnucash/commit/aea33ca5 (commit) > from https://github.com/Gnucash/gnucash/commit/972647d2 (commit) > > >