Re: Error feedback on graph data selection entries

2007-12-16 Thread Jody Goldberg
The current behavior is broken, and this seems like a reasonable solution, but the api worries me. The behaviour should be consistent across the various prop dialogs. We're also too close to 1.8.0 to get this properly tested (not your fault). Please update with the comments below, and we can

Re: Error feedback on graph data selection entries

2007-12-16 Thread Emmanuel Pacaud
Le dimanche 16 décembre 2007 à 10:26 -0500, Jody Goldberg a écrit : The current behavior is broken, and this seems like a reasonable solution, but the api worries me. The behaviour should be consistent across the various prop dialogs. We're also too close to 1.8.0 to get this properly

Error feedback on graph data selection entries

2007-12-08 Thread Emmanuel Pacaud
Hi, I'm working on a patch for fixing an issue I've introduced a few months ago, when trying to update the graph data when a data selection entry lose the focus. http://svn.gnome.org/viewvc/gnumeric/trunk/src/wbc-gtk.c?view=diffr1=15757r2=15758 The issue introduced is if the expression is

Re: Error feedback on graph data selection entries

2007-12-08 Thread Emmanuel Pacaud
Here's the same patch ignoring white space changes. Emmanuel. diff --git a/src/dialogs/dialog-cell-format.c b/src/dialogs/dialog-cell-format.c index 6001e09..e38b7f3 100644 --- a/src/dialogs/dialog-cell-format.c +++ b/src/dialogs/dialog-cell-format.c @@ -1535,7 +1535,7 @@

Re: Error feedback on graph data selection entries

2007-12-08 Thread Emmanuel Pacaud
Le samedi 08 décembre 2007 à 19:51 +0100, Emmanuel Pacaud a écrit : Here's the same patch ignoring white space changes. A simplified patch that works better. It fixes the entry appearance on theme change. Emmanuel. diff --git a/src/dialogs/dialog-cell-format.c