On 3/16/19 9:44 AM, Schanzenbach, Martin wrote:
> Really? I think it is pretty obvious. The gnunet-uri arguments might
> change; the binary itself might be renamed / deleted in the future.
Unlikely. And if that happens, we can always adjust gnunet-qr.
> This is only detectable through runtime
On 3/15/19 4:06 PM, Schanzenbach, Martin wrote:
> No it was not.
> I am pretty sure that instead of calling gnunet-uri as a binary from a binary
> is pretty nonsensical.
Why? I see nothing wrong with that. It's not like this matters for
performance or that starting gnunet-uri has any other real
No it was not.
I am pretty sure that instead of calling gnunet-uri as a binary from a binary
is pretty nonsensical.
Instead, gnunet-qr should just do what gnunet-uri does with the uri.
If we need to share code between them, fine, then refactor. But imitating
python behavior here is not good
Looks good to me. Could you please push it to gnunet-*, libextractor,
libmicrohttpd and the taler-* Git repos? Thanks! -Christian
On 3/14/19 1:15 PM, Hartmut Goebel wrote:
> Hi
>> I'd say no tabs at all (in C code or texinfo), no trailing whitespace
>> (also not in C, Makefile.am, ChangeLog,
Hi Hartmut,
I've looked over the code now. A few comments:
1) I've changed configure.ac to actually make the check for *optional*
libzbar work, so that if libzbar is not present configure still runs.
Also removed use of pkgconfig (unnecessary).
2) I think you really should link against
On 3/13/19 6:25 PM, Hartmut Goebel wrote:
> Martin wrote:
>> The first thing you should do it use GNUNET_PROGRAM*.
Actually, that advice was slightly off: as you don't want/need the
scheduler, you don't need GNUNET_PROGRAM_run() but just GNUNET_GETOPT_*
for gnunet-qr.
signature.asc
Christian Grothoff transcribed 3.3K bytes:
> On 3/13/19 10:29 PM, n...@n0.is wrote:
> > Christian Grothoff transcribed 3.0K bytes:
> >> We should just deploy a Git hook to reject pushes if they contain tabs
> >> in .c or .h files, that should work as a minimal fix, right? -C
> >
> > No leading
Schanzenbach, Martin transcribed 3.5K bytes:
>
>
> > On 14. Mar 2019, at 09:10, Hartmut Goebel
> > wrote:
> >
> > Am 13.03.19 um 19:16 schrieb Schanzenbach, Martin:
> >> In the end, please also check https://docs.gnunet.org/#Coding-style and
> >> adjust your editor to it.
> >> Currently, the
By the way, there is a common format for basic formatting:
https://editorconfig.org/
That may help people without emacs at hand to have correct formatting
before git hooks kick in.
On Thu, Mar 14, 2019 at 3:15 PM Hartmut Goebel
wrote:
>
> Hi
> > I'd say no tabs at all (in C code or texinfo), no
Hi
> I'd say no tabs at all (in C code or texinfo), no trailing whitespace
> (also not in C, Makefile.am, ChangeLog, texinfo, etc.).
This is my proposed .dir-locals.el, setting some more variables being
handy (like spell-checker directory):
((nil
. ((fill-column . 78)
(tab-width . 4)
On 3/13/19 10:29 PM, n...@n0.is wrote:
> Christian Grothoff transcribed 3.0K bytes:
>> We should just deploy a Git hook to reject pushes if they contain tabs
>> in .c or .h files, that should work as a minimal fix, right? -C
>
> No leading tabs, No trailing whitespace,
> and no tabs at all?
> Or
> On 14. Mar 2019, at 09:10, Hartmut Goebel
> wrote:
>
> Am 13.03.19 um 19:16 schrieb Schanzenbach, Martin:
>> In the end, please also check https://docs.gnunet.org/#Coding-style and
>> adjust your editor to it.
>> Currently, the file has mixed spaces and tabs which is quite unreadable (for
Hartmut Goebel transcribed 1.8K bytes:
> Am 13.03.19 um 19:16 schrieb Schanzenbach, Martin:
> > In the end, please also check https://docs.gnunet.org/#Coding-style and
> > adjust your editor to it.
> > Currently, the file has mixed spaces and tabs which is quite unreadable
> > (for me).
>
>
Am 13.03.19 um 19:16 schrieb Schanzenbach, Martin:
> In the end, please also check https://docs.gnunet.org/#Coding-style and
> adjust your editor to it.
> Currently, the file has mixed spaces and tabs which is quite unreadable (for
> me).
Thanks for pointing this out, I simply missed this.
Christian Grothoff transcribed 3.0K bytes:
> We should just deploy a Git hook to reject pushes if they contain tabs
> in .c or .h files, that should work as a minimal fix, right? -C
No leading tabs, No trailing whitespace,
and no tabs at all?
Or simply no tabs?
I can arrange that either before or
Either that or have a lint job in the pipeline in the CI.
> On 13. Mar 2019, at 22:11, Christian Grothoff wrote:
>
> Signed PGP part
> We should just deploy a Git hook to reject pushes if they contain tabs
> in .c or .h files, that should work as a minimal fix, right? -C
>
> On 3/13/19 9:03
We should just deploy a Git hook to reject pushes if they contain tabs
in .c or .h files, that should work as a minimal fix, right? -C
On 3/13/19 9:03 PM, Schanzenbach, Martin wrote:
> I don't like changing somebody else's lines just for intendation because it
> messes with git blame.
> So I
Schanzenbach, Martin transcribed 5.2K bytes:
> I don't like changing somebody else's lines just for intendation because it
> messes with git blame.
> So I think it is better to hold people to the coding style.
Okay. Works for C, but not in intendation enforcing languages (Python),
where I've
I don't like changing somebody else's lines just for intendation because it
messes with git blame.
So I think it is better to hold people to the coding style.
BR
> On 13. Mar 2019, at 20:01, n...@n0.is wrote:
>
> Schanzenbach, Martin transcribed 4.9K bytes:
>> In the end, please also check
Schanzenbach, Martin transcribed 4.9K bytes:
> In the end, please also check https://docs.gnunet.org/#Coding-style and
> adjust your editor to it.
> Currently, the file has mixed spaces and tabs which is quite unreadable (for
> me).
> Now, I know this is a problem in other files as well (looking
In the end, please also check https://docs.gnunet.org/#Coding-style and adjust
your editor to it.
Currently, the file has mixed spaces and tabs which is quite unreadable (for
me).
Now, I know this is a problem in other files as well (looking at you
gnunet-ecc.c), but better not copy the bad
Hi!
> On 13. Mar 2019, at 18:25, Hartmut Goebel
> wrote:
>
> Hi Martin,
>
> Am 03.03.19 um 11:33 schrieb Schanzenbach, Martin:
>> The first thing you should do it use GNUNET_PROGRAM*.
> I followed this advice, adding options --verbose, -s/--silent and
> -d/--device. Here is the resulting
Hi Martin,
Am 03.03.19 um 11:33 schrieb Schanzenbach, Martin:
> The first thing you should do it use GNUNET_PROGRAM*.
I followed this advice, adding options --verbose, -s/--silent and
-d/--device. Here is the resulting help output, which look s good::
src/util/gnunet-qr --help
gnunet-qr
Scan a
23 matches
Mail list logo
