Re: [PATCH] Minor fix in NSWindowController

2006-04-22 Thread Fred Kiefer
Quentin Mathé wrote: I have done new tests with other applications today like Notebook, Ink and ToolbarExample (which is document based). With the two last ones, the result is a segmentation fault on a document window close :-/. It's retain/release issue. Now I think that's the extra

Re: [PATCH] Minor fix in NSWindowController

2006-04-19 Thread Quentin Mathé
Le 19 avr. 06 à 02:36, Fred Kiefer a écrit : Quentin Mathé wrote: I think you wrote the comments, here is the ChangeLog entry which introduced this 'retain' line : 2003-08-30 Fred Kiefer [EMAIL PROTECTED] * Source/NSWindowController.m Changed [setWindow:] to manage the notification

Re: [PATCH] Minor fix in NSWindowController

2006-04-18 Thread Fred Kiefer
Hi Quentin, Quentin Mathé wrote: Le 28 mars 06 à 00:57, Fred Kiefer a écrit : I am rather unsure about this patch.I don't quite remember, who did put in these commetn lines on retaining the window, but I would expect that there were reasons for it at that time. Still they may have been

Re: [PATCH] Minor fix in NSWindowController

2006-03-27 Thread Fred Kiefer
Hi Quentin, I am rather unsure about this patch.I don't quite remember, who did put in these commetn lines on retaining the window, but I would expect that there were reasons for it at that time. Still they may have been the now redundant solution of an already resolved problem. Did you do

[PATCH] Minor fix in NSWindowController

2006-03-16 Thread Quentin Mathé
Hi, Here is a little patch to have proper window controller deallocation when used in document architecture context. It is based on an initial bug report by Saso Kiselkov. I'm going to briefly summarize Cocoa documentation… When you are using a window controller within the document