Re: New ABI NSConstantString

> Am 08.04.2018 um 16:11 schrieb David Chisnall : > > On 8 Apr 2018, at 12:41, David Chisnall wrote: >> >> On 8 Apr 2018, at 10:55, Richard Frith-Macdonald >> wrote: >>> >>> >>> On 6 Apr

Re: New ABI NSConstantString

> On 6 Apr 2018, at 11:00, David Chisnall wrote: > > It would probably help catch more bugs if we made use of NSString’s > class-cluster nature more in -base. I have just fixed a bug in GSString > where we were checking one object matched a particular class before

Re: New ABI NSConstantString

On 8 Apr 2018, at 16:19, Fred Kiefer wrote: > > I think your implementation of characterAtIndex: is wrong for the UTF8 case. > Sadly things are more complicated. Please have a look at the (slow) way the > old code is handling this. All of the UTF-8 and UTF-32 cases are

Re: GSUnicodeString and NSString disagree on rangeOfComposedCharacterSequenceAtIndex:

> Am 07.04.2018 um 20:51 schrieb David Chisnall : > > I am testing out a new version of the compiler / runtime that is producing > NSConstantString instances with UTF-16 data. I have currently disabled a lot > of the NSConstantString optimisations, on the basis of

Re: GSUnicodeString and NSString disagree on rangeOfComposedCharacterSequenceAtIndex:

On 8 Apr 2018, at 09:38, Fred Kiefer wrote: > > > >> Am 07.04.2018 um 20:51 schrieb David Chisnall : >> >> I am testing out a new version of the compiler / runtime that is producing >> NSConstantString instances with UTF-16 data. I have

Re: GSUnicodeString and NSString disagree on rangeOfComposedCharacterSequenceAtIndex:

> On 8 Apr 2018, at 09:38, Fred Kiefer wrote: > > > >> Am 07.04.2018 um 20:51 schrieb David Chisnall : >> >> I am testing out a new version of the compiler / runtime that is producing >> NSConstantString instances with UTF-16 data. I have

Re: New ABI NSConstantString

On 8 Apr 2018, at 12:41, David Chisnall wrote: > > On 8 Apr 2018, at 10:55, Richard Frith-Macdonald > wrote: >> >> >> >>> On 6 Apr 2018, at 11:00, David Chisnall wrote: >>> >>> It would

Re: New ABI NSConstantString

> On 8 Apr 2018, at 12:41, David Chisnall wrote: > > On 8 Apr 2018, at 10:55, Richard Frith-Macdonald > wrote: >> >> >> >>> On 6 Apr 2018, at 11:00, David Chisnall wrote: >>> >>> It would

Re: New ABI NSConstantString

On 8 Apr 2018, at 16:27, Richard Frith-Macdonald wrote: >> I also note that a lot of the NSString method implementations are not well >> optimised. > > Yes ... because they are almost never used as we historically had unicode > string methods and