Re: [gobolinux-devel] Code Documentation Project: String patch

2008-04-14 Thread Daniele Maccari
Daniele Maccari wrote: > Omg, again, please note that in this part: > > [ $3 -lt 0 -a $(( $i+$3+1 )) -lt ${#tokens} ] && echo -n ${tokens[$(( $i+$3+1 > ))]} > > of the Get_Token function, the control about $(( $i+$3+1 )) is still wrong, > it should be greater than -1, if I'm not wrong on this too

Re: [gobolinux-devel] Code Documentation Project: String patch

2008-04-14 Thread Daniele Maccari
Omg, again, please note that in this part: [ $3 -lt 0 -a $(( $i+$3+1 )) -lt ${#tokens} ] && echo -n ${tokens[$(( $i+$3+1 ))]} of the Get_Token function, the control about $(( $i+$3+1 )) is still wrong, it should be greater than -1, if I'm not wrong on this too :D Thanks for your patience. ___

Re: [gobolinux-devel] Code Documentation Project: String patch

2008-04-14 Thread Daniele Maccari
Following Kevin's suggestions, I created another patch, which you can find attached ;) Bye --- trunk/Scripts/Functions/String 2008-04-13 19:15:44.0 +0200 +++ trunk.new/Scripts/Functions/String 2008-04-14 09:13:22.0 +0200 @@ -1,73 +1,215 @@ #!/bin/bash (source) -# ///

Re: [gobolinux-devel] Code Documentation Project: String patch

2008-04-13 Thread Daniele Maccari
Daniele Maccari wrote: > $(( $i+$3+1 )) -lt ${#tokens} > > should be ok instead. > > Bye > Wrong again, $(( $i+$3+1 )) -gt -1 ? ___ gobolinux-devel mailing list gobolinux-devel@lists.gobolinux.org http://lists.gobolinux.org/mailman/listinfo/gobolinu

Re: [gobolinux-devel] Code Documentation Project: String patch

2008-04-13 Thread Daniele Maccari
Kevin Quick wrote: > Daniele, > > A couple of English corrections (it's a crazy language!) and typos, > and a few Python recommendations. > > One specifically: since you're willing to use python herein, just use > python for the get_token: resolves ambiguity over negative indexing/ > bounds an

Re: [gobolinux-devel] Code Documentation Project: String patch

2008-04-13 Thread Kevin Quick
Daniele, A couple of English corrections (it's a crazy language!) and typos, and a few Python recommendations. One specifically: since you're willing to use python herein, just use python for the get_token: resolves ambiguity over negative indexing/ bounds and much simpler as well. :) Comm