[go-rpm-macros] PR #16: make it use the actual code that was merged in redhat-rpm-config-130

2019-06-06 Thread Jakub Čajka
jcajka commented on the pull-request: `make it use the actual code that was merged in redhat-rpm-config-130` that you are following: `` @nim if you are not looking for feedback keep it open for some time and then merge it with something like tested here in this way forks for me or just commit

[go-rpm-macros] PR #16: make it use the actual code that was merged in redhat-rpm-config-130

2019-06-05 Thread Nicolas Mailhot
nim commented on the pull-request: `make it use the actual code that was merged in redhat-rpm-config-130` that you are following: `` @bex sadly there are not many (any?) good wills to do regular reviewing. The repo history shows long periods of one-man commits, be it now or when the

[go-rpm-macros] PR #16: make it use the actual code that was merged in redhat-rpm-config-130

2019-06-05 Thread bex
bex commented on the pull-request: `make it use the actual code that was merged in redhat-rpm-config-130` that you are following: `` @nim it is customary in almost every project I have been in that someone doesn't merge their own commit unless time has passed/emergency situations. I think what

[go-rpm-macros] PR #16: make it use the actual code that was merged in redhat-rpm-config-130

2019-06-05 Thread Nicolas Mailhot
nim commented on the pull-request: `make it use the actual code that was merged in redhat-rpm-config-130` that you are following: `` Ah, that Just because it is trivial does not mean stupid typos can not happen, so the commits cook in a private feature branch (where I can rewrite git history

[go-rpm-macros] PR #16: make it use the actual code that was merged in redhat-rpm-config-130

2019-06-05 Thread Igor Gnatenko
ignatenkobrain commented on the pull-request: `make it use the actual code that was merged in redhat-rpm-config-130` that you are following: `` I mean, if it is trivial - just commit it. I this not first PR where this happens. `` To reply, visit the link below or just reply to this email

[go-rpm-macros] PR #16: make it use the actual code that was merged in redhat-rpm-config-130

2019-06-05 Thread Nicolas Mailhot
nim commented on the pull-request: `make it use the actual code that was merged in redhat-rpm-config-130` that you are following: `` @ignatenkobrain sorry, I didn't know there was much interest in reviewing such a trivial commit (or in go-rpm-macros PRs in general). If you have any comment on

[go-rpm-macros] PR #16: make it use the actual code that was merged in redhat-rpm-config-130

2019-06-04 Thread Igor Gnatenko
ignatenkobrain commented on the pull-request: `make it use the actual code that was merged in redhat-rpm-config-130` that you are following: `` I would appreciate if you would not merge your own PRs in one minute after opening. `` To reply, visit the link below or just reply to this email

[go-rpm-macros] PR #16: make it use the actual code that was merged in redhat-rpm-config-130

2019-06-04 Thread Nicolas Mailhot
nim opened a new pull-request against the project: `go-rpm-macros` that you are following: `` make it use the actual code that was merged in redhat-rpm-config-130 `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/16

[go-rpm-macros] PR #16: make it use the actual code that was merged in redhat-rpm-config-130

2019-06-04 Thread Nicolas Mailhot
nim merged a pull-request against the project: `go-rpm-macros` that you are following. Merged pull-request: `` make it use the actual code that was merged in redhat-rpm-config-130 `` https://pagure.io/go-rpm-macros/pull-request/16 ___ golang mailing