The status of the issue: `golist should be buildroot prefix aware` of project:
`golist` has been updated to: Closed by nim.
https://pagure.io/golist/issue/12
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to
nim opened a new pull-request against the project: `go-rpm-macros` that you are
following:
``
Use relative symlinks for goalts; workarounds https://pagure.io/golist/issue/12
https://github.com/rpm-software-management/rpm/issues/671
``
To reply, visit the link below or just reply to this email
qulogic commented on the pull-request: `WIP: Add output templating` that you
are following:
``
@nim ?
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/23
___
golang mailing list --
qulogic merged a pull-request against the project: `golist` that you are
following.
Merged pull-request:
``
Add ignored Go files install list
``
https://pagure.io/golist/pull-request/20
___
golang mailing list -- golang@lists.fedoraproject.org
To
nim merged a pull-request against the project: `go-rpm-macros` that you are
following.
Merged pull-request:
``
Use relative symlinks for goalts; workarounds https://pagure.io/golist/issue/12
https://github.com/rpm-software-management/rpm/issues/671
``
nim added a new comment to an issue you are following:
``
Ok, I found a workaround. Let’s focus on still broken things for now
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/12
___
golang mailing list --
nim commented on the pull-request: `WIP: Add output templating` that you are
following:
``
@qulogic Looks good (not tested). Not sure the `\n` is necessary for
`BuildRequires` but having the option to put everything on one line may be
useful for `go test`
``
To reply, visit the link below or
nim added a new comment to an issue you are following:
``
@eclipseo Please play a little with `modist` and tell us if it is better. I
tried to fix the CLI interface.
`cobra` is difficult to use in a core utility like `golist`. It has lots of
requirements, so bootsrapping a Go stack that
The issue: `golist needs a switch to process a codebase and its tests in a
single pass` of project: `golist` has been assigned to `qulogic` by qulogic.
https://pagure.io/golist/issue/3
___
golang mailing list -- golang@lists.fedoraproject.org
To
nim commented on the pull-request: `Add ignored Go files install list` that you
are following:
``
Indeed, it is very nice to see `golist` being improved at last!
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/20
qulogic opened a new pull-request against the project: `golist` that you are
following:
``
WIP: Add output templating
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/23
___
golang mailing list --
qulogic added a new comment to an issue you are following:
``
True, `cobra` uses quite a bit; `pflag` has no dependencies though, which would
be even better than `urfave/cli`.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/21
jcajka commented on the pull-request: `Add ignored Go files install list` that
you are following:
``
@qulogic Looks great to me. It seems that it is picking up all the files. For
other arches and other OSes(win,*bsd,macos).
``
To reply, visit the link below or just reply to this email
qulogic commented on the pull-request: `Add ignored Go files install list` that
you are following:
``
It's a super-ugly hack of a test, but I tried this out on
`golang-github-kr-pty` with a scratch build on koji:
* First add `BuildArch: noarch` to existing package, which
qulogic opened a new pull-request against the project: `golist` that you are
following:
``
Allow specifying multiple package paths at a time.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/22
___
nim added a new comment to an issue you are following:
``
The download is a no-go since it will be blocked by CI/CD systems like `mock`.
It should be possible to avoid setting a build-specific `GOPATH` in golist, by
importing directly the directories golist operates on, and taking other code
qulogic added a new comment to an issue you are following:
``
Do you need format string for file lists (or just the provided/installed)?
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/13
___
golang mailing
qulogic opened a new pull-request against the project: `golist` that you are
following:
``
Add ignored Go files install list
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/20
___
golang mailing
qulogic added a new comment to an issue you are following:
``
Is this not all handled when in `BUILD`? Or is something changing as to when
`golist` is called?
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/12
On 3/27/19, Nicolas Mailhot wrote:
> Le 2019-03-27 10:25, fge...@gmail.com a écrit :
>> On 3/27/19, 'Nicolas Mailhot' via golang-dev
>> wrote:
>> ...
Anyway here is the code, not finished, not feature-complete, very
lightly tested, but already doing some useful things
The issue: `golist processing is arch and tag-specific` of project: `golist`
has been assigned to `qulogic` by qulogic.
https://pagure.io/golist/issue/2
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to
nim added a new comment to an issue you are following:
``
> Do you need format string for file lists (or just the provided/installed)?
There's no need to format file lists, as long as the installation is left to
something else.
If golist was to take over installation (as is done by modist
qulogic reported a new issue against the project: `golist` that you are
following:
``
I don't really like the way the command-line arguments are specified right now.
Everything is an optional flag which requires writing out a redundant argument
name. This would be even worse with #4. Also,
The issue: `golist should permit specifying its output format` of project:
`golist` has been assigned to `qulogic` by qulogic.
https://pagure.io/golist/issue/13
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to
qulogic commented on the pull-request: ` Add ignored Go files install list`
that you are following:
``
There are 43 specs without noarch:
```
$ rg --files-without-match 'BuildArch: *noarch' golang* | sort
golang-bazil-fuse.spec
golang-github-aead-chacha20.spec
golang-github-aead-poly1305.spec
qulogic added a new comment to an issue you are following:
``
Might be possible with
[tools/go/packages](https://godoc.org/golang.org/x/tools/go/packages), but I've
read that it's much much slower since it tries to do a full module download.
This might be mitigated by setting up a GOPROXY.
``
The status of the issue: `Crash when processing github.com/kr/pretty 0.1.0` of
project: `golist` has been updated to: Closed by qulogic.
https://pagure.io/golist/issue/8
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an
qulogic commented on the pull-request: ` Add ignored Go files install list`
that you are following:
``
Here's what we get with the new version compared to currently packaged:
```
--- before 2019-04-16 22:43:37.852194764 -0400
+++ after 2019-04-16 22:43:39.333180958 -0400
@@ -99,6
qulogic added a new comment to an issue you are following:
``
Closing as a duplicate of #7.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/8
___
golang mailing list -- golang@lists.fedoraproject.org
To
The status of the issue: `golist should be ported to a current release of
gopkg.in/urfave/cli.v1` of project: `golist` has been updated to: Closed by
qulogic.
https://pagure.io/golist/issue/1
___
golang mailing list -- golang@lists.fedoraproject.org
qulogic added a new comment to an issue you are following:
``
Fixed by #16.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/1
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an
qulogic commented on the pull-request: `Replace Go internals with go/build`
that you are following:
``
I'm going to merge this, as those two packages are failing due to the way they
use Go modules, and getting testing working everywhere is more important. They
can just be patched to work right
nim added a new comment to an issue you are following:
``
I don't remember where the files end up (under `BUILD` or `BUILDROOT`) and I
may have mixed up the rpm variable representing rpm's last stage staging
directory.
The basic point is that for `Requires`/`Provides` we are not calling
qulogic merged a pull-request against the project: `golist` that you are
following.
Merged pull-request:
``
Fix compile against latest urfave/cli.
``
https://pagure.io/golist/pull-request/16
___
golang mailing list -- golang@lists.fedoraproject.org
On 3/27/19, 'Nicolas Mailhot' via golang-dev
wrote:
...
>> Anyway here is the code, not finished, not feature-complete, very
>> lightly tested, but already doing some useful things
>> https://pagure.io/modist/
...
> And I should have added, the readme is sparse but the tool should be
> self
eclipseo commented on the pull-request: `Add ignored Go files install list`
that you are following:
``
Lookr good! Thanks for all the work!
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/20
___
eclipseo opened a new pull-request against the project: `go-rpm-macros` that
you are following:
``
Fix missing variable in license detection
``
To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/8
eclipseo opened a new pull-request against the project: `golist` that you are
following:
``
Initialize load.Mod* variables in ListPackage...
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/19
___
eclipseo added a new comment to an issue you are following:
``
If I initialize the variables to be non nil,
```
load.ModImportPaths = modload.ImportPaths
load.ModBinDir = modload.BinDir
load.ModLookup = modload.Lookup
load.ModDirImportPath = modload.DirImportPath
eclipseo added a new comment to an issue you are following:
``
Add a rimilar error with latest golang-github-sirupsen-logrus:
```
Testing in:
/home/bob/packaging/golang/golang-github-Sirupsen-logrus/logrus-1.4.0/_build/src
PATH:
eclipseo added a new comment to an issue you are following:
``
PR that works: https://pagure.io/golist/pull-request/19
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
___
golang mailing list --
nim merged a pull-request against the project: `go-rpm-macros` that you are
following.
Merged pull-request:
``
Fix missing variable in license detection
``
https://pagure.io/go-rpm-macros/pull-request/8
___
golang mailing list --
nim commented on the pull-request: `Fix missing variable in license detection`
that you are following:
``
Good catch, thanks, the variable was dropped in a recent code cleanup.
``
To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/8
On Mon, Mar 11, 2019 at 8:01 AM Nicolas Mailhot
wrote:
> And as I have explained in the detailed description Matthew requested,
>
To be clear, I was asking for details to reproduce the technical issues
you're running into. I may have missed them, but I don't believe you've
provided these.
our
Quoting Matthew Dempsky (2019-03-11 13:54:07)
>On Mon, Mar 11, 2019 at 8:01 AM Nicolas Mailhot
><[1]nicolas.mail...@laposte.net> wrote:
>
> And as I have explained in the detailed description Matthew
> requested,
>
>To be clear, I was asking for details to reproduce the
Don't google use Blaze/Bazel for builds internally? I don't think go
get and modules are hugely relevant in that context (see
https://github.com/bazelbuild/rules_go#does-this-work-with-go-modules).
On Tue, 12 Mar 2019 at 09:49, Jakub Cajka wrote:
>
>
>
>
>
> - Original Message -
> >
eclipseo reported a new issue against the project: `golist` that you are
following:
``
$GOPATH is deprecated, we shouldn't use it anymore.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/18
___
golang
On Mon, Mar 11, 2019 at 11:09 AM Florian Weimer wrote:
> How do you plan to bypass the notary requirement?
I don't work on the Go-inside-Google integration work, so someone else may
have to weigh in if it's appropriate to share those plans. My point with
mentioning Google's hermetic build
Quoting Russ Cox (2019-03-11 10:43:28)
>[One of the things go list computes is the dependency graph
>(visible if you use go list -json or go list -f '{{.Deps}}').]
Ah, that makes more sense.
___
golang mailing list --
On Sat, Mar 9, 2019 at 2:55 PM Ian Denhardt wrote:
> Here's a reproducer:
>
> > $ go mod init example.org/my-project
> > go: creating new go.mod: module example.org/my-project
> > $ cat >> main.go << "EOF"
> > package main
> > import _ "example.com/other-module"
> > func main() {}
> > EOF
> > $
Last time this discussion came up in person, someone from the Go team
suggested replacing all the go.mod files with new ones that are
entirely based on package metadata -- i.e. declared dependencies,
their installed location etc.
This seems like a reasonable solution, and it would be a pity if
Quoting 'Matthew Dempsky' via golang-dev (2019-03-08 21:01:32)
>Can you provide more detailed reproduction steps?
Here's a reproducer:
> $ go mod init example.org/my-project
> go: creating new go.mod: module example.org/my-project
> $ cat >> main.go << "EOF"
> package main
> import _
On Fri, Mar 8, 2019 at 4:52 PM 'Nicolas Mailhot' via golang-dev <
golang-...@googlegroups.com> wrote:
> It would be nice if it where true. Unfortunately even a simple command
> like tell me what you know about the local code tree
> go list -json -mod=readonly ./...
>
> will abort if the CI/CD
On Thu, Mar 7, 2019 at 5:52 AM Jakub Cajka wrote:
> As I will carefully evaluate all the details of the final implementation,
> but from this first look I'm currently leaning to "patch out" or
> de-configure by default this feature in Fedora when/if it lands in upstream
> GC, to preserve the
On Fri, Mar 8, 2019 at 8:09 AM 'Nicolas Mailhot' via golang-dev <
golang-...@googlegroups.com> wrote:
> The notary part of Go modules, like the rest of the module
> implementation, suffers from a lack of understanding of integration and
> QA workflows, and a simplistic dev-centric worldview.
>
On Fri, Mar 8, 2019 at 4:52 PM 'Nicolas Mailhot' via golang-dev
wrote:
>
> Le vendredi 08 mars 2019 à 10:28 -0500, Russ Cox a écrit :
> > On Fri, Mar 8, 2019 at 8:09 AM 'Nicolas Mailhot' via golang-dev <
> > golang-...@googlegroups.com> wrote:
> > > The notary part of Go modules, like the rest of
nim added a new comment to an issue you are following:
``
Ok I've checked the current code and the problem also exists here.
I have a fix, will commit it once I'm somewhere that allows ssh access to
pagure (since pagure does not allow https commits)
``
To reply, visit the link below or just
nim added a new comment to an issue you are following:
``
(BTW did you check what happens with the current macro version? This part has
been refactored for more robustness, even though this is definitely a case I
didn't check so if it's fixed it's fixed as a side effect of something else ;))
``
qulogic reported a new issue against the project: `go-rpm-macros` that you are
following:
``
In the old version of
[golang-github-pkg-errors](https://src.fedoraproject.org/rpms/golang-github-pkg-errors/blob/f28/f/golang-github-pkg-errors.spec),
there was a typo, and `glide.yaml` was listed
nim commented on the pull-request: `Replace Go internals with go/build` that
you are following:
``
The v2 is module versioning. That's something we need to support to have
working Go packaging. It's good that your PR starts picking it up when the
previous code does not.
However you are right
nim added a new comment to an issue you are following:
``
Yes goinstall error checking should be improved (even though the target will be
modules soonish that should hopefully remove the need for custom install hacks)
``
To reply, visit the link below or just reply to this email
nim commented on the pull-request: `Replace Go internals with go/build` that
you are following:
``
Ok, after more work evolving to module support seems a bit simpler than I
though, because go mod need requires people to clean up their mess and that's
also the assumption of the current
The issue: `didn't find "github.com/google/go-cmp/cmp"` of project: `golist`
has been assigned to `nim` by nim.
https://pagure.io/golist/issue/6
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to
qulogic added a new comment to an issue you are following:
``
I think most of the code is already written to handle this; it just needs to
fix the CLI flags to work correctly.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/4
nim added a new comment to an issue you are following:
``
I will recheck. cloud.google.com/go is a full bag of nastiness, that even other
Google projects have problems with (most of them still import it under a legacy
name, which means they are afraid of using the latest code. The current
The issue: `incomplete import detection for tests ` of project: `golist` has
been assigned to `nim` by nim.
https://pagure.io/golist/issue/9
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to
qulogic commented on the pull-request: `Replace Go internals with go/build`
that you are following:
``
As a note, the original code ran a resolve on the test imports, but not the
regular imports. I tried adding a resolve on the regular imports as well, but
it doesn't help. I also tried setting
qulogic commented on the pull-request: `Replace Go internals with go/build`
that you are following:
``
So for tests, I searched the specs for all that define`goipath` and cloned all
of them (note this is _not_ all Go packages.) Then ran `golist` as packaged and
`golist` from this PR and
nim added a new comment to an issue you are following:
``
golist does not uses this kind or regexes it plugs directly in the Go compiler
inner code to match the Go compiler view of what's in a project. This was a
deliberate choice by Fedora Go maintainers last year, my initial macro
The issue: `golist needs to be able to process multiple import paths in one
pass` of project: `golist` has been assigned to `qulogic` by qulogic.
https://pagure.io/golist/issue/4
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe
qulogic added a new comment to an issue you are following:
``
Aren't Go tests in files that end with `_test.go`? Since
`terminal_check_notappengine.go` is not one of those, it shouldn't be output
with `--tests`. It _is_ output in the normal (no `--tests`) results.
``
To reply, visit the link
nim added a new comment to an issue you are following:
``
BTW:
* thanks an *awful* lot for looking at golist code maintenance
* if you can figure how to make golist process module info, and spit out the
version constrains that only exists in those modules, that would be much nicer
than
The issue: `runtime panic, nil dereference when running %gochecks` of project:
`golist` has been assigned to `qulogic` by qulogic.
https://pagure.io/golist/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email
nim added a new comment to an issue you are following:
``
Yes, I suppose an alternative would be to track the things that depends on this
bit of code and ask them to drop it.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/10
qulogic added a new comment to an issue you are following:
``
This looks the same as #7, no?
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/8
___
golang mailing list -- golang@lists.fedoraproject.org
To
qulogic opened a new pull-request against the project: `golist` that you are
following:
``
Replace Go internals with go/build
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/17
___
golang mailing
qulogic added a new comment to an issue you are following:
``
What I'm saying is that golist does _not_ think it's a test file, and I'm
confused why you think it should be.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/9
nim added a new comment to an issue you are following:
``
Ah ok. I think that's because we only hit it when executing tests. Will look at
it once more, maybe the logrus code was refactored since this was filed
``
To reply, visit the link below or just reply to this email
qulogic added a new comment to an issue you are following:
``
The backtraces point to line 1888 here:
```go
1886 func ImportPaths(args []string) []*search.Match {
1887 if ModInit(); cfg.ModulesEnabled {
1888>return ModImportPaths(args)
1889 }
1890 return
qulogic added a new comment to an issue you are following:
``
Is this still a problem?
```
$ golist --imported --package-path cloud.google.com/go --skip-self | rg go-cmp
github.com/google/go-cmp/cmp
$ golist --imported --package-path cloud.google.com/go --skip-self --tests | rg
go-cmp
qulogic added a new comment to an issue you are following:
``
This package also fails `go build` with the same message, so I'm not sure we
can really blame `golist`. It seems to be an outdated and broken-on-latest-Go
package.
``
To reply, visit the link below or just reply to this email
jcajka merged a pull-request against the project: `go-rpm-macros` that you are
following.
Merged pull-request:
``
Update bootstrapping link
``
https://pagure.io/go-rpm-macros/pull-request/5
___
golang mailing list -- golang@lists.fedoraproject.org
nim added a new comment to an issue you are following:
``
Sure it does, however till someone analyses both issues and concludes they are
the same, it's dangerous to track only one of them.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/8
qulogic added a new comment to an issue you are following:
``
Well, the null pointer is here:
```
/builddir/build/BUILD/symbols-extractor-9f4330a0f4437ca61ba92f9f30e34424c6742ad6/_build/src/github.com/gofed/symbols-extractor/pkg/util/internal/load/pkg.go:1888
+0x5f fp=0xc000123038
The issue: `golist should be ported to a current release of
gopkg.in/urfave/cli.v1` of project: `golist` has been assigned to `qulogic` by
qulogic.
https://pagure.io/golist/issue/1
___
golang mailing list -- golang@lists.fedoraproject.org
To
qulogic added a new comment to an issue you are following:
``
Based on [further debugging](https://pagure.io/golist/issue/7#comment-551104),
this appears related to Go modules. As such, an alternate workaround is to set
`GO111MODULES=off` before calling `golist`. Of course, you need to be sure
qulogic added a new comment to an issue you are following:
``
Should I push a fix directly (I think I can at least) or open a PR?
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/1
___
golang mailing list --
The issue: `golist needs to be run outside the source tree to avoid panics` of
project: `go-rpm-macros` has been assigned to `nim` by nim.
https://pagure.io/go-rpm-macros/issue/6
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe
nim added a new comment to an issue you are following:
``
For readers that don't understand the latest exchange, the participants wrote
their piece here https://pagure.io/GoSIG/go-sig/issue/3
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
qulogic added a new comment to an issue you are following:
``
A workaround I've found that appears to work is:
```rpm
%check
builddir="$PWD/_build"
cd ..
%gochecks -b "$builddir"
```
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
nim added a new comment to an issue you are following:
``
@jcajka: how do you expect anyone to understand your position? Months over
months of not accepting macro fixes, months over months of finding new reasons
not to look at them, refusal to discuss it in SIG meetings, no activity in the
nim added a new comment to an issue you are following:
``
That sucks since other projects *expect* to be in the source dir when run. So
I guess the shell wrapper will need to be changed to run golist outside this
dir and switch to it afterwards: (
I've filled it as
nim added a new comment to an issue you are following:
``
@qulogic this is all originally @jchaloup 's code. He asked to split it in a
separate repository, but I don't know what's the level of involvement he wants
(and can) provide here. Ask him politely how he wants to do things (of course
if
jcajka added a new comment to an issue you are following:
``
@nim I would much appreciate if you woudn't put words in to my mouth, thanks
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
___
golang mailing
nim reported a new issue against the project: `golist` that you are following:
``
Because the naming of Go projects is a mess many of them (including core Google
modules) have started asserting how they should be named.
This results in golist panics.
Because golist is often called by other
nim added a new comment to an issue you are following:
``
Yes that's what I meant by a little tricky. The changes are not big or scary
but they are spread over several packages that call one another, it's easier to
publish a copr with all the small changes than try to walk you through it
qulogic added a new comment to an issue you are following:
``
So is this or is this not a problem? Are tests actually being run or are they
being ignored just like this panic?
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
The status of the issue: `Missing pkg/util/internal directory` of project:
`golist` has been updated to: Closed by qulogic.
https://pagure.io/golist/issue/15
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to
qulogic reported a new issue against the project: `golist` that you are
following:
``
```
$ go get pagure.io/golist/...
package pagure.io/golist/pkg/util/internal/load: unrecognized import path
"pagure.io/golist/pkg/util/internal/load" (parse
mooz added a new comment to an issue you are following:
``
rpmbuild doesn't appear to want to give me any verbosity, I ran it with the
--showrc flag and it looks to be stopping at the forgesource if statement below:
```
-- All the Go packaging automation relies on goipath being set
local
1 - 100 of 158 matches
Mail list logo
