[golist] Issue #9: incomplete import detection for tests

2019-04-25 Thread Nicolas Mailhot
The issue: `incomplete import detection for tests ` of project: `golist` has been assigned to `nim` by nim. https://pagure.io/golist/issue/9 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to

[golist] Issue #9: incomplete import detection for tests

2019-04-25 Thread Nicolas Mailhot
nim added a new comment to an issue you are following: `` golist does not uses this kind or regexes it plugs directly in the Go compiler inner code to match the Go compiler view of what's in a project. This was a deliberate choice by Fedora Go maintainers last year, my initial macro

[golist] Issue #9: incomplete import detection for tests

2019-04-25 Thread Elliott Sales de Andrade
qulogic added a new comment to an issue you are following: `` Aren't Go tests in files that end with `_test.go`? Since `terminal_check_notappengine.go` is not one of those, it shouldn't be output with `--tests`. It _is_ output in the normal (no `--tests`) results. `` To reply, visit the link

[golist] Issue #9: incomplete import detection for tests

2019-04-25 Thread Elliott Sales de Andrade
qulogic added a new comment to an issue you are following: `` What I'm saying is that golist does _not_ think it's a test file, and I'm confused why you think it should be. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/9

[golist] Issue #9: incomplete import detection for tests

2019-04-25 Thread Nicolas Mailhot
nim added a new comment to an issue you are following: `` Ah ok. I think that's because we only hit it when executing tests. Will look at it once more, maybe the logrus code was refactored since this was filed `` To reply, visit the link below or just reply to this email

[golist] Issue #9: incomplete import detection for tests

2019-04-25 Thread Nicolas Mailhot
nim reported a new issue against the project: `golist` that you are following: `` ```sh $ golist --imported --package-path github.com/sirupsen/logrus --skip-self --tests ``` only outputs ``` github.com/stretchr/testify/assert ``` for sirupsen logrus, when the terminal_check_notappengine.go