[golist] Issue #9: incomplete import detection for tests
The issue: `incomplete import detection for tests ` of project: `golist` has been assigned to `nim` by nim. https://pagure.io/golist/issue/9 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #9: incomplete import detection for tests
nim added a new comment to an issue you are following: `` golist does not uses this kind or regexes it plugs directly in the Go compiler inner code to match the Go compiler view of what's in a project. This was a deliberate choice by Fedora Go maintainers last year, my initial macro implementation just performed regexes in shell scripts. So golist results should be more correct that what you would expect naïvely from a human file path analysis. Unfortunately that also assumes the integration with Go compiler rules is correct and complete. For example golist would initially parse files starting with '_', even though the Go spec says it should not, I suppose because Google implemented '_' in some other place of its codebase. So basically, it's not as clear cut as that, this issue needs investigating why the Go compiler code thinks this file is a test file, and whether this is correct WRT the Go language spec, and not superseeded by some other exception golist does not implement. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/9 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #9: incomplete import detection for tests
qulogic added a new comment to an issue you are following: `` Aren't Go tests in files that end with `_test.go`? Since `terminal_check_notappengine.go` is not one of those, it shouldn't be output with `--tests`. It _is_ output in the normal (no `--tests`) results. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/9 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #9: incomplete import detection for tests
qulogic added a new comment to an issue you are following: `` What I'm saying is that golist does _not_ think it's a test file, and I'm confused why you think it should be. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/9 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #9: incomplete import detection for tests
nim added a new comment to an issue you are following: `` Ah ok. I think that's because we only hit it when executing tests. Will look at it once more, maybe the logrus code was refactored since this was filed `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/9 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #9: incomplete import detection for tests
nim reported a new issue against the project: `golist` that you are following: `` ```sh $ golist --imported --package-path github.com/sirupsen/logrus --skip-self --tests ``` only outputs ``` github.com/stretchr/testify/assert ``` for sirupsen logrus, when the terminal_check_notappengine.go test imports ``` golang.org/x/crypto/ssh/terminal `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/9 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
