qulogic commented on the pull-request: `Replace Go internals with go/build`
that you are following:
``
I'm going to merge this, as those two packages are failing due to the way they
use Go modules, and getting testing working everywhere is more important. They
can just be patched to work right
nim commented on the pull-request: `Replace Go internals with go/build` that
you are following:
``
The v2 is module versioning. That's something we need to support to have
working Go packaging. It's good that your PR starts picking it up when the
previous code does not.
However you are right
nim commented on the pull-request: `Replace Go internals with go/build` that
you are following:
``
Ok, after more work evolving to module support seems a bit simpler than I
though, because go mod need requires people to clean up their mess and that's
also the assumption of the current
qulogic commented on the pull-request: `Replace Go internals with go/build`
that you are following:
``
As a note, the original code ran a resolve on the test imports, but not the
regular imports. I tried adding a resolve on the regular imports as well, but
it doesn't help. I also tried setting
qulogic commented on the pull-request: `Replace Go internals with go/build`
that you are following:
``
So for tests, I searched the specs for all that define`goipath` and cloned all
of them (note this is _not_ all Go packages.) Then ran `golist` as packaged and
`golist` from this PR and
qulogic opened a new pull-request against the project: `golist` that you are
following:
``
Replace Go internals with go/build
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/17
___
golang mailing
