[golist] PR #25: Always install SFiles whatever the arch

2019-06-14 Thread Elliott Sales de Andrade
qulogic merged a pull-request against the project: `golist` that you are following. Merged pull-request: `` Always install SFiles whatever the arch `` https://pagure.io/golist/pull-request/25 ___ golang mailing list -- golang@lists.fedoraproject.org

[golist] PR #25: Always install SFiles whatever the arch

2019-06-14 Thread Elliott Sales de Andrade
qulogic commented on the pull-request: `Always install SFiles whatever the arch` that you are following: `` LGTM. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/25 ___ golang mailing list --

[golist] PR #25: Always install SFiles whatever the arch

2019-06-14 Thread Robert-André Mauchin
eclipseo commented on the pull-request: `Always install SFiles whatever the arch` that you are following: `` Used: ``` Value: {".proto", ".md", ".s"}, ``` We're still using the v1 of urfave/cli. v2 never caught up and the whole project seems abandoned since 2016.

[golist] PR #25: Always install SFiles whatever the arch

2019-06-14 Thread Nicolas Mailhot
nim commented on the pull-request: `Always install SFiles whatever the arch` that you are following: `` Ok, weird that @jchaloup gone to all this pain for something that does not work Reading the urfave/cli documentation (that I don’t know well, I used jawher/mow.cli in modist), it seems you

[golist] PR #25: Always install SFiles whatever the arch

2019-06-14 Thread Robert-André Mauchin
eclipseo commented on the pull-request: `Always install SFiles whatever the arch` that you are following: `` It seems the "other files" are not included by default but need to be specified with --include-extension. `` To reply, visit the link below or just reply to this email

[golist] PR #25: Always install SFiles whatever the arch

2019-06-14 Thread Robert-André Mauchin
eclipseo commented on the pull-request: `Always install SFiles whatever the arch` that you are following: `` Tested and it doesn't work. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/25 ___ golang

[golist] PR #25: Always install SFiles whatever the arch

2019-06-14 Thread Robert-André Mauchin
eclipseo commented on the pull-request: `Always install SFiles whatever the arch` that you are following: `` > I assume you checked it builds and works I haven't. But I assume it would work. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/25

[golist] PR #25: Always install SFiles whatever the arch

2019-06-14 Thread Nicolas Mailhot
nim commented on the pull-request: `Always install SFiles whatever the arch` that you are following: `` That looks good to me (I assume you checked it builds and works). That's how I would have done it. @qulogic up to you now `` To reply, visit the link below or just reply to this email

[golist] PR #25: Always install SFiles whatever the arch

2019-06-14 Thread Robert-André Mauchin
eclipseo opened a new pull-request against the project: `golist` that you are following: `` Always install SFiles whatever the arch `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/25 ___ golang