qulogic merged a pull-request against the project: `golist` that you are
following.
Merged pull-request:
``
Fix not listing packages with external tests only
``
https://pagure.io/golist/pull-request/27
___
golang mailing list --
qulogic commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
Oh, and of course, that's what the recently merged PR#26 does, so there's no
need to modify this PR to do it too (unless you want to rebase.)
``
To reply, visit the link below
qulogic commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
This breaks a few things, e.g., [ golang-github-pquerna-otp
](https://copr.fedorainfracloud.org/coprs/qulogic/golist-pr27/build/1217039/),
[
qulogic commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
This would affect approximately 200 packages. Since this determines which test
files to run, it could have some possible consequences for the build, but
probably not the final
qulogic commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
Coming back to what this PR is actually about, there may be one more case of
`TestGoFiles` that you haven't changed to add `XTestGoFiles` in
`BuildArtifact`, though I'm not
qulogic commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
> @obudai a lot of Go projects use internal in the package path to mean the
> same thing as the internal keyword. Welcome to the wonderful land of
> underspecified Go
nim commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
@jcajka the macros do not add any policy over golist output. Any policy is
manual use of override switches by packagers in their spec
As for upstreams… you realise that telling
jcajka commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
@nim I have assumed that this has been transparently handled in the new macros.
I guess there should be some way whatever in the macros or document it in the
guidelines that
nim commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
@jcajka I agree from a theoretical POW. I was just pointing out that from a
practical POW, asking all the Go parts we package to adhere strictly to the
specs, means dealing with a
jcajka commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
@nim TBH I don't think that we should be creating our own dialect of Go(even
from tooling perspective). What you are suggesting is basically it. We should
respect upstream specs
nim commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
@obudai a lot of Go projects use internal in the package path to mean the same
thing as the internal keyword. Welcome to the wonderful land of underspecified
Go behaviour.
nim commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
That would wreck havoc on all package BRs since internal is a magic keyword
that forbids exposing the result to other Go packages.
Returning anything internal in `golist` must be
obudai commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
Running
```
golist --provided --tests --package-path github.com/osbuild/osbuild-composer
```
Without fix:
```
github.com/osbuild/osbuild-composer/internal/crypt
qulogic commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
Do you have an example?
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/27
___
obudai opened a new pull-request against the project: `golist` that you are
following:
``
Fix not listing packages with external tests only
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/27
___
15 matches
Mail list logo
