Re: [go-nuts] Shrinking pprof data for PGO through quantization.

2023-11-17 Thread 'Adam Azarchs' via golang-nuts
otal sample weight from the profile the compiler will probably > decide a few functions on the edge are no longer hot. To do this > losslessly, I think we'd need to keep the remaining weight in the profile > as a single "unknown" sample and have the compiler always sort th

[go-nuts] Shrinking pprof data for PGO through quantization.

2023-11-09 Thread 'Adam Azarchs' via golang-nuts
It's great that we have PGO support in go now, and it's relatively easy to use. One thing that is of mild concern to me is that typically one will be checking the default.pgo file in to the repo, and git is notoriously not great at handling binary blobs that are updated frequently. Its "diff

[go-nuts] Re: gomod is it ok to clone a remote into a local directory ?

2021-05-04 Thread 'Adam Azarchs' via golang-nuts
That's a totally reasonable thing to do, and in fact co-developing two modules the way you are describing is probably one of the best use cases for `replace` directives. Though, keep in mind that replace directives won't actually be honored by any packages which depend on yours (in this exampl