Re: [go-nuts] Building the embedded static assets prototype

2020-10-09 Thread David Moles
I think I'm overthinking this -- what it seems to amount to is that this change broke dwarf.go (as well as a bunch of other files) and that either the prototype never compiled, or there were some changes RSC forgot to check in. I found a few

Re: [go-nuts] Building the embedded static assets prototype

2020-10-09 Thread David Moles
Good thought. Even after git clean -fdx, though, the branch change-243945 fails with the dwarf-related errors, and with go1.15.2 + cherry-picked 95a456f I get this: /Users/david/Projects/Scratch/goroot/src/cmd/go/internal/load/pkg.go:404:22: pp.EmbedPatterns undefined (type *build.Package has

Re: [go-nuts] Building the embedded static assets prototype

2020-10-08 Thread Ian Lance Taylor
On Thu, Oct 8, 2020 at 3:46 PM David Moles wrote: > > I'm trying to build the prototype code for the embedded static assets > proposal, but I'm not having any luck. I'm new to building Go from source, > and new to gerrit and to the Go contribution & development process, so > apologies in

[go-nuts] Building the embedded static assets prototype

2020-10-08 Thread David Moles
I'm trying to build the prototype code for the embedded static assets proposal , but I'm not having any luck. I'm new to building Go from source, and new to gerrit and to