Re: [go-nuts] Do you check in vendor packages?

2017-09-17 Thread gurpartap
Create a separate repo for vendor directory. Set it to "auto check-in" in main repo's git push hook. Done. Moreover, with submodule hash info included in main repo commits, the vendor repo can map better on checkouts. You could this skip submodules mapping if you don't mind rewinding manually

Re: [go-nuts] Do you check in vendor packages?

2017-09-15 Thread Will Faught
Kevin, Henrik: Thanks for replying! Have you ever had to check in very large dependencies? Would you still do it if just one dep added 30 MB to your 10 MB repo? What if the size of your code is dwarfed by the size of your deps 10:1? I'm curious how far people are willing to go to check in their

Re: [go-nuts] Do you check in vendor packages?

2017-09-15 Thread Henrik Johansson
I always check in. It is super nice to not have to download separately and have one transitive dep destroy everything when you need it the least. On Fri, 15 Sep 2017, 02:37 Kevin Malachowski wrote: > I generally vote for checking in, or at least ensuring that /something/

[go-nuts] Do you check in vendor packages?

2017-09-14 Thread Kevin Malachowski
I generally vote for checking in, or at least ensuring that /something/ has an in-house copy of all dependencies. The worst thing that can happen is someone deleting their repository and having your project being super broken. (See also

[go-nuts] Do you check in vendor packages?

2017-09-14 Thread Will Faught
According to https://github.com/golang/dep/blob/master/docs/FAQ.md#should-i-commit-my-vendor-directory, the pros and cons are: Pros: - Only way to get truly reproducible builds - Don't need to `dep ensure` (or whatever your tool is) every time you check out or merge/pull Cons: - PR vendor