On Thursday, November 10, 2022 at 1:59:11 PM UTC-8 David Pacheco wrote:
> Hi Keith,
>
> Thanks for the helpful (and quick) reply! I gather you're right about not
> applying checkptr to Go's own test suite. I applied your patch, tried
> again, and started hitting failures in tests that were
Hi Keith,
Thanks for the helpful (and quick) reply! I gather you're right about not
applying checkptr to Go's own test suite. I applied your patch, tried
again, and started hitting failures in tests that were written for specific
past issues. These seem like false positives.
Do you have
Should be fixed by https://go-review.googlesource.com/c/go/+/448899
On Tuesday, November 8, 2022 at 4:34:00 PM UTC-8 Keith Randall wrote:
> (Although normally lfstack nodes should not be heap allocated in the first
> place?)
>
>
> On Tuesday, November 8, 2022 at 4:32:11 PM UTC-8 Keith Randall
(Although normally lfstack nodes should not be heap allocated in the first
place?)
On Tuesday, November 8, 2022 at 4:32:11 PM UTC-8 Keith Randall wrote:
> I don't think checkptr is intended to be applied blindly inside the
> runtime. The lfstack code is definitely doing things that checkptr
I don't think checkptr is intended to be applied blindly inside the
runtime. The lfstack code is definitely doing things that checkptr was
designed to catch and flag.
Maybe the lfstack routines need a go:nocheckptr annotation?
On Tuesday, November 8, 2022 at 11:21:30 AM UTC-8 David Pacheco
