Re: [go-nuts] Re: goimports has been updated

2016-07-19 Thread David Glasser
My mistake: not only was I not up to date, I was running somebody else's unmerged PR that added vendor support. Looks good now! On Tue, Jul 19, 2016 at 8:34 AM, roger peppe wrote: > On 19 July 2016 at 15:35, David Glasser wrote: > > On Jul 19, 2016

Re: [go-nuts] Re: goimports has been updated

2016-07-19 Thread roger peppe
On 19 July 2016 at 15:35, David Glasser wrote: > On Jul 19, 2016 3:16 AM, "roger peppe" wrote: >> >> On 15 July 2016 at 16:44, wrote: >> > On Thursday, July 14, 2016 at 10:34:36 PM UTC-7, bradfitz wrote: >> >> >> >> goimports

Re: [go-nuts] Re: goimports has been updated

2016-07-19 Thread David Glasser
On Jul 19, 2016 3:16 AM, "roger peppe" wrote: > > On 15 July 2016 at 16:44, wrote: > > On Thursday, July 14, 2016 at 10:34:36 PM UTC-7, bradfitz wrote: > >> > >> goimports has been updated. > >> > >> If you've been frustrated by its speed lately, run: >

Re: [go-nuts] Re: goimports has been updated

2016-07-19 Thread roger peppe
On 15 July 2016 at 16:44, wrote: > On Thursday, July 14, 2016 at 10:34:36 PM UTC-7, bradfitz wrote: >> >> goimports has been updated. >> >> If you've been frustrated by its speed lately, run: >> >>$ go get -u golang.org/x/tools/cmd/goimports >> >> ... and things should be

Re: [go-nuts] Re: goimports has been updated

2016-07-17 Thread Vince Prignano
https://github.com/golang/go/issues/16402 On Saturday, July 16, 2016 at 9:51:16 PM UTC-7, bradfitz wrote: > > Please file a bug. I lose emails. > > > On Sat, Jul 16, 2016 at 1:29 PM, Vince Prignano > wrote: > >> I just noticed that import paths that start with an

[go-nuts] Re: goimports has been updated

2016-07-16 Thread Vince Prignano
I just noticed that import paths that start with an uppercase letter don't get imported automatically after the update. Looking at the code and https://github.com/golang/tools/blob/master/imports/fix.go#L651, I tried to change the behavior, using strings.ToLower on `lastTwoComponents` like:

[go-nuts] Re: goimports has been updated

2016-07-15 Thread dglasser
On Thursday, July 14, 2016 at 10:34:36 PM UTC-7, bradfitz wrote: > > goimports has been updated. > > If you've been frustrated by its speed lately, run: > >$ go get -u golang.org/x/tools/cmd/goimports > > ... and things should be much nicer. > > Details at https://golang.org/cl/24941 > In

[go-nuts] Re: goimports has been updated

2016-07-15 Thread Damian Gryski
Leaving blank lines in the imports section allows grouping: https://github.com/golang/go/wiki/CodeReviewComments#imports Damian -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it,

Re: [go-nuts] Re: goimports has been updated

2016-07-15 Thread Matthew Singletary
Thanks Brad! -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. For more options, visit

[go-nuts] Re: goimports has been updated

2016-07-14 Thread Tyler Compton
As helpful a tool as goimports is, I've really felt it slogging as of late, as well. It's great to hear that this has been given attention! On Thursday, July 14, 2016 at 10:34:36 PM UTC-7, bradfitz wrote: > > goimports has been updated. > > If you've been frustrated by its speed lately, run: > >