Re: [go-nuts] Shrinking pprof data for PGO through quantization.

2023-11-17 Thread 'Adam Azarchs' via golang-nuts
Thanks for the pointers! Looks like just the aggregation alone from your PR there cuts the size of the profile for the thing I was using it on to about a quarter the size, which is nice. Your CL there does in fact truncate the stacks to length 5, just kind of surprisingly does that while

Re: [go-nuts] Shrinking pprof data for PGO through quantization.

2023-11-09 Thread 'Michael Pratt' via golang-nuts
Hi Adam, Thanks for sending this, lots of interesting ideas here! I've been meaning for a long time to have more concrete guidelines for how much data collection is enough for good results, to include on https://go.dev/doc/pgo. I also think it would be valuable to provide tooling that can help

[go-nuts] Shrinking pprof data for PGO through quantization.

2023-11-09 Thread 'Adam Azarchs' via golang-nuts
It's great that we have PGO support in go now, and it's relatively easy to use. One thing that is of mild concern to me is that typically one will be checking the default.pgo file in to the repo, and git is notoriously not great at handling binary blobs that are updated frequently. Its "diff