Re: [go-nuts] TestSetuidEtc fails during test execution in a container

2021-05-18 Thread 'Andrew G. Morgan' via golang-nuts
This should be fully resolved at HEAD now. On Friday, May 14, 2021 at 10:57:22 AM UTC-7 Andrew G. Morgan wrote: > > Indeed. I neglected to heed the comment I left expressly for this purpose. > :( > > Thanks! > > Andrew > > On Friday, May 14, 2021 at 10:25:18 AM UTC-7 ksri...@gmail.com wrote: >

Re: [go-nuts] TestSetuidEtc fails during test execution in a container

2021-05-14 Thread 'Andrew G. Morgan' via golang-nuts
Indeed. I neglected to heed the comment I left expressly for this purpose. :( Thanks! Andrew On Friday, May 14, 2021 at 10:25:18 AM UTC-7 ksri...@gmail.com wrote: > I applied your patch in-flight from your review, > https://go-review.googlesource.com/c/go/+/319591/, > and I am seeing other

Re: [go-nuts] TestSetuidEtc fails during test execution in a container

2021-05-14 Thread Kumar Srinivasan
I applied your patch in-flight from your review, https://go-review.googlesource.com/c/go/+/319591/, and I am seeing other failures. It appears we need to apply the ordering of setgids to the following tests as well. Also, I grepped around for the pattern syscall.Setgroups there are no others I

Re: [go-nuts] TestSetuidEtc fails during test execution in a container

2021-05-13 Thread Kumar Srinivasan
Thanks for looking into this, Andrew. My 2 cents, there ought to be an elegant mechanism of excluding or disabling regression tests temporarily. For example this is how OpenJDK handles specific or generic platform exclusions. https://github.com/openjdk/jdk/blob/master/test/jdk/ProblemList.txt

Re: [go-nuts] TestSetuidEtc fails during test execution in a container

2021-05-12 Thread 'Andrew G. Morgan' via golang-nuts
As a quick hack, you could just delete the src/syscall/syscall_linux_test.go file. Obviously, that will not test a bunch of stuff, but it should unblock you. Alternatively, you could try one of the 'Download' options from: https://go-review.googlesource.com/c/go/+/319591/ while we go

Re: [go-nuts] TestSetuidEtc fails during test execution in a container

2021-05-12 Thread Kumar Srinivasan
Yes I was wondering about that. Meanwhile, is there a way to exclude that test ? Kumar On Wed, May 12, 2021, 7:31 PM 'Andrew G. Morgan' via golang-nuts < golang-nuts@googlegroups.com> wrote: > Mea culpa. I clearly misread the capsh output. > > There is a cap_setgid in there. Looking closer at

Re: [go-nuts] TestSetuidEtc fails during test execution in a container

2021-05-12 Thread 'Andrew G. Morgan' via golang-nuts
Mea culpa. I clearly misread the capsh output. There is a cap_setgid in there. Looking closer at the output the miscompare is there in the first line. The groups are listed in an unsorted order. That is not expected by the test. Let me see what is causing this to happen. I'll use the bug to

Re: [go-nuts] TestSetuidEtc fails during test execution in a container

2021-05-12 Thread 'Andrew G. Morgan' via golang-nuts
OK. I've filed this bug. If we want to go this route, please assign it to me: https://github.com/golang/go/issues/46145 On Wednesday, May 12, 2021 at 2:53:19 PM UTC-7 Ian Lance Taylor wrote: > On Wed, May 12, 2021 at 2:47 PM 'Andrew G. Morgan' via golang-nuts > wrote: > > > > > > It looks

Re: [go-nuts] TestSetuidEtc fails during test execution in a container

2021-05-12 Thread Ian Lance Taylor
On Wed, May 12, 2021 at 2:47 PM 'Andrew G. Morgan' via golang-nuts wrote: > > > It looks like the CapBound here is non-default. That is, this container is > running with non-default restrictions. > > $ /sbin/capsh --decode=0xa80425fb >

Re: [go-nuts] TestSetuidEtc fails during test execution in a container

2021-05-12 Thread 'Andrew G. Morgan' via golang-nuts
It looks like the CapBound here is non-default. That is, this container is running with non-default restrictions. $ /sbin/capsh --decode=0xa80425fb

Re: [go-nuts] TestSetuidEtc fails during test execution in a container

2021-05-12 Thread Kumar Srinivasan
Whoops, I missed mentioning I was trying to build and test this branch + hash: https://go.googlesource.com/go/+/fcee6b930a01407527e3a0386af2ea7ac4e66d44 Thanks Kumar On Wed, May 12, 2021 at 2:33 PM Ian Lance Taylor wrote: > [ + agm ] > > On Wed, May 12, 2021 at 2:12 PM Kumar Srinivasan >

Re: [go-nuts] TestSetuidEtc fails during test execution in a container

2021-05-12 Thread Ian Lance Taylor
[ + agm ] On Wed, May 12, 2021 at 2:12 PM Kumar Srinivasan wrote: > > Hello, > > This is the first time I am posting to this group, apologies if this is the > wrong forum. > > I am trying to build the go sources and test the built sources, so > effectively I am running > % cd go-source-dir/src

[go-nuts] TestSetuidEtc fails during test execution in a container

2021-05-12 Thread Kumar Srinivasan
Hello, This is the first time I am posting to this group, apologies if this is the wrong forum. I am trying to build the go sources and test the built sources, so effectively I am running % cd go-source-dir/src && GOROOT_BOOTSTRAP=/BOOT_GO bash ./all.bash I am seeing this failure attached