Re: [go-nuts] Vendored trace package causes panic because of implicit handlers

2016-07-06 Thread Ian Davis
On Wed, Jul 6, 2016, at 12:34 PM, Jakob Borg wrote: > 2016-07-06 9:11 GMT+02:00 Peter Bourgon : > > You can't actually make this distinction. > > There should be a single vendor/ dir at the root of the repo. > > See https://github.com/zellyn/wtf2 for a demonstration. > > (And

Re: [go-nuts] Vendored trace package causes panic because of implicit handlers

2016-07-06 Thread Peter Bourgon
On Tue, Jul 5, 2016 at 9:19 PM, Sam Whited wrote: > On Tue, Jul 5, 2016 at 1:52 PM, Peter Bourgon wrote: >> Since you removed the vendor/ directory from jitsi/jap, everything is >> working as expected, right? > > Yes, but the vendor dir was in the

Re: [go-nuts] Vendored trace package causes panic because of implicit handlers

2016-07-05 Thread Chad
Seems to me that not leaking API outside of the package it is being used is a must for a vendored package. -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: [go-nuts] Vendored trace package causes panic because of implicit handlers

2016-07-05 Thread Sam Whited
On Tue, Jul 5, 2016 at 1:52 PM, Peter Bourgon wrote: > Since you removed the vendor/ directory from jitsi/jap, everything is > working as expected, right? Yes, but the vendor dir was in the application code, not the library (eg. it was at jap/cmd/jap/vendor, not at

Re: [go-nuts] Vendored trace package causes panic because of implicit handlers

2016-07-05 Thread Peter Bourgon
Since you removed the vendor/ directory from jitsi/jap, everything is working as expected, right? On Tue, Jul 5, 2016 at 8:46 PM, Sam Whited wrote: > On Tue, Jul 5, 2016 at 1:37 PM, Peter Bourgon wrote: >> As of today, if your binary vendors any other

Re: [go-nuts] Vendored trace package causes panic because of implicit handlers

2016-07-05 Thread Sam Whited
On Tue, Jul 5, 2016 at 1:37 PM, Peter Bourgon wrote: > As of today, if your binary vendors any other package, you need to > ensure that package doesn't have a vendor/ directory anywhere in the > source tree. Library maintainers can be good citizens by ensuring > their libraries

Re: [go-nuts] Vendored trace package causes panic because of implicit handlers

2016-07-05 Thread Sam Whited
On Tue, Jul 5, 2016 at 12:15 PM, Keith Rarick wrote: > You don't have to vendor anything from your own repo, but you do have to > vendor everything from outside your repo. (To be precise, the distinction is > between inside and outside the directory containing the vendor directory.)

Re: [go-nuts] Vendored trace package causes panic because of implicit handlers

2016-07-05 Thread Keith Rarick
You don't have to vendor anything from your own repo, but you do have to vendor everything from outside your repo. (To be precise, the distinction is between inside and outside the directory containing the vendor directory.) Aside from that, make sure that the dependency in question is being

Re: [go-nuts] Vendored trace package causes panic because of implicit handlers

2016-07-05 Thread Sam Whited
On Tue, Jul 5, 2016 at 10:17 AM, Konstantin Khomoutov wrote: > AFAIK, vendoring explicitly implements an all-or-nothing approach: > you're supposed to resolve transitive dependencies yourself, and vendor > them all. That's my understanding too, but it seems

Re: [go-nuts] Vendored trace package causes panic because of implicit handlers

2016-07-05 Thread Konstantin Khomoutov
On Tue, 5 Jul 2016 10:05:27 -0500 Sam Whited wrote: > I'm running into a problem with the trace package; I'm trying to build > an application that has a vendored version of it, and one of the > modifications I've made imports a library that also uses the trace > package. > >