Re: [go-nuts] Re: Accessing *[]uint64 from assembly - strange memory corruption under heavy load - any ideas?

2019-03-22 Thread 'Keith Randall' via golang-nuts
Your assembly looks ok to me. At least, the sections you've shown us. It would help if we could see all of it and/or the whole program. You might want to try putting a len>0 test in the pop and a len > On Fri, Mar 22, 2019 at 10:55 AM Robert Johnstone > > wrote: > > > > I don't see any memory

Re: [go-nuts] Re: Accessing *[]uint64 from assembly - strange memory corruption under heavy load - any ideas?

2019-03-22 Thread Ian Lance Taylor
On Fri, Mar 22, 2019 at 10:55 AM Robert Johnstone wrote: > > I don't see any memory barriers in your assembly. If you are modifying the > backing array while it is being scanned by the GC, there could be some > interaction. I don't know enough about the GC internals to say more than > that.

[go-nuts] Re: Accessing *[]uint64 from assembly - strange memory corruption under heavy load - any ideas?

2019-03-22 Thread Robert Johnstone
I don't see any memory barriers in your assembly. If you are modifying the backing array while it is being scanned by the GC, there could be some interaction. I don't know enough about the GC internals to say more than that. If you look at when memory barriers are inserted by the Go