[go-rpm-macros] PR #21: Expose Go build flags directly to spec files as a macro

2020-10-21 Thread Debarshi Ray
rishi commented on the pull-request: `Expose Go build flags directly to spec files as a macro` that you are following: `` The RPM spec file changes slipped through the cracks. I filed: https://src.fedoraproject.org/rpms/go-rpm-macros/pull-request/1 `` To reply, visit the link below or just

[go-rpm-macros] PR #21: Expose Go build flags directly to spec files as a macro

2020-09-01 Thread Debarshi Ray
rishi commented on the pull-request: `Expose Go build flags directly to spec files as a macro` that you are following: `` Yay! We have 3.0.9 now. Thank you. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/21

[go-rpm-macros] PR #21: Expose Go build flags directly to spec files as a macro

2020-08-13 Thread Debarshi Ray
rishi commented on the pull-request: `Expose Go build flags directly to spec files as a macro` that you are following: `` Ping `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/21 ___ golang

[go-rpm-macros] PR #21: Expose Go build flags directly to spec files as a macro

2020-07-07 Thread Debarshi Ray
rishi commented on the pull-request: `Expose Go build flags directly to spec files as a macro` that you are following: `` Could we please have a new `go-rpm-macros` build in Fedora that includes `%gobuildflags` (with the corresponding RPM spec changes discussed here)? We have Go code in

[go-rpm-macros] PR #21: Expose Go build flags directly to spec files as a macro

2019-09-23 Thread Jakub Čajka
jcajka commented on the pull-request: `Expose Go build flags directly to spec files as a macro` that you are following: `` > My only thought for future improvements is to also expose a %gotestflags > macro with the equivalent set of flags for testing. except such a named > macro is already

[go-rpm-macros] PR #21: Expose Go build flags directly to spec files as a macro

2019-09-23 Thread Daniel P . Berrange
berrange commented on the pull-request: `Expose Go build flags directly to spec files as a macro` that you are following: `` My only thought for future improvements is to also expose a %gotestflags macro with the equivalent set of flags for testing. except such a named macro is already in

[go-rpm-macros] PR #21: Expose Go build flags directly to spec files as a macro

2019-09-21 Thread Nicolas Mailhot
nim commented on the pull-request: `Expose Go build flags directly to spec files as a macro` that you are following: `` @berrange That’s awfully nice, both the runtime ifnarch removal and the generalization to pie/nopie macros If you think the PR is cooked and @jcajka agrees with it I see no

[go-rpm-macros] PR #21: Expose Go build flags directly to spec files as a macro

2019-09-19 Thread Jakub Čajka
jcajka commented on the pull-request: `Expose Go build flags directly to spec files as a macro` that you are following: `` Yes, the patch snippet should be something like: ``` diff --git a/go-rpm-macros.spec b/go-rpm-macros.spec index 83e02d7..8de41a6 100644 --- a/go-rpm-macros.spec +++

[go-rpm-macros] PR #21: Expose Go build flags directly to spec files as a macro

2019-09-19 Thread Daniel P . Berrange
berrange commented on the pull-request: `Expose Go build flags directly to spec files as a macro` that you are following: `` BTW, i just realized my suggested spec file change is not quite right. The original code turned off "pie" for "ppc64", not "ppc64le". `` To reply, visit the link below

[go-rpm-macros] PR #21: Expose Go build flags directly to spec files as a macro

2019-09-19 Thread Neal Gompa
ngompa merged a pull-request against the project: `go-rpm-macros` that you are following. Merged pull-request: `` Expose Go build flags directly to spec files as a macro `` https://pagure.io/go-rpm-macros/pull-request/21 ___ golang mailing list --

[go-rpm-macros] PR #21: Expose Go build flags directly to spec files as a macro

2019-09-19 Thread Daniel P . Berrange
berrange opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Expose Go build flags directly to spec files as a macro `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/21