Re: Ping? Could a Guice maintainer comment? (Re: Move internal utility code to separate package?)

2010-06-10 Thread Johannes Schneider
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/03/2010 04:31 PM, je...@swank.ca wrote: Moving these classes is a fine idea, but it will cause pain for any developer who has mistakenly imported Guice's ImmutableSet (etc.) rather than that from Guava. Maybe it is a good idea to remove that

Re: Ping? Could a Guice maintainer comment? (Re: Move internal utility code to separate package?)

2010-06-10 Thread Eric Burke
-1 to new external dependencies. I'd rather Guice be free to innovate rather than tie itself to a particular version of an external library. Not to mention the added headaches when my app already uses one version of an external library but now Guice thinks I should have a different version of the

Re: Ping? Could a Guice maintainer comment? (Re: Move internal utility code to separate package?)

2010-06-10 Thread Bob Lee
On Thu, Jun 10, 2010 at 1:20 PM, Eric Burke burke.e...@gmail.com wrote: Furthermore, Guice works well on Android now. Adding external library dependencies may make this more complicated. Exactly. We used to embed all of Google Collections. We moved away from that because it made the jar size

Re: Ping? Could a Guice maintainer comment? (Re: Move internal utility code to separate package?)

2010-06-10 Thread Dhanji R. Prasanna
We should just obfuscate Immutable* so it doesn't bother IDE importers. Wonder if Jarjar can do that. Dhanji. On Thu, Jun 10, 2010 at 11:37 AM, Johannes Schneider maili...@cedarsoft.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/10/2010 08:20 PM, Eric Burke wrote: -1 to