Looks good. Thanks for handling this.
http://gwt-code-reviews.appspot.com/1447824/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/474803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Lex,
Description:
[GFlow] Supporting break statement outside of loops.
Please review this at http://gwt-code-reviews.appspot.com/553801/show
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java
M
Reviewers: Lex,
Description:
Introducing PrunerTest. It generates 85% of branch coverage for Pruner.
The plan is it cover all global optimizations by test and then refactor
the optimization loop to be more efficient.
I've also renamed OptimizerTestBase = JJSTestBase and created an
http://gwt-code-reviews.appspot.com/474803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/436801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/436801/diff/1/3
File
dev/core/src/com/google/gwt/dev/jjs/impl/gflow/constants/ConstantsAssumption.java
(right):
http://gwt-code-reviews.appspot.com/436801/diff/1/3#newcode157
Reviewers: Lex,
Description:
CFG: fixing case fallthrough.
Please review this at http://gwt-code-reviews.appspot.com/434801/show
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java
M dev/core/test/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilderTest.java
Reviewers: Lex,
Description:
Fixing division by zero while evaluating constant expression.
Please review this at http://gwt-code-reviews.appspot.com/435801/show
Affected files:
M
dev/core/src/com/google/gwt/dev/jjs/impl/gflow/constants/ExpressionEvaluator.java
M
Reviewers: Lex,
Description:
Introducing TOP value for constants analysis and using it
as a starting value for all incoming edges.
Please review this at http://gwt-code-reviews.appspot.com/436801/show
Affected files:
M
LGTM
Can you please document what problem did it cause in the CL description?
I.e. which kind of optimization did it perform before the fix.
http://gwt-code-reviews.appspot.com/405801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Lex,
Description:
CFG: Always jumping to first case statement
Please review this at http://gwt-code-reviews.appspot.com/318802/show
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java
A
All done. Submitting.
http://gwt-code-reviews.appspot.com/318802/diff/1/2
File dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java
(right):
http://gwt-code-reviews.appspot.com/318802/diff/1/2#newcode619
dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java:619:
Reviewers: Lex,
Description:
Inlining local variables when the hold field value obtained from final
context.
Renamings in copy assumptions to make it more readable.
Optimization examples:
---
function $append_24(this$static, xml){
var seq;
if (xml) {
seq =
LGTM
http://gwt-code-reviews.appspot.com/295802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe, reply using remove me as the subject.
ping
http://gwt-code-reviews.appspot.com/278801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe, reply using remove me as the subject.
Reviewers: Lex,
Description:
Fixing gflow nested switch CFG generation
Added couple of tostrings to aid in debugging.
Please review this at http://gwt-code-reviews.appspot.com/180801
Affected files:
dev/core/src/com/google/gwt/dev/jjs/impl/gflow/AnalysisSolver.java
http://gwt-code-reviews.appspot.com/153807/diff/1002/82
File dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java
(right):
http://gwt-code-reviews.appspot.com/153807/diff/1002/82#newcode736
Line 736: } else if (typeOracle.canTriviallyCast(catchType,
exceptionType)) {
According to
Reviewers: Lex,
Message:
Lex,
This adds some debugging facilities and fixes recursion problems in copy
propagation analysis. Please take a look.
Please review this at http://gwt-code-reviews.appspot.com/154811
Affected files:
M
Reviewers: Lex,
Message:
Lex,
these changes make gflow framework to pass all smoke tests. Please take
a look.
Please review this at http://gwt-code-reviews.appspot.com/153807
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/ast/JIfStatement.java
M
Lex,
All done. All tests pass. PTAL.
http://gwt-code-reviews.appspot.com/153807/diff/1/9
File dev/core/src/com/google/gwt/dev/jjs/ast/JReferenceType.java
(right):
http://gwt-code-reviews.appspot.com/153807/diff/1/9#newcode28
Line 28: public static JType dereference(JType type) {
On 2010/02/26
Reviewers: Lex,
Message:
Lex,
Please review.
Description:
SameParameterValueOptimizer should ignore methods called from native
code.
Please review this at http://gwt-code-reviews.appspot.com/141812
Affected files:
M
Reviewers: Lex,
Message:
Requesting review
Description:
Unreachable analysis/optimization.
Determines CFG nodes which are not reachable, and deletes them from
source
tree if possible.
Please review this at http://gwt-code-reviews.appspot.com/130814
Affected files:
A
Reviewers: Lex,
Message:
Requesting review.
Description:
Copy propagation analysis/optimization.
Detects when variable is the copy of another and uses older var instead.
Please review this at http://gwt-code-reviews.appspot.com/132814
Affected files:
A
Reviewers: Lex,
Message:
Requesting review.
Description:
Analysis framework update driven by compile time optimization.
Please review this at http://gwt-code-reviews.appspot.com/132813
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/impl/gflow/Analysis.java
M
Lex,
Next patch will contains 3 optimizations. Promise! :)
http://gwt-code-reviews.appspot.com/117805/diff/2047/1046
File dev/core/src/com/google/gwt/dev/util/Either.java (right):
http://gwt-code-reviews.appspot.com/117805/diff/2047/1046#newcode76
Line 76: return true;
On 2009/12/15 23:00:37,
Merged into http://gwt-code-reviews.appspot.com/126803
http://gwt-code-reviews.appspot.com/117805
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Lex,
Message:
Lex,
This is the second installment. Take a look.
Description:
Control flow graph abstraction builder for CFG optimizations.
Doesn't include actual optimizations.
Please review this at http://gwt-code-reviews.appspot.com/117805
Affected files:
M
Forwarding since I wasn't member of the group.
-- Forwarded message --
From: mike.aizat...@gmail.com
Date: Tue, Dec 1, 2009 at 1:52 PM
Subject: Re: Flow analysis framework definition and solver.
To: sp...@google.com,
google-web-toolkit-contributors@googlegroups.com,
Well, it would be sitting in svn and not being tested in any way
except that it compiles. If you want to commit the pieces somewhere,
why don't we make an svn branch?
I don't think svn branch will help much. It will only add headaches.
What do you say if I would merge all LGTM'ed changes
rather skip optimizations during initial construction in order to
surgically call specific optimizers. Thoughts?
On Tue, Dec 16, 2008 at 9:58 PM, Mike Aizatsky mike.aizat...@gmail.com
wrote:
Scott,
I'm sorry I've disappeared, but I had really busy couple of months. I
have resurrected
Scott,
- Could briefly summarize the motivation for the
suite()/JJSOptimizerTestDecator design?
This way the module will be compiled only once. Unfortunately
JavaToJavaScriptCompiler doesn't have any easily extract compiling
pass and I didn't want to seriously refactor it.
-
.
General concept is fine, of course, but can we make those changes?
On Fri, Oct 3, 2008 at 8:28 PM, Scott Blum [EMAIL PROTECTED] wrote:
Freeland, it's all you. :)
On Fri, Oct 3, 2008 at 8:23 PM, Mike Aizatsky [EMAIL PROTECTED]
wrote:
Hi!
I've fixed build file to support working in non-svn
Scott,
- Could briefly summarize the motivation for the
suite()/JJSOptimizerTestDecator design?
This way the module will be compiled only once. Unfortunately
JavaToJavaScriptCompiler doesn't have any easily extract compiling
pass and I didn't want to seriously refactor it.
I'm not sure
Gotcha. But if you don't compile multiple times, how do you prevent
optimizations that occur in one test method from impacting ones that occur
in another test method?
I can't. I do this by limiting the scope optimization should work on
(see MethodInlineTest)...
By the way, I've already got
35 matches
Mail list logo