Re: Dev plugin for firefox 3.7

2010-09-09 Thread Thomas Broyer
On Sep 9, 2:38 am, csillag csillag.kris...@gmail.com wrote: I hope this gets fixed soon, because my GWT apps totally fail with FF4, and I can not even start to debug them until I have a dev plugin ready. In the mean time, can't you compile with -style PRETTY and debug using Firebug? (or the

Re: Expenses Sample project

2010-09-09 Thread superdama
I got the same javax.validation error. The error is thrown out during the gwtc process. Something wrong with the gwt trunk version? -Super On Sep 8, 1:01 pm, Travis Camechis camec...@gmail.com wrote: I just did a fresh maven build it ran successfully.  I did get some errors due to

Re: GWT war file inside a EAR file

2010-09-09 Thread Marcelo Balloni
Hi folks! So, i finally get it working! I reviewed my ear packaging and realized there wasn't a lib folder with dependences jars. All my jars was scattered inside the ear. Sooo i created the lib folder and packaged all my libs, including gwt-servlet.jar, what definitely made the

Client side serialization and deserialization of GWT objects

2010-09-09 Thread bconoly
Hey All, I need to create an EventBus implementation that will serialize and deserialize event data objects solely on the client side to allow for event sharing between mulitple GWT modules on a single page. Does anyone know of an easy way for me to do that or possibly an example or

Re: Client side serialization and deserialization of GWT objects

2010-09-09 Thread Etienne Lacazedieu
RPC serialization is not symetric, so you wil lnot be able to serialize/deserialize objects on the client side using this mechanism. We achieved just what you describe by creating a JSON serializer/deserializer on the client side. I'm sorry that I'm not allowed to shar e this code. :-/, but I

Re: Problem when server is ofline

2010-09-09 Thread Vesin Dusko
I'm ruing appliaction on windows 7. I'm connected to network using cable and everything is fine, but when i unplug cable(and lose connection to net) application doesn't work. If I deploy some other applications that are developed for example using Spring MVC or Wicket... applications are behave

RE: Translating already compiled Java?

2010-09-09 Thread Armishev, Sergey
You can automatically generate POJO classes from the same WSDL. Why are you doing this manually? In my GWT app I used SUN jax rpc for that http://java.sun.com/webservices/jaxrpc/overview.html Let me know if you need more info -Sergey -Original Message- From:

Re: Variable UI

2010-09-09 Thread pete
So you're suggesting, I should have every image ready for every possible resolution? It is just that I have a lot of images, it would be really nice to keep all the values in percentage inside of my app and scale whatever I need accordingly. At least I would consider that more elegant, it's a

Re: UiBinder: ClientBundle with ImageResource ui:style. How?

2010-09-09 Thread Andrew Hughes
Hi Marius, Thanks for your help again. ui:image resource={res.someImage} and x:SomeWidget resource={res.someImage} are very different. I'm still lost on this one, but thanks for chipping in :) On Thu, Sep 9, 2010 at 7:04 AM, marius.andreiana marius.andrei...@gmail.com wrote: On Sep 8,

Re: Variable UI

2010-09-09 Thread pete
Hmm, I guess I was stupid, I should just use a service to dynamically create images of the right size on the server-side and flush them to the client, then I have variable resizing and can use 100% size in the browser, right? (sorry, I'm not too experienced in programming web- apps) -- You

Wave in a Box

2010-09-09 Thread Stefan Bachert
Google will make a subset of Google Wave as Wave in a Box open source. Does anyone have seen any source code yet? Analyzing the current Wave code looks like Wave consists of a total own but not GWT core widget set. Does some one know more? Stefan Bachert http://gwtworld.de -- You received

LightweightMetrics - network transport measurement?

2010-09-09 Thread dhartford
Hey all, I'm looking at what the LightweightMetrics can supply (opposed to hand- rolling your own), but it is not clear to me if it handles metrics on both the client and the server side to capture network latency issues (or, to be more general, network transport time) inbetween the client and the

Re: Any news on when super dev mode will be released?

2010-09-09 Thread Paul Stockley
Thanks, If I have time to build trunk I will give it a go. Will the profiling option be in the next milestone release of 2.1? On Sep 8, 6:21 pm, Chris Conroy con...@google.com wrote: P.S. that flag needs to get passed in the JVM arguments. Also note you'll need to enable local file access for

Re: Any news on when super dev mode will be released?

2010-09-09 Thread Chris Conroy
Yes, the profiling will be in the next release. On Thu, Sep 9, 2010 at 12:06 PM, Paul Stockley pstockl...@gmail.com wrote: Thanks, If I have time to build trunk I will give it a go. Will the profiling option be in the next milestone release of 2.1? On Sep 8, 6:21 pm, Chris Conroy

Re: Any news on when super dev mode will be released?

2010-09-09 Thread Thomas Broyer
On Sep 9, 6:06 pm, Paul Stockley pstockl...@gmail.com wrote: Thanks, If I have time to build trunk I will give it a go. Will the profiling option be in the next milestone release of 2.1? It's already working in 2.1M3, but it'll give you more info in the next milestone -- You received this

Re: Wave in a Box

2010-09-09 Thread Thomas Broyer
On Sep 9, 5:19 pm, Stefan Bachert stefanbach...@yahoo.de wrote: Google will make a subset of Google Wave as Wave in a Box open source. Does anyone have seen any source code yet? Analyzing the current Wave code looks like Wave consists of a total own but not GWT core widget set. Does some

UIBinder and event model

2010-09-09 Thread tiggr
Hello, When using UIBinder to tie a piece of html to your widget or panel, the elements you get will not be connected to the event model right? So how could I achieve this? If i have a uibinder file looking something like this: ui:UiBinder xmlns:ui='urn:ui:com.google.gwt.uibinder'

Re: gwt and nokia phones

2010-09-09 Thread Arthur Kalmenson
I think the reason this is happening is that Nokia's browser is not supported in GWT. What's probably happening is the initial selector script which picks the appropriate md5sum.cache.js/html based on the user agent of the browser doesn't understand Nokia's user agent and therefore doesn't know

Re: IE 7 bug? LayoutPanels cease resizing after first time displayed

2010-09-09 Thread Paul Smith
When you navigate between the screens are you removing the prior panel? If so then you're probably encountering a bug that I found: http://code.google.com/p/google-web-toolkit/issues/detail?id=5245 You could workaround it by hiding the previous panel instead of removing it. Or you can call

Re: dumb / dto domain model

2010-09-09 Thread Jeroen Wolff
Our model got all the rules for showing elements or not. So a ui element is observing these changes in the model. This is done so we can always validate our model (also on sever) to see if all the needed and calculated values are there. How to solve that in MVP? Will the model than put his

New Website with a huge database using GWT

2010-09-09 Thread Rahul Vijay
Hi All, I am planning to start a new website where the consumer and the producer interact directly over the website. I am planning to use GWT for implementing this website. I will be making use of a significantly large MySQL database. Is GWT good enough for such kind of a website? And also

how can make the GWT richtextarea auto scroll

2010-09-09 Thread 重点帅哥 国家级
i use the GWT richtextarea and i want it to auto scroll to the end every time i add some text or pic ,how can i make it? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to

Get regular update for long running servlet call.

2010-09-09 Thread Jatin Bhadra
Hello, We have a SmartGWT application, Few Servlet calls in the application can take around couple of minutes or some times even longer to complete. We need to show the client the progress that is geing made, this is not a progress tool bar but Information logging for e.g. Connection extablished

How to use non standard CSS selectors in a CSSResource

2010-09-09 Thread matder
Hello, I am trying to use styles for the scrollbars in webkit. The CSS selectors are looking like this: ::-webkit-scrollbar-corner ::-webkit-scrollbar-track-piece:disabled and so on. When I use those in a ClientBundle as a CSSResource, the compiler is complaining about those selectors. This

Re: How to use external JS from GWT?

2010-09-09 Thread Zack Grossbart
You are having a timing problem that is common for GWT. Consider how this would work in pure JavaScript. 1. The page loads 2. The external JavaScript files load 3. The page renders 4. Your JavaScript code is called and you make your field alphanumeric. With GWT the order of operations changes.

GWT Newbie:: devmode (same origin policy) with PHP REST backend

2010-09-09 Thread Ketan Shah
Hi All, I am in process of exploring GWT as a potential candidate for my REST based API developed in PHP (served via nginx and php-fpm). The devmode startsup gwt server at port while I have my backend at port 8080. I am trying to use RequestBuilder but I dont want to use *jsonp* since I

No GWT support found for this system.

2010-09-09 Thread danny
OS: MacOS 10.6.4 Eclipse: Eclipse IDE for SOA Developers Version: Helios Release Build id: 20100617-1415 GWT: 2.0.4 I get the following error when attempting to open with windowbuilder editor: No GWT Support found for this system The product can't find support for the OS, OS architecture or

looking for GUI

2010-09-09 Thread deuce4
Really hoping for a GWT GUI interface soon. Any ideas on timeline. Starting a big project, and would like to plan... -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com.

Re: GWT and Spring - More Generation Options

2010-09-09 Thread Christiana Thompson
In case you missed it, the replay of last week's MyEclipse for Spring 8.6: Generate GWT and Flex Apps in Minutes webinar is now available at http://bit.ly/avsZEj Thanks, Christiana On Aug 26, 3:03 pm, Christiana Thompson christiana.thomp...@gmail.com wrote: Formoreinformation on this topic,

Re: GWT Newbie:: devmode (same origin policy) with PHP REST backend

2010-09-09 Thread Brett Thomas
Are you familiar with the -noserver option? Check it out http://code.google.com/webtoolkit/doc/latest/FAQ_DebuggingAndCompiling.html#How_do_I_use_my_own_server_in_hosted_mode_instead_of_GWT%27s On Thu, Sep 9, 2010 at 11:00 AM, Ketan Shah ketan.s...@gmail.com wrote: Hi All, I am in process of

Re: IE 7 bug? LayoutPanels cease resizing after first time displayed

2010-09-09 Thread mjeffw
Indeed, I am doing a container.clear() then container.add(panel). I will try to hide and show instead. Thanks! On Sep 9, 1:53 pm, Paul Smith paulbsm...@gmail.com wrote: When you navigate between the screens are you removing the prior panel? If so then you're probably encountering a bug that I

Re: New Website with a huge database using GWT

2010-09-09 Thread Gal Dolber
I think that anything you can do in javascript, GWT can do it better... the alternative is server-side-only.. but we all like ajax 2010/9/9 Rahul Vijay rahul.vija...@gmail.com Hi All, I am planning to start a new website where the consumer and the producer interact directly over the

Re: How to use external JS from GWT?

2010-09-09 Thread marius.andreiana
Thanks Zack ;) In your example, where and how do you include the jQuery UI datepicker widget? (I tried in UiBinder .ui.xml files, but didn't work for me with script src=.. /) Marius On Sep 9, 2:53 pm, Zack Grossbart zgrossb...@gmail.com wrote: You are having a timing problem that is common for

Re: GWT RPC offline caching

2010-09-09 Thread Alex G.
Thanks for your hints, guys. Here is my solution: -- OfflineRequestCallback: used to get serialized response and handle it appropriately. public class OfflineRequestCallback implements RequestCallback { // This String we can save in localStorage. private static String

How to use an obfuscated css selector in a css file in a depending project

2010-09-09 Thread Steve Armstrong
I've asked this on Stack Overflow, but noone seems to know: http://stackoverflow.com/questions/3612146/use-obfusticated-css-name-from-clientbundle-in-down-stream-css I've got a library with some CSS, and a depending project that expands on the CSS. I'm trying to move both of them to ClientBundle.

GWT Development Mode UI - Not Updating Startup URL

2010-09-09 Thread sdoca
Hi, I have created two GWT projects in Eclipse using the GWT Eclipse and m2eclipse plugins. For each I have a run configuration set up that does mvn clean compile gwt:run which starts up the GWT Development Mode UI. The Startup URL in the UI for both applications is the same, which happens to

Re: How to use external JS from GWT?

2010-09-09 Thread Zack Grossbart
In your example, where and how do you include the jQuery UI datepicker widget? I defined them in the HTML file containing my GWT code. Just a simple JavaScript reference the same way I would in any other HTML page. -- You received this message because you are subscribed to the Google Groups

JSNI Reserved Word ?

2010-09-09 Thread nino ekambi
Hello People, i trying to call the export Method from a library through JSNI like follow public final native String export(String type) -{ return this.export(type); }-;*/ but i m getting an error missing name after . operator. is the export word reserved in JSNI ? Greets E -- You

Re: Variable UI

2010-09-09 Thread lineman78
I think you are making thins too complicated. What are you doing with so many images? Browsers can do client-side scaling of images for you if you use the img tag (background image scaling is coming in CSS3). It seems like you are a thick client developer and don't have much experience with web

Re: Translating already compiled Java?

2010-09-09 Thread lineman78
I have been battling this issue for a while and the solution really depends on your architecture. The question is are they truly POJOs or do they have JAXB annotations? If they have JAXB annotations GWT will blow up, if not you can trick the GWT compiler into letting you use an external library,

Re: How to get HTTP Response headers?

2010-09-09 Thread ussuri
Does the silence mean this is impossible? Or just very difficult? MG On Sep 8, 8:45 pm, ussuri michael.glas...@gmail.com wrote: Hello! I can't figure out how I can get HTTP Response header. In com.google.gwt.http.client.RequestCallback.onResponseReceived() method (a callback from

Re: Adding Event Handlers on the body element...

2010-09-09 Thread Carlos Aguayo
You can try something like this: Event.addNativePreviewHandler(new NativePreviewHandler() { @Override public void onPreviewNativeEvent(NativePreviewEvent event) { int KEY_F8 = 119; if (keyup.equals(event.getNativeEvent().getType())

Re: Variable UI

2010-09-09 Thread pete
This one app is a card game, with approx. some hundred cards when fully designed. So each card has a small image shown in the UI (dragable, if possible 2 rows a 5 small cards independent of the resolution) and on click shows a popup with the full image including card description. Furthermore 5

Re: How to get HTTP Response headers?

2010-09-09 Thread lineman78
Works fine for me: @Override public void onResponseReceived(Request request, Response response) { String toPop = ; for (Header header:response.getHeaders()) toPop += header.getName() + : + header.getValue() +

Re: Adding Event Handlers on the body element...

2010-09-09 Thread lineman78
Similarly you should probably also check the type. and you could emulate the normal handler style of the rest of the GWT architecture. Event.addNativePreviewHandler(new NativePreviewHandler() { @Override public void onPreviewNativeEvent(NativePreviewEvent

Re: Variable UI

2010-09-09 Thread lineman78
What you are describing is very similar to worldofsolitaire.com. I suggest that you play around with it for a bit and use firebug to inspect how he does things in html. I believe he is using just one image for each card and letting the browser scale it. This way you only need one image for each

Re: New Website with a huge database using GWT

2010-09-09 Thread Rahul Vijay
Hi gal, Thanks for that. Does anyone know some nice hosting service providers who would provide tomcat hosting? ~ Rahul On Fri, Sep 10, 2010 at 1:16 AM, Gal Dolber gal.dol...@gmail.com wrote: I think that anything you can do in javascript, GWT can do it better... the alternative is

The Compiler is Compiling Only One Permutation

2010-09-09 Thread Daniel Simons
I am trying to compile all 5 permutation for my GWT App. For some reason it is only compiling 1. I've tried with the following line in my .gwt.xml and without the line. set-property name=user.agent value=''ie6,gecko,gecko1_8,safari,opera / I'm using Eclipse Galileo with Eclipse Plugin 3.5

[gwt-contrib] [conference]

2010-09-09 Thread nicolas de loof
For info, I'll speak at JugSummerCamp http://www.jugsummercamp.org/ conference tomorrow on GWT 2. Long live GWT :D Nicolas -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] [conference]

2010-09-09 Thread Joel Webber
Allez Nicolas! Le 9 septembre 2010 09:18, nicolas de loof nicolas.del...@gmail.com a écrit : For info, I'll speak at JugSummerCamp http://www.jugsummercamp.org/ conference tomorrow on GWT 2. Long live GWT :D Nicolas -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --

Re: [gwt-contrib] incubator and compatability with gwt 2.1

2010-09-09 Thread Isaac Truett
There isn't one. Incubator is dead. On Thu, Sep 9, 2010 at 7:10 AM, Cameron Braid came...@braid.com.au wrote: What is the plan to bring incubator into compatability with gwt 2.1 ? Cheers Cameron -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --

[gwt-contrib] [google-web-toolkit] r8737 committed - Fix bug 2822942 Remove calls to System.currentTimeMillis in tests...

2010-09-09 Thread codesite-noreply
Revision: 8737 Author: zh...@google.com Date: Thu Sep 9 05:17:25 2010 Log: Fix bug 2822942 Remove calls to System.currentTimeMillis in tests Review at http://gwt-code-reviews.appspot.com/849801 http://code.google.com/p/google-web-toolkit/source/detail?r=8737 Modified:

[gwt-contrib] Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-09 Thread rjrjr
Reviewers: bobv, jlabanca, Description: Adds dual key (type + source) handler binding to EventBus. RequestFactory sets the class of a proxy type as the source for EntityProxyChange events, so that subscribers can still listen for events only of specific proxy types. It is no longer necessary

[gwt-contrib] Re: Uibinder parser api

2010-09-09 Thread Thomas Broyer
On Sep 9, 1:45 pm, Konstantin.Scheglov konstantin.scheg...@gmail.com wrote: If anyone wants to submit a patch to make it possible to subclass UiBinderGenerator and tweak its parsers that way, s.t. you can provide an alternative replace-with rule for your custom subclass, I'd be in favor of

Re: [gwt-contrib] Re: Uibinder parser api

2010-09-09 Thread Ray Ryan
It's not about the lack of a plugin mechanism, it's about discomfort with an api that requires people to emit lines of java too much, and lack of time to clean it up. On Thu, Sep 9, 2010 at 9:22 AM, Thomas Broyer t.bro...@gmail.com wrote: On Sep 9, 1:45 pm, Konstantin.Scheglov

[gwt-contrib] Adds a cheesey uncaught exception handler to DynaTableRF. (issue832802)

2010-09-09 Thread rjrjr
Reviewers: bobv, Description: Adds a cheesey uncaught exception handler to DynaTableRF. Please review this at http://gwt-code-reviews.appspot.com/832802/show Affected files: M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DynaTableRf.java Index:

[gwt-contrib] Re: Adds a cheesey uncaught exception handler to DynaTableRF. (issue832802)

2010-09-09 Thread bobv
LGTM http://gwt-code-reviews.appspot.com/832802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Converts two new files from dos EOL format to unix EOL format. (issue854801)

2010-09-09 Thread kprobst
Reviewers: kjin, Description: Converts two new files from dos EOL format to unix EOL format. Review by: k...@google.com Please review this at http://gwt-code-reviews.appspot.com/854801/show Affected files: M user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorGenerator.java M

[gwt-contrib] Re: Converts two new files from dos EOL format to unix EOL format. (issue854801)

2010-09-09 Thread kjin
LGTM http://gwt-code-reviews.appspot.com/854801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-09 Thread bobv
http://gwt-code-reviews.appspot.com/841804/diff/1/4 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/SummaryWidget.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/4#newcode185

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-09 Thread bobv
Comments for SimpleEventBus. http://gwt-code-reviews.appspot.com/841804/diff/1/24 File user/src/com/google/gwt/event/shared/SimpleEventBus.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/24#newcode36 user/src/com/google/gwt/event/shared/SimpleEventBus.java:36: // Add and remove

[gwt-contrib] Enum name obfuscation option. Addresses issue 2387369 (issue827802)

2010-09-09 Thread jbrosenberg
Reviewers: scottb, cromwellian, robertvawter, Description: Enum name obfuscation option. Addresses issue 2387369 Public: Enum name obfuscation. Added configuration property (compiler.enum.obfuscate.names) to optionally obfuscatate enum names from production output. Please review this at

[gwt-contrib] Re: Add ListEditor adapter implemented on top of a new CompositeEditor core (issue848801)

2010-09-09 Thread rjrjr
I think LGTM, but could you help me understand CompositeEditor and CompositeEditor.Chain first? http://gwt-code-reviews.appspot.com/848801/diff/1/2 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/AddressEditor.java (right):

[gwt-contrib] Re: Add SafeHtml support to UI widgets (2) (issue847801)

2010-09-09 Thread pdr
http://gwt-code-reviews.appspot.com/847801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Update HistoryTest to ensure that non-safari browsers also: (issue855801)

2010-09-09 Thread fredsa
Reviewers: scottb, Description: Update HistoryTest to ensure that non-safari browsers also: - run testHistory - verify the current hash value as part of testTokenEscaping and testTokenNonescaping Please review this at http://gwt-code-reviews.appspot.com/855801/show Affected files: M

[gwt-contrib] Delay start of history token transitions in HistoryTest.testHistory() so that when tokens are lo... (issue850802)

2010-09-09 Thread fredsa
Reviewers: kathrin, Description: Delay start of history token transitions in HistoryTest.testHistory() so that when tokens are lost during subsequent parts of the test, History.back() does not go back too far (i.e. before the web page containing the test module), which would cause subsequent

[gwt-contrib] Re: Delay start of history token transitions in HistoryTest.testHistory() so that when tokens are lo... (issue850802)

2010-09-09 Thread kprobst
LGTM http://gwt-code-reviews.appspot.com/850802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update HistoryTest to ensure that non-safari browsers also: (issue855801)

2010-09-09 Thread scottb
LGTM http://gwt-code-reviews.appspot.com/855801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add ListEditor adapter implemented on top of a new CompositeEditor core (issue848801)

2010-09-09 Thread bobv
http://gwt-code-reviews.appspot.com/848801/diff/1/5 File user/src/com/google/gwt/editor/client/CompositeEditor.java (right): http://gwt-code-reviews.appspot.com/848801/diff/1/5#newcode20 user/src/com/google/gwt/editor/client/CompositeEditor.java:20: * some other type. * An interface that

[gwt-contrib] Move the packages to include in the javadoc out of the build.xml file and into a properties file. (issue856801)

2010-09-09 Thread bobv
Reviewers: fabbott, Description: Move the packages to include in the javadoc out of the build.xml file and into a properties file. Patch by: bobv Review by: fabbott Please review this at http://gwt-code-reviews.appspot.com/856801/show Affected files: M doc/build.xml A

[gwt-contrib] Re: Adds a -strict option to the GWT compiler. If this option is specified, (issue853801)

2010-09-09 Thread Scott Blum
High-level comments: - CompilationState doesn't really need the extra API, because you can always just iterate through the returned collection looking for errors. Arguably, this would take a few extra cycles, but I've kinda been wanting to move the error reporting out CompilationState anyway

[gwt-contrib] Re: Enum name obfuscation option. Addresses issue 2387369 (issue827802)

2010-09-09 Thread Scott Blum
LGTM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enum name obfuscation option. Addresses issue 2387369 (issue827802)

2010-09-09 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/827802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: TypeSerializerCreator generates pure Java code path for DevMode. (issue831801)

2010-09-09 Thread scottb
Fix for inaccessible types, and also fix a generics issue. http://gwt-code-reviews.appspot.com/831801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8739 committed - Allow Checkbox to accept null as valid....

2010-09-09 Thread codesite-noreply
Revision: 8739 Author: cromwell...@google.com Date: Thu Sep 9 10:59:13 2010 Log: Allow Checkbox to accept null as valid. Review at http://gwt-code-reviews.appspot.com/831803 Review by: rj...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8739 Modified:

[gwt-contrib] Re: Enum name obfuscation option. Addresses issue 2387369 (issue827802)

2010-09-09 Thread bobv
Foodback from IM discussion. http://gwt-code-reviews.appspot.com/827802/diff/4001/5007 File user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java (right): http://gwt-code-reviews.appspot.com/827802/diff/4001/5007#newcode76

[gwt-contrib] JsArray enhancement

2010-09-09 Thread Sebastian
I wanted to provide a patch for JsArray* to support common methods like sort and reverse. I found the issue http://code.google.com/p/google-web-toolkit/issues/detail?id=2793 which is not completed and wants to provide all ECMA methods. I had a look at the existing patch and found code that I

[gwt-contrib] Re: Fix memory leaks in DevMode (issue766803)

2010-09-09 Thread conroy
For posterity, this issue was superceded by http://gwt-code-reviews.appspot.com/826802/show On 2010/08/23 20:29:44, conroy wrote: Discussed in person with jat and scottb: Tests are failing for this change because the ThreadLocal assumptions don't actually hold under JUnit. As a result, I'm

[gwt-contrib] Improve locale handling for default scripts and languages where some (issue851802)

2010-09-09 Thread jat
Reviewers: pdr, Description: Improve locale handling for default scripts and languages where some scripts are written RTL even if the language isn't RTL in general. Patch by: jat Review by: pdr Please review this at http://gwt-code-reviews.appspot.com/851802/show Affected files: A

[gwt-contrib] Re: Add ListEditor adapter implemented on top of a new CompositeEditor core (issue848801)

2010-09-09 Thread Ray Ryan
LGTM On Thu, Sep 9, 2010 at 12:04 PM, b...@google.com wrote: http://gwt-code-reviews.appspot.com/848801/diff/1/5 File user/src/com/google/gwt/editor/client/CompositeEditor.java (right): http://gwt-code-reviews.appspot.com/848801/diff/1/5#newcode20

[gwt-contrib] [google-web-toolkit] r8741 committed - Adds a cheesey uncaught exception handler to DynaTableRF....

2010-09-09 Thread codesite-noreply
Revision: 8741 Author: rj...@google.com Date: Thu Sep 9 13:25:50 2010 Log: Adds a cheesey uncaught exception handler to DynaTableRF. Review at http://gwt-code-reviews.appspot.com/832802 Review by: robertvaw...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8741

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-09 Thread rjrjr
I believe I've addressed what should be addressed. What say you? http://gwt-code-reviews.appspot.com/841804/diff/1/4 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/SummaryWidget.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/4#newcode185

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-09 Thread bobv
LGTM http://gwt-code-reviews.appspot.com/841804/diff/1/19 File user/src/com/google/gwt/event/shared/AbstractEventBus.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/19#newcode8 user/src/com/google/gwt/event/shared/AbstractEventBus.java:8: public abstract class AbstractEventBus

[gwt-contrib] Re: Move the packages to include in the javadoc out of the build.xml file and into a properties file. (issue856801)

2010-09-09 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/856801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update HistoryTest to ensure that non-safari browsers also: (issue855801)

2010-09-09 Thread fredsa
http://gwt-code-reviews.appspot.com/855801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Renamed getStableId() to stableId() (issue857801)

2010-09-09 Thread amitmanjhi
Reviewers: rjrjr, Description: Renamed getStableId() to stableId() Patch by: amitmanjhi Review (and suggested) by: rjrjr Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/857801/show Affected files: M

[gwt-contrib] Re: Update HistoryTest to ensure that non-safari browsers also: (issue855801)

2010-09-09 Thread scottb
Still LGTM. May want to file a bug against HtmlUnit. http://gwt-code-reviews.appspot.com/855801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Renamed getStableId() to stableId() (issue857801)

2010-09-09 Thread rjrjr
LGTM On 2010/09/10 00:37:20, amitmanjhi wrote: http://gwt-code-reviews.appspot.com/857801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enum name obfuscation option. Addresses issue 2387369 (issue827802)

2010-09-09 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/827802/diff/4001/5007 File user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java (right): http://gwt-code-reviews.appspot.com/827802/diff/4001/5007#newcode76 user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java:76: //

[gwt-contrib] Re: Add SafeHtml support to UI widgets (2) (issue847801)

2010-09-09 Thread xtof
LGTM! http://gwt-code-reviews.appspot.com/847801/diff/8002/13005 File user/src/com/google/gwt/user/client/ui/Anchor.java (right): http://gwt-code-reviews.appspot.com/847801/diff/8002/13005#newcode117 user/src/com/google/gwt/user/client/ui/Anchor.java:117: this(html.asString(), true); This is

[gwt-contrib] [google-web-toolkit] r8743 committed - Removed the incomplete check that slipped in the last commit....

2010-09-09 Thread codesite-noreply
Revision: 8743 Author: amitman...@google.com Date: Thu Sep 9 16:14:51 2010 Log: Removed the incomplete check that slipped in the last commit. Patch by: amitmanjhi Review by: cromwellian (tbr) http://code.google.com/p/google-web-toolkit/source/detail?r=8743 Modified:

[gwt-contrib] [google-web-toolkit] r8744 committed - Delay start of history token transitions in HistoryTest.testHistory() ...

2010-09-09 Thread codesite-noreply
Revision: 8744 Author: fre...@google.com Date: Thu Sep 9 17:05:41 2010 Log: Delay start of history token transitions in HistoryTest.testHistory() so that when tokens are lost during subsequent parts of the test, History.back() does not go back too far (i.e. before the web page containing