The use of getLastModified() caught my eye, and I was wondering if there's a
pseudo file descriptor leak on Solaris as described in this issue I filed
with Findbugs:
[ 2017517 ] Solaris getLastModified() File Descriptor Leak detection
https://sourceforge.net/tracker/?func=detail&atid=614693&aid=2
Author: [EMAIL PROTECTED]
Date: Wed Sep 3 17:41:24 2008
New Revision: 3613
Modified:
changes/jat/ucd/user/src/com/google/gwt/i18n/tools/GenerateCharTables.java
changes/jat/ucd/user/test/com/google/gwt/i18n/client/impl/ucd/CharacterTableTest.java
Log:
Checkpoint work cleaning up UCD
Ping?
On Fri, Aug 29, 2008 at 9:54 PM, Scott Blum <[EMAIL PROTECTED]> wrote:
> Hi Toby and Bob,
> Please see the attached patch to allow emma integration. Here are the key
> parts:
>
> 1) Bridge Emma's RT class. This is necessary to allow classes living in
> the CCL to access the outside world,
Author: [EMAIL PROTECTED]
Date: Wed Sep 3 15:35:57 2008
New Revision: 3612
Modified:
releases/1.5/dev/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java
Log:
Fixes issue #2841; in hosted mode, JSNI refs to static methods could
incorrectly resolve to the same-signature method in a su
Author: [EMAIL PROTECTED]
Date: Wed Sep 3 15:30:28 2008
New Revision: 3611
Added:
releases/1.5/user/test/com/google/gwt/dev/jjs/test/GenericCastTest.java
(contents, props changed)
Modified:
releases/1.5/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
releases/1.
Author: [EMAIL PROTECTED]
Date: Wed Sep 3 15:08:25 2008
New Revision: 3610
Modified:
releases/1.5/user/super/com/google/gwt/emul/java/lang/Integer.java
releases/1.5/user/super/com/google/gwt/emul/java/lang/Long.java
Log:
Fixes a dumb mistake where we were clinit'ing in a loop references
Never mind, I had Alex review this since you are out for the afternoon.
On Wed, Sep 3, 2008 at 1:46 PM, John LaBanca <[EMAIL PROTECTED]> wrote:
> Okay, one more crack at this. The eval method didn't work correctly in
> Safari 2 (when I said I tested all browsers, I meant all but Safari 2). So,
Author: [EMAIL PROTECTED]
Date: Wed Sep 3 14:22:53 2008
New Revision: 3609
Modified:
trunk/dev/core/src/com/google/gwt/dev/util/log/AbstractTreeLogger.java
trunk/dev/core/src/com/google/gwt/dev/util/log/TreeItemLogger.java
trunk/dev/core/src/com/google/gwt/dev/util/log/TreeLoggerWidg
OK, I've created a patch:
http://code.google.com/p/google-web-toolkit/issues/detail?id=1727#c4
Examples:
private static final RegExp RE = RegExp.compile("\\w+", "g");
// or longer but more efficient
private static final RegExp RE_LITERAL = createLiteral();
private static native RegExp createLit
Author: [EMAIL PROTECTED]
Date: Wed Sep 3 13:46:24 2008
New Revision: 3608
Modified:
trunk/user/test/com/google/gwt/dev/jjs/test/ClassCastTest.java
Log:
Checkstyle fixes / sort / format of ClassCastTest.
Modified: trunk/user/test/com/google/gwt/dev/jjs/test/ClassCastTest.java
=
Rajeev noted that my initializer in About.java is an instance initializer,
not (as intended) a static one. Things appear to work anyway because they
pull from about.txt and .html, but programmatic access would be
uninitialized
--~--~-~--~~~---~--~~
http://group
Thanks!
On Wed, Sep 3, 2008 at 12:01 PM, BobV <[EMAIL PROTECTED]> wrote:
> LGTM.
>
> I think that using the timestamp of the ZipEntry is fine.
>
> --
> Bob Vawter
> Google Web Toolkit Team
>
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-C
Hi,
There seems to be an issue introduced in GWT 1.5.2 with static method
calls having the same name but belonging to subclasses invoked from
JSNI. Please see Michal's test case in this issue :
http://code.google.com/p/google-web-toolkit/issues/detail?id=2841
Can you confirm this is a bug?
Than
'Fraid I'm going to have to give this a -1 on account of not compiling. :)
On Wed, Sep 3, 2008 at 12:23 PM, Freeland Abbott <[EMAIL PROTECTED]
> wrote:
> Rajeev noted that my initializer in About.java is an instance initializer,
> not (as intended) a static one. Things appear to work anyway beca
Author: [EMAIL PROTECTED]
Date: Wed Sep 3 11:45:46 2008
New Revision: 3607
Modified:
trunk/user/src/com/google/gwt/user/client/Window.java
trunk/user/src/com/google/gwt/user/client/impl/WindowImpl.java
trunk/user/src/com/google/gwt/user/client/impl/WindowImplIE.java
Log:
One more fi
Speaking of which, I think this does what you want:
InputStream instream = About.class.getResourceAsStream("About.properties");
But you should test it 'cause I didn't. :)
On Wed, Sep 3, 2008 at 2:24 PM, Scott Blum <[EMAIL PROTECTED]> wrote:
> 'Fraid I'm going to have to give this a -1 on account
Okay, one more crack at this. The eval method didn't work correctly in
Safari 2 (when I said I tested all browsers, I meant all but Safari 2). So,
I refactored the code as you suggested such that in all browsers except IE,
we set the window event handlers directly in a JSNI block, which is clean
LGTM.
I think that using the timestamp of the ZipEntry is fine.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Author: [EMAIL PROTECTED]
Date: Wed Sep 3 08:31:54 2008
New Revision: 3606
Modified:
trunk/user/src/com/google/gwt/user/client/Window.java
trunk/user/src/com/google/gwt/user/client/impl/WindowImpl.java
trunk/user/src/com/google/gwt/user/client/impl/WindowImplIE.java
Log:
Fixes a bug
Its the latter. I would need to duplicate all of the init methods in order
to have both a direct function call and a toString version, but its
certainly doable.
On Wed, Sep 3, 2008 at 11:21 AM, Joel Webber <[EMAIL PROTECTED]> wrote:
> The change LTGM; feel free to commit it.
> One question, thou
The change LTGM; feel free to commit it.
One question, though: We don't even need to run this stuff in the context of
the outer frame on non-IE browsers, right? Would it be possible to simply
call the JSNI methods directly everywhere but IE? If it's too much of a PITA
to get both a callable functio
21 matches
Mail list logo
