[gwt-contrib] Code Review: gwt-google-apis Maps issue 156 - exception when closing infowindow

2008-09-04 Thread Eric Ayers
Joel, Would you please review the attached patch that solves a problem related when widgets need to be attached/detached from panels for the Maps InfoWindow. It addresses issue 156 in gwt-google-apis: http://code.google.com/p/gwt-google-apis/issues/detail?id=156 M

[gwt-contrib] Incubator Code Review Request: GWTCanvas and ImageLoader

2008-09-04 Thread Jaime Yap
This patch taken against Incubator trunk r.927 adds some comments to : com.google.gwt.widgetideas.graphics.client.impl.GWTCanvasImplIE6.java for some funky flooring trick that needed some explanation. Also includes a fix for ImageLoader, where in IE the onLoad event would fire before we get done

[gwt-contrib] [google-web-toolkit commit] r3618 - wiki

2008-09-04 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Sep 4 11:47:17 2008 New Revision: 3618 Modified: wiki/TableOfContents.wiki Log: Edited wiki page through web user interface. Modified: wiki/TableOfContents.wiki == ---

[gwt-contrib] Re: [google-web-toolkit commit] r3618 - wiki

2008-09-04 Thread Alex Rudnick
Previously, if you put google-web-toolkit in docreader, it gave you an old Under Construction page as the only option in the TableOfContents. This way, people will be able to get to the documentation. 2008/9/4 [EMAIL PROTECTED]: Author: [EMAIL PROTECTED] Date: Thu Sep 4 11:47:17 2008 New

[gwt-contrib] Re: Incubator Code Review Request: GWTCanvas and ImageLoader

2008-09-04 Thread Alex Rudnick
Emily seems to have just committed this at r930, but LGTM too. On Thu, Sep 4, 2008 at 2:45 PM, Jaime Yap [EMAIL PROTECTED] wrote: This patch taken against Incubator trunk r.927 adds some comments to : com.google.gwt.widgetideas.graphics.client.impl.GWTCanvasImplIE6.java for some funky

[gwt-contrib] Re: Code review: emma integration

2008-09-04 Thread BobV
Why build support for Emma specifically? It seems like loading the class bytes from the classpath if they're at least as new as the source is a reasonable thing to do in the general case. Also, I think that EmmaStrategy could be extracted into a general escape mechanism for accessing external

[gwt-contrib] Re: Code review: emma integration

2008-09-04 Thread Scott Blum
On Thu, Sep 4, 2008 at 4:52 PM, BobV [EMAIL PROTECTED] wrote: Why build support for Emma specifically? It seems like loading the class bytes from the classpath if they're at least as new as the source is a reasonable thing to do in the general case. It's slower. We've already got the bytes

[gwt-contrib] [google-web-toolkit commit] r3622 - in trunk/dev/core/src/com/google/gwt/dev: shell util

2008-09-04 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Sep 4 15:38:41 2008 New Revision: 3622 Added: trunk/dev/core/src/com/google/gwt/dev/shell/EmmaStrategy.java (contents, props changed) Modified: trunk/dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java