Thanks! Can you add an issue report about this problem? As that will help us
track it.
http://code.google.com/p/google-web-toolkit-incubator/issues/entry
On Thu, Sep 18, 2008 at 7:36 AM, rockster [EMAIL PROTECTED] wrote:
Hi,
in hosted mode I see the DateBox working as expected. In Chrome I
Should InfoWindow be included in this patch?
Shouldn't the Overlay.createPeer method perform the tests on the
JavaScriptObject and return the correct concrete wrapper class?
On Tue, Sep 16, 2008 at 2:19 PM, Eric Ayers [EMAIL PROTECTED] wrote:
Hello Miguel,
I would like you to review the
I meant to reply to this yesterday and comment about this. This falls into
a similar category as the assertions on event properties that we removed,
BUT I do not know of a single case where a hyphen is okay, so its a little
different. If anyone does know of such a case, we should probably not
I think this is a very valuable assertion, which has the potential to save
many new comers (and even veterans) a lot of grief. If somehow a couple of
valid hyphen use cases came up, I'd probably try to special case them and
keep the assertion if at all possible.
Fred Sauer
[EMAIL PROTECTED]
On
Hi Miguel,
These are all good suggestions, especially the one about including all of
the source code. I've updated the patch.
On Thu, Sep 18, 2008 at 9:48 AM, Miguel Méndez [EMAIL PROTECTED] wrote:
Should InfoWindow be included in this patch?
Shouldn't the Overlay.createPeer method perform
Thanks for the review. Committed as r800 to the 1.0 release branch.
On Thu, Sep 18, 2008 at 10:07 AM, Miguel Méndez [EMAIL PROTECTED] wrote:
LGTM
On Wed, Sep 17, 2008 at 3:22 PM, Eric Ayers [EMAIL PROTECTED] wrote:
Hello Miguel,
This patch adds an overload to
Alex -
Issue 32! Why haven't we addressed this simple fix yet?
Description:
We need a FormPanel.reset() method to programatically reset a form.
Fix:
===
Added it. All browsers support form.reset() natively, so this is a trivial
addition.
Testing:
==
Manually tested on all main
Hello Miguel,
Attached is a modified version of the patch was originally put forth by
Jesse Crossley to address issue 128 133.
http://code.google.com/p/gwt-google-apis/issues/detail?id=128
http://code.google.com/p/gwt-google-apis/issues/detail?id=133
I've modified it to use the Handler pattern
The problem is, we can't assert that the element isn't visible because that
isn't an efficient or reliable thing to check, and we don't really want to
throw an exception at runtime in FF if somebody is developing in IE and may
not test FF thoroughly. So, I think its better to fail cleanly. If
A
maps/maps/src/com/google/gwt/maps/client/event/EarthInstanceHandler.java
LG
M maps/maps/src/com/google/gwt/maps/client/impl/MapImpl.java
LG
M maps/maps/src/com/google/gwt/maps/client/MapWidget.java
1408 - Javadoc?
M
This is not a complete review, but some initial feedback:
- Shouldn't the selenium changes be part of a separate patch?
Regardless, Freeland or Eric would be better to review that portion.
- Did you read the
I'm not entirely sure I understand why you can't use the slightly more
efficient check in getSelectedText(), but as that is only a speed
optimization , LGTM.
On Thu, Sep 18, 2008 at 3:40 PM, John LaBanca [EMAIL PROTECTED] wrote:
IE throws an exception if the cursorPos is negative, whereas the
Updated patch attached.
On Thu, Sep 18, 2008 at 3:08 PM, Miguel Méndez [EMAIL PROTECTED] wrote:
A
maps/maps/src/com/google/gwt/maps/client/event/EarthInstanceHandler.java
LG
M maps/maps/src/com/google/gwt/maps/client/impl/MapImpl.java
LG
Removed hideControls() and showControls()
Author: [EMAIL PROTECTED]
Date: Thu Sep 18 13:12:44 2008
New Revision: 3666
Modified:
trunk/user/src/com/google/gwt/user/client/ui/TextBoxBase.java
trunk/user/src/com/google/gwt/user/client/ui/impl/TextBoxImpl.java
LGTM!
On Thu, Sep 18, 2008 at 3:49 PM, Eric Ayers [EMAIL PROTECTED] wrote:
Updated patch attached.
On Thu, Sep 18, 2008 at 3:08 PM, Miguel Méndez [EMAIL PROTECTED] wrote:
A
maps/maps/src/com/google/gwt/maps/client/event/EarthInstanceHandler.java
LG
M
On Thu, Sep 18, 2008 at 3:44 PM, Emily Crutcher [EMAIL PROTECTED] wrote:
Yep, that was already committed to gwt-incubator trunk, the patch is older
then the commit.
Ok, so I should ignore that, right?
- Did you read the
Thanks. committed as r803. That was the last issue marked for RC1!
On Thu, Sep 18, 2008 at 4:17 PM, Miguel Méndez [EMAIL PROTECTED] wrote:
LGTM!
On Thu, Sep 18, 2008 at 3:49 PM, Eric Ayers [EMAIL PROTECTED] wrote:
Updated patch attached.
On Thu, Sep 18, 2008 at 3:08 PM, Miguel Méndez
Sweet!!!
On Thu, Sep 18, 2008 at 4:32 PM, Eric Ayers [EMAIL PROTECTED] wrote:
Thanks. committed as r803. That was the last issue marked for RC1!
On Thu, Sep 18, 2008 at 4:17 PM, Miguel Méndez [EMAIL PROTECTED] wrote:
LGTM!
On Thu, Sep 18, 2008 at 3:49 PM, Eric Ayers [EMAIL PROTECTED]
Thanks!
On Thu, Sep 18, 2008 at 4:13 PM, John LaBanca [EMAIL PROTECTED] wrote:
committed as r3666
I see what you are saying about the more efficient version, so I changed it
to the following where we don't get the length unless we need to:
public String getSelectedText() {
int
I think we're all in agreement, then. We can back out if absolutely
necessary, but this will definitely clear up a lot of confusion. LGTM++.
On Thu, Sep 18, 2008 at 10:10 AM, Fred Sauer [EMAIL PROTECTED] wrote:
I think this is a very valuable assertion, which has the potential to save
many new
committed as r3667
Thanks,
John LaBanca
[EMAIL PROTECTED]
On Thu, Sep 18, 2008 at 6:19 PM, Joel Webber [EMAIL PROTECTED] wrote:
I think we're all in agreement, then. We can back out if absolutely
necessary, but this will definitely clear up a lot of confusion. LGTM++.
On Thu, Sep 18, 2008
Author: [EMAIL PROTECTED]
Date: Thu Sep 18 17:16:14 2008
New Revision: 3667
Modified:
trunk/user/src/com/google/gwt/dom/client/Style.java
trunk/user/test/com/google/gwt/dom/client/ElementTest.java
Log:
Added an assertion that style attribute names do not contain a hyphen.
Users
Contributors -
I propose adding the following method to TabBar:
public void setTabEnabled(int index, boolean enabled)
When disabled, a tab will be assigned the additional style
gwt-TabBarItem-disabled, and the user will not be able to select the tab
using the mouse or keyboard. The style
23 matches
Mail list logo
