[gwt-contrib] Re: code review requested for 1.5 branch, FF3 getAbsoluteTop/Left

2008-10-13 Thread John Tamplin
On Mon, Oct 13, 2008 at 11:18 AM, Joel Webber [EMAIL PROTECTED] wrote: This is a pretty tricky expression -- my understanding of how it works is that (maybe_float_value | 0) coerces to an integer because the | operator requires its operands to be integral. This seems like a perfectly good

[gwt-contrib] Re: code review requested for 1.5 branch, FF3 getAbsoluteTop/Left

2008-10-13 Thread Joel Webber
This is a pretty tricky expression -- my understanding of how it works is that (maybe_float_value | 0) coerces to an integer because the | operator requires its operands to be integral. This seems like a perfectly good approach, but I would add a comment explaining how it works (because I've seen

[gwt-contrib] Re: code review requested for 1.5 branch, RPC quoting, issues 1137, 1906, and more

2008-10-13 Thread Joel Webber
Running RPCSuite, it looks like everything passes except for UnicodeEscapingTest.testClientToServer[Non]BMP(), which cause the exceptions described below, on the server. I'll keep looking over the patch; feel free to swing by if you want to look over the failure together on the Android emulator.

[gwt-contrib] RR: OOPHM for AIR applications

2008-10-13 Thread Thomas Broyer
Could someone with OOPHM experience review this design doc about adding hosted-mode support for AIR applications, based on OOPHM: http://code.google.com/p/gwt-in-the-air/wiki/DesignOOPHM Adobe AIR knowledge is obviously a plus, but I think isn't required to understand the document. Anyway,

[gwt-contrib] [google-web-toolkit commit] r3741 - in releases/1.6/dev/core/src/com/google/gwt: core/ext/linker core/ext/linker/impl dev/cfg...

2008-10-13 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 13 09:50:46 2008 New Revision: 3741 Removed: releases/1.6/dev/core/src/com/google/gwt/dev/cfg/DefaultPropertyProvider.java Modified: releases/1.6/dev/core/src/com/google/gwt/core/ext/linker/Artifact.java

[gwt-contrib] Re: code review requested for 1.5 branch, RPC quoting, issues 1137, 1906, and more

2008-10-13 Thread Lex Spoon
On Mon, Oct 13, 2008 at 11:40 AM, John Tamplin [EMAIL PROTECTED] wrote: Lex, do you know what we would need to do to get these exceptions seirialized properly to the client? I *think* what needs to happen is that the exception is wrapped in a declared exception. I haven't checked, but the

[gwt-contrib] [google-web-toolkit commit] r3742 - in releases/1.5: dev/core/src/com/google/gwt/dev/jjs/impl user/test/com/google/gwt/dev/jj...

2008-10-13 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 13 12:30:58 2008 New Revision: 3742 Modified: releases/1.5/dev/core/src/com/google/gwt/dev/jjs/impl/MethodInliner.java releases/1.5/user/test/com/google/gwt/dev/jjs/test/CompilerTest.java Log: Uses a more reliable check to prevent methods with

[gwt-contrib] Re: Issue 2950 in google-web-toolkit: Time.valueOf fails with 08 and 09 numbers

2008-10-13 Thread Amit Manjhi
Hi John and Scott, Attached is a patch to fix the issue. The previous code was failing because it was invoking Integer.decode(..) method to do the parsing. Integer.decode(..) first tries to infer the base and then attempts to decode the String in that base. 08 and 09 were decoded as octal and an

[gwt-contrib] Code Review: gwt-google-apis gears Add support for message types other than String()

2008-10-13 Thread Eric Ayers
Hi Miguel, I would like for you to review the attached patch. We discussed them earlier as a part of the WorkerPool demo. It adds support for message types other than string. M gears/test/com/google/gwt/gears/client/workerpool/WorkerPoolTest.java M

[gwt-contrib] Re: RR: OOPHM for AIR applications

2008-10-13 Thread Ray Cromwell
I don't have any OOPHM experience, but IIRC, linkers don't run in hosted mode (or do they now?), so the last part of your design doc may need revising. -Ray On Mon, Oct 13, 2008 at 8:56 AM, Thomas Broyer [EMAIL PROTECTED] wrote: Could someone with OOPHM experience review this design doc

[gwt-contrib] Re: Issue 2950 in google-web-toolkit: Time.valueOf fails with 08 and 09 numbers

2008-10-13 Thread Scott Blum
Could you add this patch to the issue and use a filename like Time_valueOf.patch. On Mon, Oct 13, 2008 at 3:35 PM, Amit Manjhi [EMAIL PROTECTED] wrote: Hi John and Scott, Attached is a patch to fix the issue. The previous code was failing because it was invoking Integer.decode(..) method to

[gwt-contrib] Re: Issue 2950 in google-web-toolkit: Time.valueOf fails with 08 and 09 numbers

2008-10-13 Thread Amit Manjhi
Done. I also added appropriate tests and have attached the updated patch. The patch has been reviewed by John Tamplin. Since the patch is simple, both he and I think this patch is safe to go in 1_5_3. Thoughts? Regards, Amit Index: user/test/com/google/gwt/emultest/java/sql/SqlTimeTest.java

[gwt-contrib] Re: RR: OOPHM for AIR applications

2008-10-13 Thread Thomas Broyer
On 13 oct, 21:50, Ray Cromwell [EMAIL PROTECTED] wrote: I don't have any OOPHM experience, but IIRC, linkers don't run in hosted mode (or do they now?), They don't. so the last part of your design doc may need revising. Actually, it might rather be my neural compiler producing bad

[gwt-contrib] Re: Issue 2950 in google-web-toolkit: Time.valueOf fails with 08 and 09 numbers

2008-10-13 Thread Scott Blum
On Mon, Oct 13, 2008 at 5:05 PM, Amit Manjhi [EMAIL PROTECTED] wrote: Done. I also added appropriate tests and have attached the updated patch. The patch has been reviewed by John Tamplin. Since the patch is simple, both he and I think this patch is safe to go in 1_5_3. Thoughts? No

[gwt-contrib] Re: RR: OOPHM for AIR applications

2008-10-13 Thread Scott Blum
By the way, we're talking about a redesign where linkers do run in hosted mode. The idea is an initial link over public files + a mocked up CompilationResult with no javascript that encodes the deferred binding props, followed by incremental relinks when generators produce resources. On Mon, Oct

[gwt-contrib] [google-web-toolkit commit] r3745 - in branches/oophm/plugins/xpcom: . prebuilt/extension/platform/Darwin_x86-gcc3 prebuilt/e...

2008-10-13 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 13 17:38:49 2008 New Revision: 3745 Added: branches/oophm/plugins/xpcom/prebuilt/extension/platform/Darwin_x86-gcc3/ branches/oophm/plugins/xpcom/prebuilt/extension/platform/Darwin_x86-gcc3/components/

[gwt-contrib] [google-web-toolkit commit] r3746 - branches/oophm/plugins/xpcom/prebuilt

2008-10-13 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 13 17:44:04 2008 New Revision: 3746 Added: branches/oophm/plugins/xpcom/prebuilt/oophm-xpcom.xpi (contents, props changed) Log: Add prebuilt XPI containing the following XPCOM plugins for Firefox 3: Windows x86 Linux x86 Linux x86_64

[gwt-contrib] [google-web-toolkit commit] r3747 - branches/oophm/plugins/xpcom/prebuilt

2008-10-13 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 13 17:46:40 2008 New Revision: 3747 Modified: branches/oophm/plugins/xpcom/prebuilt/oophm-xpcom.xpi (props changed) Log: Set MIME type so XPI file can be installed. --~--~-~--~~~---~--~~

[gwt-contrib] FF3 winxp on OOPHM rev 3747 branch fails with No GWT plugin found

2008-10-13 Thread gslender
FF3 winxp on OOPHM rev 3747 branch fails with No GWT plugin found hosted.html trys to find plugin but fails with an alert No GWT plugin found The plugin (oophm.xpi) was correctly installed. The IE plugin was also registered and IE seems to work fine. Any workaround or solution? Cheers, Grant

[gwt-contrib] Re: [Code Review] Small Test Framework For JJS Optimizers

2008-10-13 Thread Scott Blum
On Mon, Oct 6, 2008 at 5:57 PM, Scott Blum [EMAIL PROTECTED] wrote: By the way, I've already got a big patch out that Bob is reviewing that is a huge refactor to JavaToJavaScriptCompiler, and we can continue to refactor further to support this use case in the best way possible. I can't

[gwt-contrib] Re: FF3 winxp on OOPHM rev 3747 branch fails with No GWT plugin found

2008-10-13 Thread John Tamplin
On Mon, Oct 13, 2008 at 9:51 PM, gslender [EMAIL PROTECTED] wrote: FF3 winxp on OOPHM rev 3747 branch fails with No GWT plugin found hosted.html trys to find plugin but fails with an alert No GWT plugin found Given the current plugin initialization, hosted.html can't tell a missing plugin