[gwt-contrib] Re: FF3 winxp on OOPHM rev 3747 branch fails with No GWT plugin found

2008-10-14 Thread John Tamplin
On Tue, Oct 14, 2008 at 2:48 AM, gslender [EMAIL PROTECTED] wrote: Re the warning - loading both plugins fixes the warning. I don't get it anymore. Right, since Firefox thinks it has a plugin to match the embed tag, even though hosted.html will never use it because it finds the XPCOM plugin

[gwt-contrib] Code Review: Visualization API, improved hello world example

2008-10-14 Thread Uwe Maurer
Hi, I added a TabPanel to the hello world example, with a tab for each example. I added an example for the new DataView. Thanks, Uwe --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: [gwt-team] Release Notes for review

2008-10-14 Thread John LaBanca
Rajeev / Alex - Can you summarize what the problem with RequestBuilder and RPC? I don't see an issue associated with the fix, and it would be good to use something more descriptive than it was broke. Here is the commit log: For IE7, we should be instantiating an XHR with the native

[gwt-contrib] Re: [gwt-team] Release Notes for review

2008-10-14 Thread John Tamplin
On Tue, Oct 14, 2008 at 10:04 AM, Rajeev Dayal [EMAIL PROTECTED] wrote: Time.valueOf no longer tries to determine radix values... Instead of mentioning the radix problem, say that Time.valueOf correctly parses values with leading zeros Well, it would incorrectly accept 0xc:0xF:0x25 before,

[gwt-contrib] Code Review: Visualization API, added DataView

2008-10-14 Thread Uwe Maurer
Hi, I added the new DataView class that allows read only access to a DataTable for selected columns. Thanks, Uwe --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~--- Index:

[gwt-contrib] code review requested for 1.5, issues 2836, 2894, 2911 - various I18NSync issues

2008-10-14 Thread John Tamplin
Please review this change for 1.5.3 which fixes a number of small issues. The patch is larger than you might expect because it includes parts copied from elsewhere (and then simplified) for choosing what characters to quote and how to quote them, but at this point I felt it was safer to copy them

[gwt-contrib] Re: [gwt-team] Release Notes for review

2008-10-14 Thread Alex Rudnick
We'd gotten a report that for some IEs, when you instantiate the XHR with new ActiveXObject(Microsoft.XMLHTTP), if you try to do a GET with that object, it does a POST. This patch fixed that problem by using a different string (or just the native XMLlHttpRequest object). I was able to reproduce

[gwt-contrib] redirect results

2008-10-14 Thread deanhiller
1st issue I am interested in looking at the code that handles errors coming back from an XmlHttpRequest. After checkout, where would I look for this? Basically, in seam using AJAX, if the response to an XmlHttpRequest is a redirect message, the entire page redirects. I kinda wanted the

[gwt-contrib] [google-web-toolkit commit] r3752 - in releases/1.5/user: src/com/google/gwt/user/client/rpc/impl src/com/google/gwt/user/ser...

2008-10-14 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Oct 14 11:51:17 2008 New Revision: 3752 Modified: releases/1.5/user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java releases/1.5/user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamWriter.java

[gwt-contrib] Re: [gwt-team] Release Notes for review

2008-10-14 Thread Scott Blum
I don't think anything I did merits explicit release notes call out; let's remember to include a query link for all fixed issues. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: code review requested for 1.5 branch, RPC quoting, issues 1137, 1906, and more

2008-10-14 Thread Joel Webber
LGTM. All the tests seem to work properly on the emulator. Would you mind entering an issue to come back and loosen up the escaping regex, once the Android encoding bug gets fixed? On Tue, Oct 14, 2008 at 6:37 AM, John Tamplin [EMAIL PROTECTED] wrote: On Mon, Oct 13, 2008 at 11:27 AM, Joel

[gwt-contrib] Re: code review requested for 1.5 branch, RPC quoting, issues 1137, 1906, and more

2008-10-14 Thread John Tamplin
On Tue, Oct 14, 2008 at 3:22 PM, Joel Webber [EMAIL PROTECTED] wrote: LGTM. All the tests seem to work properly on the emulator. Would you mind entering an issue to come back and loosen up the escaping regex, once the Android encoding bug gets fixed? Committed to releases/1.5 at r3752, issue

[gwt-contrib] Re: code review requested for 1.5, issues 2836, 2894, 2911 - various I18NSync issues

2008-10-14 Thread Alex Rudnick
Alright, taking a look! The code looks good (one typographical nit), but I'm pretty sure you should change the comments in the tests that reference local files on your machine. Also, all the test files should have copyright notices (don't they?), but it looks like you took some of them out. Let

[gwt-contrib] Re: RR: SOYC Correlation work

2008-10-14 Thread Lex Spoon
Kathrin and I reviewed this together. In general, this solves an important use case, so let's move forward on it aside from minor issues. The following use cases are the ones we could think of: - Seeing what amount of output code (and in fact the actual code if you want) corresponds to what

[gwt-contrib] Re: [gwt-team] Release Notes for review

2008-10-14 Thread Rajeev Dayal
HTTPRequests no long POST instead of GET in some IE installs because of incorrect XHR selection should be HTTPRequests no longer POST instead of GET in some IE installs because of incorrect XHR selection On Tue, Oct 14, 2008 at 4:20 PM, John LaBanca [EMAIL PROTECTED] wrote: Alright, please

[gwt-contrib] Re: [gwt-team] Release Notes for review

2008-10-14 Thread John LaBanca
Alright, please take a final look at the changes you all recommended and give a LGTM if the release notes look good. http://www.corp.google.com/~jlabanca/release_notes.htmlhttp://www.corp.google.com/%7Ejlabanca/release_notes.html Thanks, John LaBanca [EMAIL PROTECTED] On Tue, Oct 14, 2008 at

[gwt-contrib] Re: [gwt-team] Release Notes for review

2008-10-14 Thread Scott Blum
Just formatting nitpicks.1) All code needs to use the HTML for code. 2) Any code that refers to a method should be postfixed with parentheses. See the formatting in 1.5.2 notes. Specifically: HTTPRequests - make singular to match class name, use code style getAbsoluteTop/Left -

[gwt-contrib] Re: code review requested for 1.5, issues 2836, 2894, 2911 - various I18NSync issues

2008-10-14 Thread John Tamplin
On Tue, Oct 14, 2008 at 3:41 PM, Alex Rudnick [EMAIL PROTECTED] wrote: The code looks good (one typographical nit), but I'm pretty sure you should change the comments in the tests that reference local files on your machine. Also, all the test files should have copyright notices (don't they?),

[gwt-contrib] Re: FF3 winxp on OOPHM rev 3747 branch fails with No GWT plugin found

2008-10-14 Thread gslender
Comments below... On Oct 14, 6:25 pm, John Tamplin [EMAIL PROTECTED] wrote: Can you reproduce this with the samples? Say, run Hello-shell then refresh the page? For me, it shows the old one disconnected and creates a new connection, as expected. Where do you get the out of bounds

[gwt-contrib] Re: Code Review: gwt-google-apis gears Add support for message types other than String()

2008-10-14 Thread Alex Rudnick
Hey Eric :) I'll take this one. LGTM, save the (formatting) comments below and a question about documentation. gears/test/com/google/gwt/gears/client/workerpool/WorkerPoolTest.java: 388: Should probably take out the commented-out testReceiveMessageObject. Unless you wanted to put this one in?

[gwt-contrib] Re: code review requested for 1.5 branch, RPC quoting, issues 1137, 1906, and more

2008-10-14 Thread John Tamplin
On Mon, Oct 13, 2008 at 11:27 AM, Joel Webber [EMAIL PROTECTED] wrote: Running RPCSuite, it looks like everything passes except for UnicodeEscapingTest.testClientToServer[Non]BMP(), which cause the exceptions described below, on the server. Ok, here is a revised patch, which adds quoting for

[gwt-contrib] Re: FF3 winxp on OOPHM rev 3747 branch fails with No GWT plugin found

2008-10-14 Thread gslender
So is there any way to find out where/what is really causing this array IndexOutOfBoundsException ?? It must be the JS parser within GWT I'm guessing? Cheers, Grant --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Code Review: gwt-google-apis gears Add support for message types other than String()

2008-10-14 Thread Eric Ayers
Thanks for the comments. On Tue, Oct 14, 2008 at 5:43 PM, Alex Rudnick [EMAIL PROTECTED] wrote: Hey Eric :) I'll take this one. LGTM, save the (formatting) comments below and a question about documentation. gears/test/com/google/gwt/gears/client/workerpool/WorkerPoolTest.java: 388: Should

[gwt-contrib] Re: FF3 winxp on OOPHM rev 3747 branch fails with No GWT plugin found

2008-10-14 Thread John Tamplin
On Tue, Oct 14, 2008 at 6:30 PM, gslender [EMAIL PROTECTED] wrote: So is there any way to find out where/what is really causing this array IndexOutOfBoundsException ?? It must be the JS parser within GWT I'm guessing? java.util.ArrayList.get(Unknown Source) at

[gwt-contrib] Patch for TreeMap serialization

2008-10-14 Thread Amit Manjhi
Hi all, I have attached a patch for TreeMap Serialization. The patch has been reviewed by John Tamplin. Most of the code is similar to the way we do serialization/deserialization for HashMap. The deserialization is done element by element and the tree is being built incrementally. John pointed

[gwt-contrib] Re: RR:JS collections

2008-10-14 Thread Damon Lundin
I realize I may be jumping in late to this discussion, but Bruce just introduced me to this fine contributors group. At a talk during the Google I/O conference, I mentioned the benefit of using the GWT FastStringMap implementation over the HashMap implementation and I decided to re-run my

[gwt-contrib] Re: [google-web-toolkit commit] r3757 - releases/1.5/dev/core/src/com/google/gwt/dev/jjs/impl

2008-10-14 Thread Scott Blum
You are teh w00t! --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: RR: SOYC Correlation work

2008-10-14 Thread BobV
Would it be correct to summarize the chief blocking issue as needing to reconsider the equals / compareTo / hashCode functions on SourceInfo and Correlation? -- Bob Vawter Google Web Toolkit Team --~--~-~--~~~---~--~~

[gwt-contrib] coordinate cleanup in r3364 broke RootPanel.add(widget, 0, 0) for 1px BODY borders in IE quirks mode

2008-10-14 Thread Fred Sauer
Joel, I know you're just dying to revisit the coordinate system cleanups from r3364. That opportunity now exists as issue 2981 :) http://code.google.com/p/google-web-toolkit/issues/detail?id=2981 RootPanel.add(widget, 0, 0) with 1px border results in static positioning in IE quirks Fred