[gwt-contrib] Re: Update Gadgets to work with GWTSheel and the 1.6 release

2009-02-13 Thread Eric Ayers
[crossposted to gwt-google-apis google-web-toolkit-contrib] Well, my patch blows up in trunk builds because About.VERSION_NUM is set to 0.0. Attached is a GWT patch that moves the BrowserWidget.EXPECTED_GWT_ONLOAD_VERSION constant to SelectionScriptLinker and performs a substitution. Also

[gwt-contrib] Re: Window resize fix

2009-02-13 Thread jlabanca
LGTM This is a really nice patch. It should make a big difference for some apps. http://gwt-code-reviews.appspot.com/4805/diff/1/3 File user/src/com/google/gwt/user/client/Window.java (left): http://gwt-code-reviews.appspot.com/4805/diff/1/3#oldcode759 Line 759: Did you accidentally remove a

[gwt-contrib] Re: Update Gadgets to work with GWTSheel and the 1.6 release

2009-02-13 Thread Scott Blum
These patches for 1.6 or trunk? It seems like we want to do this in 1.6, right? On Fri, Feb 13, 2009 at 5:45 AM, Eric Ayers zun...@google.com wrote: [crossposted to gwt-google-apis google-web-toolkit-contrib] Well, my patch blows up in trunk builds because About.VERSION_NUM is set to 0.0.

[gwt-contrib] Re: No default constructor on MenuItem for no real reason?

2009-02-13 Thread Joel Webber
No real reason that I can think of. On Tue, Feb 10, 2009 at 5:19 PM, Ray Ryan rj...@google.com wrote: I'm looking at MenuItem and its collection of constructors. As far as I can see, there is no reason it doesn't have a zero args contructor--its as mutable as all get out, right? Am I missing

[gwt-contrib] [google-web-toolkit commit] r4715 - releases/1.6/user/src/com/google/gwt/user/client

2009-02-13 Thread codesite-noreply
Author: e...@google.com Date: Fri Feb 13 07:28:25 2009 New Revision: 4715 Modified: releases/1.6/user/src/com/google/gwt/user/client/Window.java Log: Fixes issue 1938 by preventing window resize events from being fired with duplicate height and width values. Review by:jlabanca Modified:

[gwt-contrib] Re: Update Gadgets to work with GWTSheel and the 1.6 release

2009-02-13 Thread Eric Ayers
One of the is for GWT 1.6, the other is for gwt-google-apis On Fri, Feb 13, 2009 at 10:20 AM, Scott Blum sco...@google.com wrote: These patches for 1.6 or trunk? It seems like we want to do this in 1.6, right? On Fri, Feb 13, 2009 at 5:45 AM, Eric Ayers zun...@google.com wrote:

[gwt-contrib] [google-web-toolkit commit] r4716 - in releases/1.6/reference/code-museum/src/com/google/gwt/museum: . client/common client/d...

2009-02-13 Thread codesite-noreply
Author: e...@google.com Date: Fri Feb 13 07:42:14 2009 New Revision: 4716 Added: releases/1.6/reference/code-museum/src/com/google/gwt/museum/client/common/SimpleLayout.java

[gwt-contrib] Re: JSNI signature shortcuts

2009-02-13 Thread Lex Spoon
+1 to the whole idea. Also, for the reasons already given, I agree that ::method looks better than this::method, which looks better than self::method. I am not sure it's worth the spec weight to have a lot of variants in the syntax. The most important thing is to allow * in place of an entire

[gwt-contrib] Re: Update Gadgets to work with GWTSheel and the 1.6 release

2009-02-13 Thread Scott Blum
GWT part LGTM. On Fri, Feb 13, 2009 at 5:45 AM, Eric Ayers zun...@google.com wrote: [crossposted to gwt-google-apis google-web-toolkit-contrib] Well, my patch blows up in trunk builds because About.VERSION_NUM is set to 0.0. Attached is a GWT patch that moves the

[gwt-contrib] Re: RR: logging script size for programs with code splitting

2009-02-13 Thread Lex Spoon
On Thu, Feb 12, 2009 at 2:04 PM, John Tamplin j...@google.com wrote: It would be good to get the initial download size as well, if we are going to be getting them from the log rather than the output directory. That's a good idea. I'll also add the permutation's strong name to the log message,

[gwt-contrib] Re: RR : Implement web-mode stack traces and symbol map files

2009-02-13 Thread Matt Mastracci
Bob, We've been doing the same thing for a while using a slightly different method. Some notes from our implementation: 1. The callee chain represents functions, rather than activation records as you'd expect. If you call a method re-entrantly, you'll end up in an infinite loop

[gwt-contrib] Re: Announcing GWT 1.6 Milestone 1

2009-02-13 Thread Jeff J.
I'm getting class not found exceptions when trying to launch my project in hosted mode using this build, saying Provider org.apache.xerces.jaxp.SAXParserFactoryImpl not found. I tried to create a fresh new project using webAppCreator and I get NoClassDefFoundError looking for

[gwt-contrib] Re: RR : Implement web-mode stack traces and symbol map files

2009-02-13 Thread BobV
@mmastrac, Thanks for the data. I think that I should add an override to JavaScriptException to handle non-java exceptions in those browsers that do have e.stack or equivalent and retain some kind of caller chain for java-dervied exceptions. -- Bob. (Android) On Feb 13, 2009 1:25 PM, Matt

[gwt-contrib] Re: RR : Implement web-mode stack traces and symbol map files

2009-02-13 Thread Matt Mastracci
One other minor item I just noticed: in IE, an anonymous function's toString output has no spaces (function(){} vs. function (){} in other browsers), so the below assertion and associated function will fail: + static String extractName(String fnToString) { +assert

[gwt-contrib] [google-web-toolkit commit] r4717 - branches/snapshot-2009.02.09

2009-02-13 Thread codesite-noreply
Author: j...@google.com Date: Fri Feb 13 11:00:01 2009 New Revision: 4717 Modified: branches/snapshot-2009.02.09/branch-info.txt Log: Updating branch-info for merge from trunk. Modified: branches/snapshot-2009.02.09/branch-info.txt

[gwt-contrib] Re: Announcing GWT 1.6 Milestone 1

2009-02-13 Thread Scott Blum
Not sure what might be causing the SAX problem. Can you file an issue with more detailed information? The NoClassDefFound is caused by not copying gwt-servlet.jar into WEB-INF/lib. If you run the ant build file, it will do this automatically, but we have a fix in place for the next milestone

[gwt-contrib] Patching demo code for becomeLeaf method in gen2 fastTree

2009-02-13 Thread nwolf
Reviewers: ecc, Description: Created a DynamicTree in the fastTreeDemo for the gen2 FastTree that provides buttons to make a node a leaf and then to add new nodes to the leaf node to make it have children again. Deprecated the HasFastTreeItems interface. Added a public getTreeRoot() method to

[gwt-contrib] [google-web-toolkit commit] r4718 - in releases/1.6: samples/dynatable/war/WEB-INF user/src/com/google/gwt/user/tools

2009-02-13 Thread codesite-noreply
Author: sco...@google.com Date: Fri Feb 13 13:17:55 2009 New Revision: 4718 Modified: releases/1.6/samples/dynatable/war/WEB-INF/web.xml releases/1.6/user/src/com/google/gwt/user/tools/WebAppCreator.java releases/1.6/user/src/com/google/gwt/user/tools/project.ant.xmlsrc Log: Update

[gwt-contrib] Re: Patching demo code for becomeLeaf method in gen2 fastTree

2009-02-13 Thread nwolf
I'm lovin' this tool. http://gwt-code-reviews.appspot.com/4806/diff/1/5 File src-demo/com/google/gwt/gen2/demo/fasttree/FastTreeDemo.gwt.xml (left): http://gwt-code-reviews.appspot.com/4806/diff/1/5#oldcode2 Line 2: On 2009/02/13 21:01:40, ecc wrote: looks like a line was lost. do you want

[gwt-contrib] [google-web-toolkit commit] r4719 - in changes/jat/ihm/dev: core/src/com/google/gwt/core/ext/linker/impl core/src/com/google/...

2009-02-13 Thread codesite-noreply
Author: j...@google.com Date: Fri Feb 13 14:18:05 2009 New Revision: 4719 Modified: changes/jat/ihm/dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java changes/jat/ihm/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java

[gwt-contrib] [google-web-toolkit commit] r4723 - in releases/1.6/dev/core: src/com/google/gwt/dev/javac test/com/google/gwt/dev/javac

2009-02-13 Thread codesite-noreply
Author: sco...@google.com Date: Fri Feb 13 15:26:20 2009 New Revision: 4723 Added: releases/1.6/dev/core/src/com/google/gwt/dev/javac/JsniChecker.java - copied, changed from r4717, /releases/1.6/dev/core/src/com/google/gwt/dev/javac/LongFromJSNIChecker.java

[gwt-contrib] [google-web-toolkit commit] r4720 - releases/1.6/user/test/com/google/gwt/dev/jjs/test

2009-02-13 Thread codesite-noreply
Author: sco...@google.com Date: Fri Feb 13 15:16:44 2009 New Revision: 4720 Modified: releases/1.6/user/test/com/google/gwt/dev/jjs/test/HostedTest.java Log: Format. Modified: releases/1.6/user/test/com/google/gwt/dev/jjs/test/HostedTest.java

[gwt-contrib] [google-web-toolkit commit] r4722 - releases/1.6/dev/core/src/com/google/gwt/dev/javac

2009-02-13 Thread codesite-noreply
Author: sco...@google.com Date: Fri Feb 13 15:24:42 2009 New Revision: 4722 Modified: releases/1.6/dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java releases/1.6/dev/core/src/com/google/gwt/dev/javac/GWTProblem.java Log: Allow GWTProblems to generate warning log

[gwt-contrib] Comment on DesignOOPHM in google-web-toolkit

2009-02-13 Thread codesite-noreply
Comment by innusius: is it possible to use it now ? The current state (as of October 2008) is the Swing-based UI is fully functional and all supported browsers/platforms pass all tests. There are still a few rough edges in the support, but it is perfectly functional. On linux I have