[gwt-contrib] Re: Could we create begin/end css attributes rather then switching left and right?

2009-02-18 Thread Rajeev Dayal
FWIW, similar sorts of things were done in HorizontalSplitPanel and DockPanel for the RTL work that was done as part of 1.5. Both of these panels had a concept of LEFT or EAST in GWT 1.4, but the bidi-friendly LINE_START and LINE_END contants were added in GWT 1.5. On Wed, Feb 18, 2009 at 9:43

[gwt-contrib] Re: RR : Declassifying RPC / Removing all type names from compilation

2009-02-18 Thread Joel Webber
On Tue, Feb 17, 2009 at 5:46 PM, BobV b...@google.com wrote: On Wed, Feb 18, 2009 at 8:50 AM, Joel Webber j...@google.com wrote: ControlFlowAnalyzer: - Just to make sure I understand this correctly, can you explain why we had to move the class-literal rescue code to JVariable? Because

[gwt-contrib] The java code about applicationCreator script generated

2009-02-18 Thread Austin
I have been searched the gwt-related groups for the question, but it seems that there are no related discussions, so I post the question here. The java source code in client folder generated by applicationCreator script contains code segment: .. Button button = new Button(Click me); ..

[gwt-contrib] Re: [google-web-toolkit commit] r4723 - in releases/1.6/dev/core: src/com/google/gwt/dev/javac test/com/google/gwt/dev/javac

2009-02-18 Thread Scott Blum
Thanks for the great feedback, I implemented your suggestions in r4782. Please check it out and lemme know what you think. Thanks! Scott --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Wrap upgrades

2009-02-18 Thread Joel Webber
I'm looking at it right now. On Wed, Feb 18, 2009 at 1:09 PM, Emily Crutcher e...@google.com wrote: Joel, Should I redirect this review to John? As I know you are very busy, so he may be a better person to review. If you could make the call on whether this should go into 1.6 or

[gwt-contrib] testability of static methods

2009-02-18 Thread Arthur Kalmenson
Hello everyone, I have a fairly complex class that is almost entirely non-GWT specific aside from a single line that uses GWT's URL.decodeComponent method. While I rediscovered GWTMockUtilities and found EasyMock Class extension, I still can't think of any way to mock out the URL class. This is

[gwt-contrib] Re: testability of static methods

2009-02-18 Thread Bruce Johnson
Mind? Heck no! That would be great! On Wed, Feb 18, 2009 at 5:21 PM, Arthur Kalmenson arthur.k...@gmail.comwrote: Hello everyone, I have a fairly complex class that is almost entirely non-GWT specific aside from a single line that uses GWT's URL.decodeComponent method. While I rediscovered

[gwt-contrib] Re: RR : Declassifying RPC / Removing all type names from compilation

2009-02-18 Thread BobV
Thanks for the review. SerializerBase contains the comment Relies on monotonic behavior of hashcodes in web mode. I see no problem with this (and I've wanted to do so for JRE stuff at times), but I don't think we've ever explicitly stated this as a requirement of System.identityHashCode().

[gwt-contrib] build issue in trunk with 'ant clean buildonly'

2009-02-18 Thread Cameron Braid
I use ant clean buildonly to quickly build gwt without the examples. However it fails due to missing folders. I have created an issue to track it, and attached a patch that fixes it. http://code.google.com/p/google-web-toolkit/issues/detail?id=3370 Cheers Cameron