[gwt-contrib] Re: Code Review: Updated SliderBar to use the new event handling

2009-03-02 Thread Uwe Maurer
Hi Emily, thanks for code review. On Fri, Feb 27, 2009 at 5:13 PM, Emily Crutcher e...@google.com wrote: The changes look great. Thank you for doing this. Any chance you could you create a gen2 version of SliderBar and deprecate the widgetideas version instead on modifying the widgetideas

[gwt-contrib] Re: Code Review: Updated SliderBar to use the new event handling

2009-03-02 Thread Uwe Maurer
Hi, I moved the SliderBar to com.google.gwt.gen2.picker.client package, and the demo to the corresponding package. I added methods to use the new event handling to the Slider Bar, and removed the old event methods. I added style injection via Gen2CssInjector. (and added the images and css to

[gwt-contrib] Code Review: ValueSpinner, inject style only once

2009-03-02 Thread Uwe Maurer
Hi, I noticed that the ValueSpinner has code in the constructor which injects the style (default or user provided). This means it gets injected everytime a ValueSpinner is created. This patch changes this so that the default style only gets injected once. Also it changes from KeyboardListener

[gwt-contrib] Re: Code Review: Updated SliderBar to use the new event handling

2009-03-02 Thread Emily Crutcher
LGTM On Mon, Mar 2, 2009 at 7:49 AM, Uwe Maurer uwe.mau...@google.com wrote: Hi, I moved the SliderBar to com.google.gwt.gen2.picker.client package, and the demo to the corresponding package. I added methods to use the new event handling to the Slider Bar, and removed the old event

[gwt-contrib] Comment on WAR_Design_1_6 in google-web-toolkit

2009-03-02 Thread codesite-noreply
Comment by sco...@google.com: It will always be put into root war directory, there's currently not an option to deploy deeper. For more information: http://code.google.com/p/google-web-toolkit/wiki/WAR_Design_1_6 --~--~-~--~~~---~--~~

[gwt-contrib] [google-web-toolkit commit] r4900 - in trunk/dev/core: src/com/google/gwt/dev/resource/impl test/com/google/gwt/dev/resource/...

2009-03-02 Thread codesite-noreply
Author: amitman...@google.com Date: Mon Mar 2 07:32:12 2009 New Revision: 4900 Modified: trunk/dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java trunk/dev/core/test/com/google/gwt/dev/resource/impl/DefaultFiltersTest.java Log: This patch enables Gwt's custom

[gwt-contrib] Comment on WAR_Design_1_6 in google-web-toolkit

2009-03-02 Thread codesite-noreply
Comment by sco...@google.com: That's correct, a more advanced setup would involve having a source war folder and copying it's contents into a target war folder; the GWT compiler would output into the target war folder, and you could clean just by blowing away the whole folder. For more

[gwt-contrib] [google-web-toolkit commit] r4901 - releases/1.6/user/src/com/google/gwt/user/datepicker/client

2009-03-02 Thread codesite-noreply
Author: e...@google.com Date: Mon Mar 2 11:17:57 2009 New Revision: 4901 Modified: releases/1.6/user/src/com/google/gwt/user/datepicker/client/DateChangeEvent.java Log: Fixes issue 3365 by making sure the date value is copied upon the construction of the date value change event. review

[gwt-contrib] [google-web-toolkit commit] r4902 - in trunk/dev: core/src/com/google/gwt/dev/shell oophm/overlay/com/google/gwt/dev/util

2009-03-02 Thread codesite-noreply
Author: j...@google.com Date: Mon Mar 2 18:14:20 2009 New Revision: 4902 Modified: trunk/dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java trunk/dev/core/src/com/google/gwt/dev/shell/SyntheticClassMember.java trunk/dev/oophm/overlay/com/google/gwt/dev/util/Jsni.java