LGTM
http://gwt-code-reviews.appspot.com/12807
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
LGTM
http://gwt-code-reviews.appspot.com/13801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Comment by inventoriffic:
This looks amazing.
For more information:
http://code.google.com/p/google-web-toolkit/wiki/CodeSplitting
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Author: j...@google.com
Date: Tue Mar 17 07:45:09 2009
New Revision: 5026
Modified:
trunk/dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java
Log:
Fix checkstyle error.
Patch by: jat
Review by: spoon (TBR)
Modified: trunk/dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java
Author: rj...@google.com
Date: Tue Mar 17 08:17:42 2009
New Revision: 5027
Added:
trunk/user/src/com/google/gwt/user/client/ui/DisclosurePanelImagesRTL.java
Modified:
trunk/user/src/com/google/gwt/user/client/ui/DisclosurePanelImages.java
The attached patch, relative to trunk r5025, removes deprecation warnings.
--
John A. Tamplin
Software Engineer (GWT), Google
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
The attached patch, relative to trunk r5025, removes PlatformSpecific by
moving the pieces of functionality into CheckForUpdates or SwtHostedModeBase
-- this gets one fewer class we have to maintain an OOPHM overlay class for.
This is split out from the previous patch.
--
John A. Tamplin
Assuming you copy/pasted the relevant code sections correctly (I didn't diff
all that stuff pedantically) this LGTM.
On Tue, Mar 17, 2009 at 12:25 PM, John Tamplin j...@google.com wrote:
The attached patch, relative to trunk r5025, removes PlatformSpecific by
moving the pieces of functionality
LGTM.
2009/3/17 John Tamplin j...@google.com
The attached patch, relative to trunk r5025, removes deprecation warnings.
--
John A. Tamplin
Software Engineer (GWT), Google
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Author: j...@google.com
Date: Tue Mar 17 12:15:06 2009
New Revision: 5029
Modified:
trunk/user/src/com/google/gwt/dom/client/DOMImplMozillaOld.java
Log:
Remove deprecation warnings from DOMImplMozillaOld.
Patch by: jat
Review by: jgw
Modified:
Author: b...@google.com
Date: Tue Mar 17 11:59:31 2009
New Revision: 5028
Added:
changes/bobv/clientbundle/user/src/com/google/gwt/resources/css/ast/CollapsedNode.java
(contents, props changed)
Fred John,
Would you guys mind having a quick look at this miniscule patch? It's very
simple, so I just attached the diff inline.
Background: Fred discovered some pretty odd behavior in his drag drop
library against 1.6, and we tracked it down to a difference between Safari 3
4 (!). It turns
On Tue, Mar 17, 2009 at 1:18 PM, Scott Blum sco...@google.com wrote:
Assuming you copy/pasted the relevant code sections correctly (I didn't
diff all that stuff pedantically) this LGTM.
Thanks, committed at r5030.
--
John A. Tamplin
Software Engineer (GWT), Google
Author: j...@google.com
Date: Tue Mar 17 12:52:54 2009
New Revision: 5030
Removed:
trunk/dev/core/src/com/google/gwt/dev/shell/PlatformSpecific.java
trunk/dev/oophm/overlay/com/google/gwt/dev/shell/PlatformSpecific.java
Modified:
trunk/dev/core/src/com/google/gwt/dev/Compiler.java
Joel,
The null problem is gone. However, with JOEL_PATCH = true, the
event.getX/Y() coordinates are off when the document is scrolled. Launch the
DragDropDemo with the window less that full size, scroll the document down a
bit, then try dragging a red box. You'll notice that the box stays in place
Let me go ahead and commit this, but let's do discuss also eliding setCheck
as well, which we could tack onto the same flag separately.
On Tue, Mar 17, 2009 at 2:35 PM, Ray Cromwell cromwell...@gmail.com wrote:
Can we roll in a disablement of setCheck() as well, or is this going to be
a
Author: sco...@google.com
Date: Tue Mar 17 14:05:14 2009
New Revision: 5032
Added:
trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerDisableCastChecking.java
(contents, props changed)
trunk/dev/core/src/com/google/gwt/dev/util/arg/OptionDisableCastChecking.java
Reviewers: jlabanca, fredsa,
Description:
See recent GWTC thread on the subject.
Please review this at http://gwt-code-reviews.appspot.com/13803
Affected files:
user/src/com/google/gwt/dom/client/DOMImplSafari.java
user/src/com/google/gwt/event/dom/client/DomEvent.java
Hello all,
Is there a special reason for MapWidget to be final? I find it useful
to extend it so I can reach my specialization inside a click listener
for example, though the MapClickEvent.getSender() method. I ask
because I don't like the idea of changing the source of the API when
the whole
Author: br...@google.com
Date: Tue Mar 17 14:58:02 2009
New Revision: 5033
Modified:
releases/1.6/user/src/com/google/gwt/user/tools/README.txtsrc
releases/1.6/user/src/com/google/gwt/user/tools/RpcClientTemplate.javasrc
Log:
Very minor spelling/capitalization tweaks
Modified:
Joel,
I did a quick test in Safari 3 on Mac and things appear to work well,
including scroll. I haven't tested all platforms, so I'm assuming for the
moment they work and that both scroll and zoom are non-breaking features :)
Thanks for digging that deep deep rabbit hole.
Fred
On Tue, Mar 17,
Followups to gwt-google-a...@googlegroups.com.
On Tue, Mar 17, 2009 at 5:58 PM, Alexandre Walter Pretyman
alexandre.prety...@gmail.com wrote:
Hello all,
Is there a special reason for MapWidget to be final? I find it useful
to extend it so I can reach my specialization inside a click
Looks good, with suggestions. Attached is what I meant when I was talking
about subclassing HostedModeBase.BrowserWidgetHostImpl. This should remove
some duplicate code. This also brings HostedMode in OOPHM up to the
present. Apply my patch on top of yours.
On Tue, Mar 17, 2009 at 6:14 PM,
LGTM
http://gwt-code-reviews.appspot.com/13803
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
committed as r5035
Thanks,
John LaBanca
jlaba...@google.com
2009/3/17 jlaba...@google.com
LGTM
http://gwt-code-reviews.appspot.com/13803
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Tue, Mar 17, 2009 at 8:38 PM, Scott Blum sco...@google.com wrote:
Looks good, with suggestions. Attached is what I meant when I was talking
about subclassing HostedModeBase.BrowserWidgetHostImpl. This should remove
some duplicate code. This also brings HostedMode in OOPHM up to the
Author: jlaba...@google.com
Date: Tue Mar 17 18:06:16 2009
New Revision: 5035
Modified:
releases/1.6/user/src/com/google/gwt/dom/client/DOMImplSafari.java
releases/1.6/user/src/com/google/gwt/event/dom/client/DomEvent.java
I tried the launch config, but I don't have a plugin installed so I didn't
actually run it. I'd say go ahead and commit and add more launch configs
later.
I agree the BrowserWidgetHost interface is temporarily ugly, but at least
it's straightforward, and we'll remove them eventually.
On Tue, Mar
in gwt incubator's FastTree, moveSelectionUp and moveSelectionDown are both
private.
Please either make these methods protected, so that I can subclass FastTree
and make my own public api to call them, or provide a public API to controll
navigation.
It coudld be as simple as adding these two
On Tue, Mar 17, 2009 at 9:57 PM, Scott Blum sco...@google.com wrote:
I tried the launch config, but I don't have a plugin installed so I didn't
actually run it. I'd say go ahead and commit and add more launch configs
later.
Thanks, committed to trunk as r5036.
--
John A. Tamplin
Software
Author: j...@google.com
Date: Tue Mar 17 22:19:39 2009
New Revision: 5037
Removed:
trunk/dev/oophm/overlay/com/google/gwt/dev/shell/BrowserWidgetHost.java
Modified:
trunk/dev/oophm/overlay/com/google/gwt/dev/HostedMode.java
31 matches
Mail list logo
