Reviewers: spoon, scottb,
Description:
Some user-agents return status code 0 when operating off of file: URLs.
This patch gets Showcase working from local files.
Please review this at http://gwt-code-reviews.appspot.com/20801
Affected files:
LGTM.
On Mon, Apr 13, 2009 at 11:14 AM, b...@google.com wrote:
Reviewers: spoon, scottb,
Description:
Some user-agents return status code 0 when operating off of file: URLs.
This patch gets Showcase working from local files.
Please review this at http://gwt-code-reviews.appspot.com/20801
On Mon, Apr 13, 2009 at 11:38 AM, Scott Blum sco...@google.com wrote:
LGTM.
Thanks. Committed at r5215.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: bruce, scottb, knorton, spoon,
Description:
This patch will alter the encoding of the initial fragment so that the
browser will evaluate it in chunks. Chunking the evaluation has
beneficial usability effects because the browser will periodically
unblock the event loop and this helps
The code LG, one high-level comment about the design. Assuming we're ok
with the design implications, this seems good.
http://gwt-code-reviews.appspot.com/21801/diff/1/2
File
dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java
(right):
On Mon, Apr 13, 2009 at 2:40 PM, sco...@google.com wrote:
The code LG, one high-level comment about the design. Assuming we're ok
with the design implications, this seems good.
The never-fail way to do this would be to have JsSourceGeneration
visitor indicate offset values of top-level
On Mon, Apr 13, 2009 at 2:55 PM, Scott Blum sco...@google.com wrote:
Actually, I am going to have to torpedo this (sorry!). It just occurred to
me that while comments are only a hypothetical problem, string literals are
a real, actual problem that could cause problems today. A string literal
If we were playing Mao, I would give you a card penalty for stating the
obvious. :-)
But uh, reliably tracking whether or not you're in a string literal is about
as much fun as writing a JavaScript parser. In fact, it might be *exactly*
as fun, if you know what I mean.
On Mon, Apr 13, 2009 at
Reviewers: rjrjr,
Description:
The DatePicker throws an IllegalStateException when it is used in a time
zone where daylight savings time occurs at midnight. The problem is
that, as the DatePicker populates the dates in the calendar, it uses a
time of 00:00:00 for all dates. However, in
Hi Bob,
Please review the attached patch to fix the SerializabilityUtil race
condition. I don't want to commit this until we actually have a failed
build that verifies the problem (per the TBR you did over the weekend), but
I'd like to have the fix queued up and ready to go as soon as it does pop
LGTM
On Mon, Apr 13, 2009 at 1:29 PM, jlaba...@google.com wrote:
Reviewers: rjrjr,
Description:
The DatePicker throws an IllegalStateException when it is used in a time
zone where daylight savings time occurs at midnight. The problem is
that, as the DatePicker populates the dates in the
Author: jlaba...@google.com
Date: Mon Apr 13 13:46:34 2009
New Revision: 5218
Added:
trunk/user/test/com/google/gwt/user/datepicker/client/CalendarUtilTest.java
(contents, props changed)
Modified:
trunk/user/src/com/google/gwt/user/datepicker/client/CalendarUtil.java
Author: sco...@google.com
Date: Mon Apr 13 13:47:35 2009
New Revision: 5219
Removed:
changes/scottb/memory/
Log:
Removing old change branch; everything is committed to trunk now.
--~--~-~--~~~---~--~~
On Mon, Apr 13, 2009 at 3:51 PM, Scott Blum sco...@google.com wrote:
If we were playing Mao, I would give you a card penalty for stating the
obvious. :-)
But uh, reliably tracking whether or not you're in a string literal is
about as much fun as writing a JavaScript parser. In fact, it
On Mon, Apr 13, 2009 at 1:53 PM, John Tamplin j...@google.com wrote:
On Mon, Apr 13, 2009 at 3:51 PM, Scott Blum sco...@google.com wrote:
If we were playing Mao, I would give you a card penalty for stating the
obvious. :-)
But uh, reliably tracking whether or not you're in a string literal
We have a confirmation on the race condition, so this review should now be
prioritized. At commit time, I'll also remove the hack
from ServerSerializationStreamReader that spams System.out and System.err.
On Mon, Apr 13, 2009 at 4:33 PM, Scott Blum sco...@google.com wrote:
Hi Bob,
Please
Author: sco...@google.com
Date: Mon Apr 13 15:24:10 2009
New Revision: 5221
Modified:
trunk/user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java
Log:
Fixes synchronization issues in SerializabilityUtil, which could cause
random RPC failures due to a race condition.
Author: sco...@google.com
Date: Mon Apr 13 15:26:28 2009
New Revision: 5222
Modified:
trunk/user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java
Log:
Removing System.out.println hack we used to track down the flakey RPC test
failure.
Modified:
Author: jlaba...@google.com
Date: Mon Apr 13 15:42:25 2009
New Revision: 5223
Modified:
trunk/user/src/com/google/gwt/dom/client/DOMImplMozillaOld.java
Log:
A recent change in getScrollLeft() normalize browsers to firefox's method
of returning negative indexes in RTL mode. However, old
Author: jlaba...@google.com
Date: Mon Apr 13 15:49:43 2009
New Revision: 5224
Modified:
branches/snapshot-2009.03.30-r5111/branch-info.txt
branches/snapshot-2009.03.30-r5111/user/src/com/google/gwt/dom/client/DOMImplMozillaOld.java
Log:
Merging tr...@5222:5223 into 2009-03-30 release
Author: j...@google.com
Date: Mon Apr 13 16:01:14 2009
New Revision: 5225
Added:
trunk/user/src/com/google/gwt/jsonp/
- copied from r5208, /trunk/user/src/com/google/gwt/jsonp/
trunk/user/src/com/google/gwt/jsonp/Jsonp.gwt.xml
- copied unchanged from r5208,
Author: b...@google.com
Date: Mon Apr 13 16:12:16 2009
New Revision: 5226
Modified:
trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JClassLiteral.java
trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
trunk/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
Author: j...@google.com
Date: Mon Apr 13 16:16:47 2009
New Revision: 5227
Added:
changes/jat/ihm/samples/hello/src/com/google/gwt/sample/hello/HostedTestApp.gwt.xml
changes/jat/ihm/samples/hello/war/HostedTestApp.html (contents, props
changed)
I've deprecated the public ImmutableResourceBundle interfaces in the
incubator project to encourage users to migrate to the ClientBundle
series of interfaces that are now part of GWT trunk. The IRB code in
the incubator project will not be removed for the foreseeable future,
but all future
Author: j...@google.com
Date: Mon Apr 13 19:23:16 2009
New Revision: 5228
Removed:
trunk/user/src/com/google/gwt/jsonp/
trunk/user/test/com/google/gwt/jsonp/
Log:
Rollback r5225 due to failing IE7 test.
--~--~-~--~~~---~--~~
On Mon, Apr 13, 2009 at 1:53 PM, John Tamplin j...@google.com wrote:
On Mon, Apr 13, 2009 at 3:51 PM, Scott Blum sco...@google.com wrote:
If we were playing Mao, I would give you a card penalty for stating the
obvious. :-)
But uh, reliably tracking whether or not you're in a string literal
Any news on when UiBinder will be available to the outside world?
Thanks
Gary
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Hey guys,
Rhino http://www.mozilla.org/rhino/ (one of Mozilla's javascript engines)
is written entirely in Java supports JS 1.7 if that helps. I'm sure
there's a parser component in there that can be extracted if the license is
compatible (MPL/GPL).
There's also GromJS
Can you verify that the same RPC decisions are being made? For
example, does the code size look about the same, and the RPC policy
files exactly the same? In particular, I'm worried about the new TICs
being added for things like wildcard types and type parameters. After
a few minutes of
29 matches
Mail list logo
