[gwt-contrib] Re: Label ellipsis support!

2009-05-11 Thread Salvador Diaz
Hi, Thanks for your contribution. I suggest you to read the contributors guide though: http://code.google.com/webtoolkit/makinggwtbetter.html#contributingcode Cheers, Salvador On May 10, 10:01 am, LooneyLynn looneyl...@gmx.biz wrote: For my own project I found it rather frustrating that there

[gwt-contrib] Re: JavaScriptException with 1.6.2

2009-05-11 Thread Joel Webber
I filed issue 3644 for this, and am going to get a fix into the 1.6 update. On Sat, Apr 11, 2009 at 2:29 AM, Gilles B gilles.broch...@gmail.com wrote: I keep on investigating, if I remove all setEnabled call (TextBox widget) used to gray not inputable fields (when I display the dialog) it

[gwt-contrib] Re: java script Error with IE7 and GWT 1.6.4

2009-05-11 Thread Joel Webber
I filed issue 3644 for this, and will get a fix into the 1.6 update. On Wed, Apr 22, 2009 at 11:54 AM, Gilles B gilles.broch...@gmail.comwrote: Hello, I have an error in some popup windows used to update data. It's not a systematic (!) error but not so difficult to produce in my

[gwt-contrib] [google-web-toolkit commit] r5328 - Fix checkstyle errors.

2009-05-11 Thread codesite-noreply
Author: j...@google.com Date: Mon May 11 07:08:30 2009 New Revision: 5328 Modified: changes/jat/ihm/dev/core/src/com/google/gwt/core/ext/soyc/impl/MemberFactory.java changes/jat/ihm/dev/core/src/com/google/gwt/core/ext/soyc/impl/StoryRecorderImpl.java

[gwt-contrib] Fix for issue 3644 (Native exception in [Node Element].is()

2009-05-11 Thread jgw
Reviewers: jlabanca, rjrjr, Description: c.f. http://code.google.com/p/google-web-toolkit/issues/detail?id=3644 Please review this at http://gwt-code-reviews.appspot.com/34801 Affected files: user/src/com/google/gwt/dom/client/Element.java user/src/com/google/gwt/dom/client/Node.java

[gwt-contrib] Re: Fix for issue 3644 (Native exception in [Node Element].is()

2009-05-11 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/34801 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] [google-web-toolkit commit] r5331 - updating branch-info.txt

2009-05-11 Thread codesite-noreply
Author: sp...@google.com Date: Mon May 11 07:59:52 2009 New Revision: 5331 Modified: branches/snapshot-2009.04.28-r5307/branch-info.txt Log: updating branch-info.txt Modified: branches/snapshot-2009.04.28-r5307/branch-info.txt

[gwt-contrib] Re: Fix for issue 3644 (Native exception in [Node Element].is()

2009-05-11 Thread jgw
On 2009/05/11 14:56:03, jlabanca wrote: LGTM Thanks, committed to releases/1.6 as r5332. http://gwt-code-reviews.appspot.com/34801 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix for issue 3644 (Native exception in [Node Element].is()

2009-05-11 Thread jgw
http://gwt-code-reviews.appspot.com/34801/diff/1/5 File user/src/com/google/gwt/dom/client/Node.java (right): http://gwt-code-reviews.appspot.com/34801/diff/1/5#newcode58 Line 58: return (!!o) (!!o.nodeType); On 2009/05/11 15:21:07, kellegous wrote: I don't understand why you need !! on both

[gwt-contrib] Re: Fix for issue 3644 (Native exception in [Node Element].is()

2009-05-11 Thread John Tamplin
On Mon, May 11, 2009 at 11:35 AM, j...@google.com wrote: I tried that initially (return o ...), but managed to get null returned. Turns out js (at least on WebKit) will coerce the (o) expression to a boolean context for the comparison, then proceed to return it uncoerced if it early-outs the

[gwt-contrib] [google-web-toolkit commit] r5329 - Fix incorrect nesting when there is no binary oracle, ignore compiled

2009-05-11 Thread codesite-noreply
Author: j...@google.com Date: Mon May 11 07:46:56 2009 New Revision: 5329 Modified: changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/CompilationState.java changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/CompilationUnit.java Log: Fix incorrect nesting when there is no

[gwt-contrib] [google-web-toolkit commit] r5330 - Reverting the code-splitting changes (r5296 and r5293) from the snapshot,

2009-05-11 Thread codesite-noreply
Author: sp...@google.com Date: Mon May 11 07:59:01 2009 New Revision: 5330 Added: branches/snapshot-2009.04.28-r5307/user/src/com/google/gwt/core/client/AsyncFragmentLoader.java - copied, changed from r5295, /trunk/user/src/com/google/gwt/core/client/AsyncFragmentLoader.java

[gwt-contrib] [google-web-toolkit commit] r5332 - Fixes issue 3644.

2009-05-11 Thread codesite-noreply
Author: j...@google.com Date: Mon May 11 08:10:30 2009 New Revision: 5332 Modified: releases/1.6/user/src/com/google/gwt/dom/client/Element.java releases/1.6/user/src/com/google/gwt/dom/client/Node.java releases/1.6/user/test/com/google/gwt/dom/client/ElementTest.java

[gwt-contrib] Re: gen2 PagingScrollTable column widths

2009-05-11 Thread jay
But if I set the min and max sizes, then the user cannot resize the columns. And...well, my users need to be able to resize the columns... So, I guess I should enter a feature request (or else provide a patch ;-) that there some way for the table to set the initial column width to the preferred

[gwt-contrib] Re: gen2 PagingScrollTable column widths

2009-05-11 Thread Isaac Truett
Jay, Am I right in understanding that you're expecting the table, when unconstrained, to grow until each column can occupy its preferred width? It should be possible to achieve that, although just setting preferred size may not be enough. There used to be a setColumnWidth() method that would set

[gwt-contrib] [google-web-toolkit commit] r5333 - Fixes Issue 3508 Clicking on a CheckBox's label triggers two click events

2009-05-11 Thread codesite-noreply
Author: rj...@google.com Date: Mon May 11 11:43:45 2009 New Revision: 5333 Modified: trunk/user/src/com/google/gwt/user/client/ui/CheckBox.java trunk/user/src/com/google/gwt/user/client/ui/RadioButton.java trunk/user/test/com/google/gwt/user/client/ui/CheckBoxTest.java Log: Fixes

[gwt-contrib] Re: gen2 PagingScrollTable column widths

2009-05-11 Thread Isaac Truett
Yep, that is what you're doing. Sorry for my failure at reading comprehension. :) I can certainly see why you would have that expectation for an unconstrained table. And if I'm reading John's probably a bug comment correctly, then it sounds like that might be a good thing to enter in the issue

[gwt-contrib] [google-web-toolkit commit] r5334 - It's not reasonable at this time to enforce the rule that a

2009-05-11 Thread codesite-noreply
Author: r...@google.com Date: Mon May 11 13:40:11 2009 New Revision: 5334 Modified: trunk/dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java trunk/dev/core/src/com/google/gwt/dev/cfg/ModuleDefSchema.java Log: It's not reasonable at this time to enforce the rule that a

[gwt-contrib] [google-web-toolkit commit] r5335 - Fixes AsyncFragmentLoader.haveInitialFragmentsLoaded(). In its

2009-05-11 Thread codesite-noreply
Author: sp...@google.com Date: Mon May 11 13:51:44 2009 New Revision: 5335 Modified: trunk/user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java Log: Fixes AsyncFragmentLoader.haveInitialFragmentsLoaded(). In its previous state, it could allow code to load before prerequisite

[gwt-contrib] Re: gen2 PagingScrollTable column widths

2009-05-11 Thread jay
I've entered issue #3648 -- http://code.google.com/p/google-web-toolkit/issues/detail?id=3648. thanks! jay On May 11, 1:30 pm, Isaac Truett itru...@gmail.com wrote: Yep, that is what you're doing. Sorry for my failure at reading comprehension. :) I can certainly see why you would have

[gwt-contrib] [google-web-toolkit commit] r5345 - Bump buffer size on Util.copy().

2009-05-11 Thread codesite-noreply
Author: sco...@google.com Date: Mon May 11 17:09:38 2009 New Revision: 5345 Modified: trunk/dev/core/src/com/google/gwt/dev/util/Util.java Log: Bump buffer size on Util.copy(). Review by: spoon Modified: trunk/dev/core/src/com/google/gwt/dev/util/Util.java

[gwt-contrib] [google-web-toolkit commit] r5339 - Early out of expensive script-size logging in Link when LogLevel TRACE.

2009-05-11 Thread codesite-noreply
Author: sco...@google.com Date: Mon May 11 17:08:20 2009 New Revision: 5339 Modified: trunk/dev/core/src/com/google/gwt/dev/Link.java Log: Early out of expensive script-size logging in Link when LogLevel TRACE. Review by: spoon (desk) Modified:

[gwt-contrib] [google-web-toolkit commit] r5343 - Optimize Link production of output directory.

2009-05-11 Thread codesite-noreply
Author: sco...@google.com Date: Mon May 11 17:09:17 2009 New Revision: 5343 Modified: trunk/dev/core/src/com/google/gwt/core/ext/linker/EmittedArtifact.java trunk/dev/core/src/com/google/gwt/core/ext/linker/SyntheticArtifact.java

[gwt-contrib] [google-web-toolkit commit] r5338 - During precompile, only do a draft optimize due to superlinear optimization performance.

2009-05-11 Thread codesite-noreply
Author: sco...@google.com Date: Mon May 11 17:08:12 2009 New Revision: 5338 Modified: trunk/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java Log: During precompile, only do a draft optimize due to superlinear optimization performance. This makes precompile faster at the

[gwt-contrib] [google-web-toolkit commit] r5347 - Remove testLabelClick, because it can't pass on IE.

2009-05-11 Thread codesite-noreply
Author: rj...@google.com Date: Mon May 11 17:29:39 2009 New Revision: 5347 Modified: trunk/user/test/com/google/gwt/user/client/ui/CheckBoxTest.java Log: Remove testLabelClick, because it can't pass on IE. TBR scottb Modified:

[gwt-contrib] [google-web-toolkit commit] r5336 - Fixes issue #3570: TreeLogger nesting level increases by one for each Module compiled.

2009-05-11 Thread codesite-noreply
Author: sco...@google.com Date: Mon May 11 16:21:17 2009 New Revision: 5336 Modified: releases/1.6/dev/core/src/com/google/gwt/dev/Compiler.java Log: Fixes issue #3570: TreeLogger nesting level increases by one for each Module compiled. Review by: spoon (desk) Modified:

[gwt-contrib] [google-web-toolkit commit] r5344 - Optimize Linker performance handling of JavaScript.

2009-05-11 Thread codesite-noreply
Author: sco...@google.com Date: Mon May 11 17:09:29 2009 New Revision: 5344 Modified: trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardCompilationResult.java trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java

[gwt-contrib] [google-web-toolkit commit] r5341 - Speed up JRealClassType.getSubTypes() by implementing an optimized toArray() in our set c...

2009-05-11 Thread codesite-noreply
Author: sco...@google.com Date: Mon May 11 17:08:49 2009 New Revision: 5341 Modified: trunk/dev/core/src/com/google/gwt/core/ext/typeinfo/JRealClassType.java trunk/dev/core/src/com/google/gwt/dev/util/collect/HashMap.java

[gwt-contrib] [google-web-toolkit commit] r5346 - CompilationState now keeps a Collection of units rather than a Set; this allows us to sim...

2009-05-11 Thread codesite-noreply
Author: sco...@google.com Date: Mon May 11 17:09:51 2009 New Revision: 5346 Modified: trunk/dev/core/src/com/google/gwt/dev/Precompile.java trunk/dev/core/src/com/google/gwt/dev/javac/CompilationState.java trunk/dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java

[gwt-contrib] [google-web-toolkit commit] r5337 - Fixes issue #1287; use java.awt.headless for compiler tasks that don't use -treeLogger.

2009-05-11 Thread codesite-noreply
Author: sco...@google.com Date: Mon May 11 16:21:27 2009 New Revision: 5337 Modified: releases/1.6/dev/core/src/com/google/gwt/dev/CompileTaskRunner.java Log: Fixes issue #1287; use java.awt.headless for compiler tasks that don't use -treeLogger. Review by: spoon (desk) Modified:

[gwt-contrib] [google-web-toolkit commit] r5340 - Big refactoring of StandardGeneratorContext so that only one instance is created during a...

2009-05-11 Thread codesite-noreply
Author: sco...@google.com Date: Mon May 11 17:08:36 2009 New Revision: 5340 Modified: trunk/dev/core/src/com/google/gwt/dev/Precompile.java trunk/dev/core/src/com/google/gwt/dev/jdt/RebindPermutationOracle.java trunk/dev/core/src/com/google/gwt/dev/jdt/WebModeCompilerFrontEnd.java

[gwt-contrib] [google-web-toolkit commit] r5342 - Optimize SymbolData serialization to speed up Link.

2009-05-11 Thread codesite-noreply
Author: sco...@google.com Date: Mon May 11 17:09:04 2009 New Revision: 5342 Modified: trunk/dev/core/src/com/google/gwt/core/ext/linker/CompilationResult.java trunk/dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java

[gwt-contrib] Re: [google-web-toolkit commit] r5347 - Remove testLabelClick, because it can't pass on IE.

2009-05-11 Thread Scott Blum
I'm the wrong TBR for this. Joel perhaps? --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---