[gwt-contrib] Re: naming runAsync calls

2009-06-19 Thread Cameron Braid
You could always change the signiture of GWT.runAsync to include a String parameter as the first parameter. I must be a literal in code, and would be optimized out / ignored by the compiler : GWT.runAsync("foo", new RunAsyncCallback() { Cam 2009/6/20 Lex Spoon > > There are multiple reas

[gwt-contrib] Re: naming runAsync calls

2009-06-19 Thread Ian Petersen
On Fri, Jun 19, 2009 at 10:22 AM, Ian Petersen wrote: > On Fri, Jun 19, 2009 at 9:57 AM, Bruce Johnson wrote: >> My worry about Ian's proposal is >> that method overloading complicate things > > Excellent point--wasn't thinking about overloads. Now that I've had more time to think, my RunAsyncRef

[gwt-contrib] Re: naming runAsync calls

2009-06-19 Thread Rob Heittman
I've been working to improve load behavior of a very large application with a few dozen runAsync calls, and for Javadoc clarity I've been putting each call in its own method anyway -- found this very useful to track the purpose and timing of each split, and document any known implications. So in p

[gwt-contrib] [google-web-toolkit commit] r5593 - Add typeId information to linker SymbolData API.

2009-06-19 Thread codesite-noreply
Author: b...@google.com Date: Fri Jun 19 10:32:43 2009 New Revision: 5593 Modified: trunk/dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardSymbolData.java trunk/dev/core/src/com/google/gwt/dev/jjs/impl/Generat

[gwt-contrib] [google-web-toolkit commit] r5590 - A one-line fix to the currently broken support for a runAsync initial

2009-06-19 Thread codesite-noreply
Author: sp...@google.com Date: Fri Jun 19 09:06:11 2009 New Revision: 5590 Added: trunk/user/test/com/google/gwt/dev/jjs/InitialLoadSequence.gwt.xml (contents, props changed) trunk/user/test/com/google/gwt/dev/jjs/test/InitialLoadSequenceTest.java (contents, props changed) Modif

[gwt-contrib] Re: Misc JS problem cleanup

2009-06-19 Thread jgw
On 2009/06/19 01:37:23, scottb wrote: LGTM. Good catches, all. http://gwt-code-reviews.appspot.com/42802 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] [google-web-toolkit commit] r5591 - Merge r5590 from trunk.

2009-06-19 Thread codesite-noreply
Author: b...@google.com Date: Fri Jun 19 10:07:55 2009 New Revision: 5591 Added: branches/snapshot-2009.06.16-r5570/user/test/com/google/gwt/dev/jjs/InitialLoadSequence.gwt.xml - copied unchanged from r5590, /trunk/user/test/com/google/gwt/dev/jjs/InitialLoadSequence.gwt.xml

[gwt-contrib] [google-web-toolkit commit] r5592 - Update branch-info.txt to reflect r5591.

2009-06-19 Thread codesite-noreply
Author: b...@google.com Date: Fri Jun 19 10:11:21 2009 New Revision: 5592 Modified: branches/snapshot-2009.06.16-r5570/branch-info.txt Log: Update branch-info.txt to reflect r5591. Modified: branches/snapshot-2009.06.16-r5570/branch-info.txt

[gwt-contrib] Re: naming runAsync calls

2009-06-19 Thread Ian Petersen
On Fri, Jun 19, 2009 at 9:57 AM, Bruce Johnson wrote: > My worry about Ian's proposal is > that method overloading complicate things Excellent point--wasn't thinking about overloads. I think your solution might be more elegant--it seems easier to explain, understand, and enforce "must sub-interf

[gwt-contrib] [google-web-toolkit commit] r5589 - Edited wiki page through web user interface.

2009-06-19 Thread codesite-noreply
Author: b...@google.com Date: Fri Jun 19 08:41:08 2009 New Revision: 5589 Modified: wiki/CssResource.wiki Log: Edited wiki page through web user interface. Modified: wiki/CssResource.wiki == --- wiki/CssResource.wik

[gwt-contrib] Re: RR : Export typeids through SymbolMap data

2009-06-19 Thread spoon
LGTM. That will be helpful information to have in the symbol maps. http://gwt-code-reviews.appspot.com/41802 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: naming runAsync calls

2009-06-19 Thread Bruce Johnson
A slight tweak to what Ian said: What if we got this effect by simpy requiring you to use interfaces that extend AsyncCallback as a way to reify split points? interface EmailCompositionView extends AsyncCallback { ... } Then you definitely have a fully-qualified name for a split point if you ne

[gwt-contrib] Re: fixes runAsync initial load sequences and adds a test case

2009-06-19 Thread spoon
Committed at r5590. http://gwt-code-reviews.appspot.com/43802 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: fixes runAsync initial load sequences and adds a test case

2009-06-19 Thread spoon
http://gwt-code-reviews.appspot.com/43802/diff/1/4 File user/test/com/google/gwt/dev/jjs/InitialLoadSequence.gwt.xml (right): http://gwt-code-reviews.appspot.com/43802/diff/1/4#newcode2 Line 2: On 2009/06/19 02:23:12, bobv wrote: > 2009 Done. http://gwt-code-reviews.appspot.com/43802/diff/1/3

[gwt-contrib] RR : Export typeids through SymbolMap data

2009-06-19 Thread bobv
Reviewers: Lex, scottb, Message: Requesting review Description: This change adds an additional method to the linker SymbolData API to export typeids. This data will be used by the derpc code. Please review this at http://gwt-code-reviews.appspot.com/41802 Affected files: M dev/core/src/com

[gwt-contrib] Re: naming runAsync calls

2009-06-19 Thread Ian Petersen
On Fri, Jun 19, 2009 at 8:33 AM, Lex Spoon wrote: > This looks like a straightforward and easily understood way to name > calls to runAsync.  What do others think? As a brainstorm-quality idea, what about requiring that runAsync invocations are in their own methods (as you mentioned) but not requ

[gwt-contrib] Re: Speed up compilation by rewriting for loops to avoid iterators

2009-06-19 Thread Ian Petersen
On Fri, Jun 19, 2009 at 8:23 AM, Lex Spoon wrote: > The main tradeoffs I see are that the files version integrates well > with existing tools and IDEs.  No matter what build tool you use, you > should be able to get a fast incremental build by using the files > version.  On the flip side, for peop

[gwt-contrib] Re: Speed up compilation by rewriting for loops to avoid iterators

2009-06-19 Thread Lex Spoon
On Mon, Jun 15, 2009 at 11:52 PM, Ray Cromwell wrote: > Would it not be possible to store the Unified/Precompiled/Unoptimized > AST to disk and then you'd only have to JDT-reparse any classes that > changed? Or use, was it Toby?'s, old idea of tunneling compiler > information in .class files on di

[gwt-contrib] naming runAsync calls

2009-06-19 Thread Lex Spoon
There are multiple reasons that people end up wanting a way to name calls to runAsync. One of them is the specification of an initial load sequence that I just implemented. Looking ahead, they would be useful for prefetch requests. It's hard to say "download fragment Foo if you can", if you don

[gwt-contrib] Re: RPC extension points

2009-06-19 Thread Lex Spoon
On Mon, Jun 15, 2009 at 11:59 AM, noon wrote: > > Hello, > > This thread follows this one (http://groups.google.com/group/Google- > Web-Toolkit-Contributors/msg/582cfe33f17deab3), so please read it > before this one. > > To make Google App Engine and GWT work together (in adapter4appengine > proje

[gwt-contrib] Re: HashMap Optimization: return null for put and remove

2009-06-19 Thread Lex Spoon
By the way, in case it's not obvious, having Map.put() return the old value is usually good for performance. Without it, coders must sometimes do a query of the map followed by a put, which means that the same key is looked up twice. To contrast, returning a value that is at hand but is not actu

[gwt-contrib] Re: More if-statement optimizations in JsStaticEval

2009-06-19 Thread Lex Spoon
On Tue, Jun 9, 2009 at 11:01 AM, Matt Mastracci wrote: > Yeah...   I would love to have a single AST to represent both of the > language states - many optimizations don't happen because we toss all > the Java type info during the conversion to JS. > > For instance, you can't safely optimize this:

[gwt-contrib] Comment on CssResource in google-web-toolkit

2009-06-19 Thread codesite-noreply
Comment by daniel.florey: In @sprite example you have to replace class with interface For more information: http://code.google.com/p/google-web-toolkit/wiki/CssResource --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--