[gwt-contrib] Re: Allow detached JDO objects to be transferred via RPC

2009-06-29 Thread bruno
Hi all, I did similar development with Gilead adapter for GAE (available on Gilead site : http://gilead.sourceforge.net), so I guess it would be a good idea to share our knwoledge about it. I modified nearly the same files, but I more generic concepts (ISerializationFilter and

[gwt-contrib] Re: RPC extension points

2009-06-29 Thread bruno
Hi Lex, The main problem comes from enhancement added fields, so user can add @GwtTransient annotation on it. Yes, enhancement is evil, but we have to do with them... Regards Bruno On 19 juin, 17:09, Lex Spoon sp...@google.com wrote: On Mon, Jun 15, 2009 at 11:59 AM,

[gwt-contrib] Re: DockLayoutPanel

2009-06-29 Thread Joel Webber
That's fairly closely related to the approach I'm taking. It is worth noting, however, that this totally fails on IE6, because it won't handle the kinds of implicit constraints created by, e.g., { left:0; right:0; }. Just to make matters more difficult, it also can't handle { right:0; } properly

[gwt-contrib] Re: SoyLite

2009-06-29 Thread Katharina Probst
I think this is a great idea, especially because it can be offered side by side with the existing SOYC (that includes partial blame assignment). I agree with you, Lex, that explaining partial blame assignment has been a challenge. What I am still trying to understand is exactly how blame is

[gwt-contrib] Re: Allow detached JDO objects to be transferred via RPC

2009-06-29 Thread bobv
Please extract the expando work to the gwt.core.client package and add test cases for it, as it's a generally-useful facility to offer. Needs tests of the JDO testcases. @Cromwellian, The expando field just reserves a bit of the Object-field namespace since it's lazily initialized.

[gwt-contrib] Re: Add Impl.getNameOf() to expose JNameOf nodes to Java code

2009-06-29 Thread bobv
Ping http://gwt-code-reviews.appspot.com/46802 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Add ArtificialRescue annotation to compiler

2009-06-29 Thread bobv
Ping http://gwt-code-reviews.appspot.com/46801 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Comment on UsingOOPHM in google-web-toolkit

2009-06-29 Thread codesite-noreply
Comment by kojot...@gmail.com: @dan.kozlowski I've followed your steps and it worked like a charm :) thanks a lot. My system: openSUSE 11.1 64bit + FF 3.5rc3 64bit + Sun JVM 1.6 64bit + eclipse 3.4 + GWT trunk (with oophm enabled) For more information:

[gwt-contrib] Issue 2749: RichTextArea timing issue using BasicFormatter and ExtendedFormatter methods

2009-06-29 Thread jlabanca
Reviewers: jgw, Description: Description: === Using almost any method in the Basic or Extended formatter when the RichTextArea is detached results in a JS exception on all browsers. Even after it is attached, a JS exception occurs in some browsers if the area is not initialized or if it

[gwt-contrib] Re: RPC extension points

2009-06-29 Thread Freeland Abbott
FWIW, Dan Rice has also been working on this, if you hadn't seen his review thread from Friday. On Mon, Jun 29, 2009 at 6:14 AM, bruno bruno.marches...@gmail.com wrote: Hi Lex, The main problem comes from enhancement added fields, so user can add @GwtTransient annotation on it. Yes,

[gwt-contrib] Manifest for SOYC permutations

2009-06-29 Thread kprobst
Reviewers: Lex, Description: This patch creates a manifest file for each compilation permutation if the compilation is SOYC enabled. The manifest files are stored alongside other SOYC manifests (in the soycReport directory). Each manifest file contains all non-gwt properties for the

[gwt-contrib] Re: Allow detached JDO objects to be transferred via RPC

2009-06-29 Thread rice
http://gwt-code-reviews.appspot.com/47807/diff/1/9 File user/src/com/google/gwt/user/client/rpc/WeakMapping.java (right): http://gwt-code-reviews.appspot.com/47807/diff/1/9#newcode31 Line 31: public static Object get(Object instance, String key) { I'm not sure what can be said about the

[gwt-contrib] Issue 1441: RichTextArea no cursor until you type in Firefox

2009-06-29 Thread jlabanca
Reviewers: jgw, Description: Description: === In Firefox, the text caret always appears at the begining of the RichTextArea when the user clicks the first time, regardless of where in the RichTextArea the user clicked. The problem is that we set design mode on focus in Mozilla, which

[gwt-contrib] Re: SoyLite

2009-06-29 Thread Lex Spoon
On Sun, Jun 28, 2009 at 12:19 AM, John Tamplinj...@google.com wrote: On Fri, Jun 26, 2009 at 3:20 PM, Lex Spoon sp...@google.com wrote: I've been trying to think of ways to speed up the -soyc option, and here is the result of one attempt.  What do people think? The idea is to mimick some

[gwt-contrib] gen2 PagingScrollTable: programmatic cell editing

2009-06-29 Thread jay
Another piece of feedback on the incubator paging scroll table... I've got a case where I need to programmatically change the value in some cells (based on other input from the user). However, since the method used as the cell editor's callback is an anonymous, inline inner class, I have to

[gwt-contrib] Re: Allow detached JDO objects to be transferred via RPC

2009-06-29 Thread bobv
http://gwt-code-reviews.appspot.com/47807/diff/1/9 File user/src/com/google/gwt/user/client/rpc/WeakMapping.java (right): http://gwt-code-reviews.appspot.com/47807/diff/1/9#newcode31 Line 31: public static Object get(Object instance, String key) { On 2009/06/29 15:34:02, Dan Rice wrote: I'm

[gwt-contrib] Re: Issue 2749: RichTextArea timing i ssue using BasicFormatter and ExtendedFormatter methods

2009-06-29 Thread jgw
On 2009/06/29 15:08:27, jlabanca wrote: LGTM. http://gwt-code-reviews.appspot.com/49801 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] [google-web-toolkit commit] r5636 - Fixes an issue with a missing text caret in the RichTextArea in FF.

2009-06-29 Thread codesite-noreply
Author: jlaba...@google.com Date: Mon Jun 29 10:31:37 2009 New Revision: 5636 Modified: trunk/user/src/com/google/gwt/user/client/ui/impl/RichTextAreaImplMozilla.java Log: Fixes an issue with a missing text caret in the RichTextArea in FF. Patch by: jlabanca Review by: jgw Issue: 1441

[gwt-contrib] [google-web-toolkit commit] r5637 - Adds some assertions to RichTextArea to prevent users from using the formatters before th...

2009-06-29 Thread codesite-noreply
Author: jlaba...@google.com Date: Mon Jun 29 10:34:10 2009 New Revision: 5637 Modified: trunk/user/src/com/google/gwt/user/client/ui/RichTextArea.java trunk/user/src/com/google/gwt/user/client/ui/impl/RichTextAreaImplIE6.java

[gwt-contrib] Re: Add Impl.getNameOf() to expose JNameOf nodes to Java code

2009-06-29 Thread scottb
LGTM, with comment. http://gwt-code-reviews.appspot.com/46802/diff/1/3 File dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRebinds.java (right): http://gwt-code-reviews.appspot.com/46802/diff/1/3#newcode95 Line 95: // Proper JSNI ref Shouldn't most of this lookup logic be duplicated elsewhere

[gwt-contrib] Update RichTextAreaImplSafari

2009-06-29 Thread jlabanca
Reviewers: jgw, Description: Most of RichTextAreaImplSafari was written to support older versions of Safari, which we know longer need to support. I've stripped away all of the old stuff, leaving only a few Safari specific implementations. This patch also fixes issue 2813 by removing some

[gwt-contrib] [google-web-toolkit commit] r5638 - Fixed a broken test that would fail 0.1% of the time because it assumes that a Date has a...

2009-06-29 Thread codesite-noreply
Author: jlaba...@google.com Date: Mon Jun 29 13:22:41 2009 New Revision: 5638 Modified: trunk/user/test/com/google/gwt/emultest/java/sql/SqlTimestampTest.java Log: Fixed a broken test that would fail 0.1% of the time because it assumes that a Date has a non-zero millsecond field. Patch

[gwt-contrib] Re: SoyLite

2009-06-29 Thread Katharina Probst
Hi Lex, all of what you say makes sense to me. I think SoyLite is a great idea and we should go ahead with it. I do have one concern, however: as you mention below, some methods will simply appear to disappear under SoyLite. For instance, in your first example, Point.getX() will not appear to

[gwt-contrib] Re: Manifest for SOYC permutations

2009-06-29 Thread spoon
LGTM. Ideally, the similar information in the symbol maps files could be reused. However, this patch certainly does the job as is. It's up to you. http://gwt-code-reviews.appspot.com/50801 --~--~-~--~~~---~--~~

[gwt-contrib] using string constants in @def

2009-06-29 Thread Eric Ayers
Bob, I would like to use a string constant in an @def. Would you be open to a patch that added a new Method annotation to distinguish this type of accessor from a class name? -- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://code.google.com/webtoolkit/

[gwt-contrib] Re: using string constants in @def

2009-06-29 Thread Eric Ayers
Sorry, a little more context, I'm talking about the CssResource class. On Mon, Jun 29, 2009 at 5:58 PM, Eric Ayerszun...@google.com wrote: Bob, I would like to use a string constant in an @def. Would you be open to a patch that added a new Method annotation to distinguish this type of

[gwt-contrib] Re: Manifest for SOYC permutations

2009-06-29 Thread Katharina Probst
Thanks, Lex. I've uploaded another patch for your review that addresses your comment. I'm still not quite certain which way is better - what do people think? Option 1: Create a manifest file for each permutation which carries the same permutation id as the existing SOYC report files. Good: Can

[gwt-contrib] IE8 disappearing history

2009-06-29 Thread Amir Kashani
I’m having a strange issue with trunk and IE8 where the browser’s history stack inexplicably “disappears”. That is, the history drop down list empties (including previously visited non-GWT sites, like MSN) and the back/forward buttons don’t work. My guess is that this is a bug in IE8 that GWT is

[gwt-contrib] GWTTestCase fails to run other module's onModuleLoad() methods

2009-06-29 Thread Fred Sauer
Scott, IIRC, you were most recently working on GWTTestCase changes. I just filed this issue which is throwing gwt-log users trying to use GWTTestCase: http://code.google.com/p/google-web-toolkit/issues/detail?id=3791 I hoping the described behavior is not as designed. Thanks -- Fred Sauer