Revision: 6369
Author: j...@google.com
Date: Tue Oct 13 23:49:20 2009
Log: Rearrange ant test targets.
The continuous build systems need to have gwt.hosts.dev.remote and
gwt.hosts.dev.selenium set to those hosts which have the devmode plugin
installed for devmode tests to be run at all, until
Revision: 6370
Author: j...@google.com
Date: Wed Oct 14 00:44:30 2009
Log: Rearrange ant test targets.
The continuous build systems need to have gwt.hosts.dev.remote and
gwt.hosts.dev.selenium set to those hosts which have the devmode plugin
installed for devmode tests to be run at all, until
Reviewers: jgw,
Message:
Thanks in advance, Joel.
Please review this at http://gwt-code-reviews.appspot.com/78817
Affected files:
M user/src/com/google/gwt/uibinder/parsers/DisclosurePanelParser.java
M user/src/com/google/gwt/uibinder/rebind/XMLElement.java
M
My 2 c€nts
http://gwt-code-reviews.appspot.com/78817/diff/15/1029
File user/src/com/google/gwt/user/client/ui/DisclosurePanel.java
(right):
http://gwt-code-reviews.appspot.com/78817/diff/15/1029#newcode62
Line 62: super(DOM.createAnchor());
Couldn't you use a FocusImpl instead, and therefore
http://gwt-code-reviews.appspot.com/77820/diff/1004/1005#newcode23
Line 23: public class Scheduler {
The public Scheduler class is now abstract.
http://gwt-code-reviews.appspot.com/77820/diff/1004/1005#newcode123
Line 123: public static void schedulePause() {
schedulePause has been
IMPLEMENTATION NOTES
This patch updates the Linker API to be shardable. It updates the
compiler to deal with this new API, and it updates the built-in
linkers to support it.
The main API change is that Linker.link has an extra boolean argument.
That method is to be called once per permutation
Assuming you've tested the RESCUE SSW behavior and that Joel likes it,
this LGTM.
http://gwt-code-reviews.appspot.com/77820
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Broadly, I'm not entirely sure what we're trying to achieve by promoting
DisclosurePanelHeader to a public top-level class. It's pretty complex,
for a seemingly simple problem. If you were to replace it wholesale
within an application, you will pretty much be replacing the entire
widget.
It
On 2009/10/13 21:00:25, Ray Ryan wrote:
Another one for you, Joel. This allows multiple source files to be
specified for
a ui:style, just like any other CssResource.
It also allows you to put body text on a ui:style that has sources.
The body
becomes just one more source file, the last
Reviewers: scottb,
Message:
Review requested. The explanation is longer than the bugfix.
Description:
This fixes a problem where a statically-initialized field could be
referred to before it has been initialized by its clinit.
I found this pattern would result in invalid code generation;
On 2009/10/14 04:58:42, bruce wrote:
LGTM with a typo fix. An idea for an incredibly trivial improvement if
you just
want to change something more for the heck of it.
http://gwt-code-reviews.appspot.com/78816/diff/1/2
File user/src/com/google/gwt/dom/client/StyleInjector.java (right):
Comment by benzheren:
I am following example on wiki:
http://code.google.com/p/google-web-toolkit/wiki/UiBinderI18n
to try out UiBinderi18n in the latest 2.0 MS 1 release. I wrote a
sample ui.xml file like this:
{{{
?xml version=1.0 encoding=UTF-8?
ui:UiBinder
First, sorry to throw something like this at you at the last second. What
was that Bruce said about getting enough sleep and making good decisions?
The other goal, which I realize know I didn't hit, was to be able to put the
stock header in one spot and the panel it opens or closes in another
On 2009/10/14 15:43:38, jgw wrote:
Broadly, I'm not entirely sure what we're trying to achieve by
promoting
DisclosurePanelHeader to a public top-level class. It's pretty
complex, for a
seemingly simple problem. If you were to replace it wholesale within
an
application, you will pretty much be
Thomas, this all makes sense but I don't think we can make it happen for
2.0. Certainly not MS2, and probably not for the RC (though it's tempting,
DisclosurePanel is so close to being so much more useful). Do you mind
creating an issue on the public tracker capturing this?
On Wed, Oct 14, 2009
Yes, please, please, please make this instance based. Every serious app I've
seen winds up creating its own interface to wrap around our static calls to
make them testable (and the ones on commands in particular), and it's
generally a painful retrofit. It also becomes a real difficultly for those
On Wed, Oct 14, 2009 at 1:03 PM, Ray Ryan rj...@google.com wrote:
Yes, please, please, please make this instance based. Every serious app I've
seen winds up creating its own interface to wrap around our static calls to
make them testable (and the ones on commands in particular), and it's
On Wed, Oct 14, 2009 at 10:04 AM, BobV b...@google.com wrote:
On Wed, Oct 14, 2009 at 1:03 PM, Ray Ryan rj...@google.com wrote:
Yes, please, please, please make this instance based. Every serious app
I've
seen winds up creating its own interface to wrap around our static calls
to
make
LGTM
On Wed, Oct 14, 2009 at 10:06 AM, Ray Ryan rj...@google.com wrote:
On Wed, Oct 14, 2009 at 10:04 AM, BobV b...@google.com wrote:
On Wed, Oct 14, 2009 at 1:03 PM, Ray Ryan rj...@google.com wrote:
Yes, please, please, please make this instance based. Every serious app
I've
seen
How's this sound for a proposal to wrap all this up, then:- Drop the public
DisclosureHeader class, as Ray suggested earlier.
- Implement the g:header/g:body/ version of the parser (I agree it's
probably clearer).
- Create a separate issue (possibly eclipsing issue 1449, possibly simply
clarifying
Revision: 6372
Author: j...@google.com
Date: Wed Oct 14 11:08:29 2009
Log: Clean up formatting and ant -p output in ant build files.
Patch by: jat
Review by: jlabanca (desk)
http://code.google.com/p/google-web-toolkit/source/detail?r=6372
Modified:
/trunk/common.ant.xml
On 2009/10/14 16:45:38, t.broyer wrote:
On 2009/10/14 15:43:38, jgw wrote:
Broadly, I'm not entirely sure what we're trying to achieve by
promoting
DisclosurePanelHeader to a public top-level class. It's pretty
complex, for a
seemingly simple problem. If you were to replace it wholesale
Bob, this patch looks good. But I have to admit I can't understand why
it's currently broken.
Explain to me again why this transformation breaks?
(a, b).foo() -- foo((a,b))
I didn't completely follow the pattern you showed.
http://gwt-code-reviews.appspot.com/78818/diff/1/2
File
Also: test case por favor?
http://gwt-code-reviews.appspot.com/78818
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6373
Author: tamplinjohn
Date: Wed Oct 14 12:02:28 2009
Log: Edited wiki page through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=6373
Modified:
/wiki/UsingOOPHM.wiki
===
--- /wiki/UsingOOPHM.wiki Tue Oct
Reviewers: amitmanjhi,
Description:
A warning is printed when a really old plugin connects to the code
server. This adds a HelpInfo link, which points at the UsingOOPHM web
page for now, giving users information about getting a later plugin.
In the future, this will be changed to a better
I've uploaded another patch set, which merges in the latest changes from the
trunk.
On Mon, Oct 12, 2009 at 2:34 AM, John Tamplin j...@google.com wrote:
On Mon, Oct 12, 2009 at 12:03 AM, John LaBanca jlaba...@google.comwrote:
@jat -
When do you think we'll merge the htmlunit branch into
LGTM
On Wed, Oct 14, 2009 at 12:05 PM, j...@google.com wrote:
Reviewers: amitmanjhi,
Description:
A warning is printed when a really old plugin connects to the code
server. This adds a HelpInfo link, which points at the UsingOOPHM web
page for now, giving users information about getting a
@John L: You taking this one?
On Wed, Oct 14, 2009 at 12:08 PM, Pascal Muetschard
pmuetsch...@google.comwrote:
I've uploaded another patch set, which merges in the latest changes from
the trunk.
On Mon, Oct 12, 2009 at 2:34 AM, John Tamplin j...@google.com wrote:
On Mon, Oct 12, 2009 at
Revision: 6374
Author: jlaba...@google.com
Date: Wed Oct 14 12:38:52 2009
Log: Removing a statement from CoverageTest that triggers a javac bug.
Patch by: jabanca
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=6374
Modified:
Revision: 6375
Author: jlaba...@google.com
Date: Wed Oct 14 12:48:54 2009
Log: Removing emma exclusions from build file now that we removed the line
that triggers a javac bug in CoverageTest.
Patch by: jlabanca
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=6375
Yes, as soon as we get the build stabilized, I'll commit this.
Thanks,
John LaBanca
jlaba...@google.com
On Wed, Oct 14, 2009 at 3:20 PM, Bruce Johnson br...@google.com wrote:
@John L: You taking this one?
On Wed, Oct 14, 2009 at 12:08 PM, Pascal Muetschard
pmuetsch...@google.com wrote:
Reviewers: rjrj_google.com, jlabanca,
Please review this at http://gwt-code-reviews.appspot.com/78820
Affected files:
A user/javadoc/com/google/gwt/examples/TabLayoutPanelExample.java
M user/src/com/google/gwt/user/client/ui/LayoutPanel.java
A
Okay Joel, ready for another look. The only big changes to
DisclosurePanel are that it is now ImageResource based, and I've
ruthlessly deprecated its convenience constructors.
http://gwt-code-reviews.appspot.com/78817
--~--~-~--~~~---~--~~
Uploaded a tweak to tidy up image initialization.
http://gwt-code-reviews.appspot.com/78817
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewing this now. Tag, I'm it.
http://gwt-code-reviews.appspot.com/78820
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6376
Author: jlaba...@google.com
Date: Wed Oct 14 13:51:57 2009
Log: The test target in user now runs sequentially because browser manager
queues up too many requests in parallel.
Patch by: jlabanca
Review by: jgw
http://code.google.com/p/google-web-toolkit/source/detail?r=6376
http://gwt-code-reviews.appspot.com/78820/diff/1/2
File user/javadoc/com/google/gwt/examples/TabLayoutPanelExample.java
(right):
http://gwt-code-reviews.appspot.com/78820/diff/1/2#newcode41
Line 41: rp.layout();
I wonder if we could tie into the FinallyCommand mechanism to automate
and batch
LGTM
http://gwt-code-reviews.appspot.com/78820/diff/1/4
File user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java (right):
http://gwt-code-reviews.appspot.com/78820/diff/1/4#newcode61
Line 61: */
That customizability is my main concern. If the widget is actually
master of its own events,
LGTY for now?
http://gwt-code-reviews.appspot.com/78820/diff/1/2
File user/javadoc/com/google/gwt/examples/TabLayoutPanelExample.java
(right):
http://gwt-code-reviews.appspot.com/78820/diff/1/2#newcode41
Line 41: rp.layout();
On 2009/10/14 21:06:03, Ray Ryan wrote:
I wonder if we could tie
If I could chime in...
http://gwt-code-reviews.appspot.com/78820/diff/1/4
File user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java (right):
http://gwt-code-reviews.appspot.com/78820/diff/1/4#newcode365
Line 365: SelectionEvent.fire(this, index);
Any chance this could be gated on a
Revision: 6377
Author: rda...@google.com
Date: Wed Oct 14 14:33:21 2009
Log: Creating a branch for the Remote UI Communication implementation.
svn copy https://google-web-toolkit.googlecode.com/svn/tr...@6376
https://google-web-toolkit.googlecode.com/svn/branches/remote-ui-communication
After
Reviewers: jgw,
Message:
Here's an easy one. It logs lines like this:
[WARN] gwt:DockPanel is deprecated. Use the appropriate LayoutPanel
instead.
Please review this at http://gwt-code-reviews.appspot.com/78821
Affected files:
M
Revision: 6378
Author: rda...@google.com
Date: Wed Oct 14 16:15:18 2009
Log: Updated branch-info.txt to match this branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=6378
Modified:
/branches/remote-ui-communication/branch-info.txt
===
---
Revision: 6379
Author: amitman...@google.com
Date: Wed Oct 14 17:59:39 2009
Log: Removed two unnecessary lines that were re-defining a property
Patch by: amitmanjhi
http://code.google.com/p/google-web-toolkit/source/detail?r=6379
Modified:
/trunk/user/build.xml
Revision: 6380
Author: amitman...@google.com
Date: Wed Oct 14 18:26:27 2009
Log: Ignoring the testNoOverrideInheritedSharedCssClasses for the time
being, while
I debug it. It is failing in hosted mode consistently.
Patch by: amitmanjhi
46 matches
Mail list logo
