[gwt-contrib] Re: add option to generate overflow checks

2009-12-15 Thread cromwellian
On 2009/12/15 02:02:01, jat wrote: John, I assume this is a diagnostic tool for catching obscure bugs (like, find where is the world I'm overflowing and not realizing it). One idea that comes to mind is, are there any other JLS checks we should be doing so maybe a more general flag could be

[gwt-contrib] Re: add option to generate overflow checks

2009-12-15 Thread cromwellian
http://gwt-code-reviews.appspot.com/126801/diff/1/5 File dev/core/src/com/google/gwt/dev/jjs/impl/OverflowDetectionNormalizer.java (right): http://gwt-code-reviews.appspot.com/126801/diff/1/5#newcode55 Line 55: Should we care about JSOs returning values which are already overflowed? e.g. byte

Re: [gwt-contrib] add option to generate overflow checks

2009-12-15 Thread BobV
What is the motivation for this change? -- Bob Vawter Google Web Toolkit Team -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Comment on GWT_GSoC in google-web-toolkit

2009-12-15 Thread codesite-noreply
Comment by IFa.brainpower: oops: 2. GWT for Gadgets (...) or shared work between this project and the Googel for Firefox Extensions project. google for firefox For more information: http://code.google.com/p/google-web-toolkit/wiki/GWT_GSoC --

[gwt-contrib] Using cellIndex and rowIndex/sectionRowIndex to get cells' position in tables

2009-12-15 Thread Thomas Broyer
Hi all, [long intro, sorry, you can skip to interesting bits start here if you want] SpeedTracer tells me that in rendering a list of results (JsArrayEmployee returned by a RequestBuilder as JSON, displayed in a Grid widget; no other widgets involved), Chrome is spending 57.2% of its time, i.e.

Re: [gwt-contrib] add option to generate overflow checks

2009-12-15 Thread John Tamplin
On Tue, Dec 15, 2009 at 4:24 AM, BobV b...@google.com wrote: What is the motivation for this change? short foo = 32767; foo++; will behave differently in dev mode and prod mode. In prod mode, foo will now have the impossible value of 32768, while in dev mode it will be -1. GWT does not

[gwt-contrib] Re: add option to generate overflow checks

2009-12-15 Thread John Tamplin
On Tue, Dec 15, 2009 at 3:59 AM, cromwell...@gmail.com wrote: John, I assume this is a diagnostic tool for catching obscure bugs (like, find where is the world I'm overflowing and not realizing it). Correct. One idea that comes to mind is, are there any other JLS checks we should be

[gwt-contrib] Re: add option to generate overflow checks

2009-12-15 Thread John Tamplin
On Tue, Dec 15, 2009 at 4:00 AM, cromwell...@gmail.com wrote: http://gwt-code-reviews.appspot.com/126801/diff/1/5 File dev/core/src/com/google/gwt/dev/jjs/impl/OverflowDetectionNormalizer.java (right): http://gwt-code-reviews.appspot.com/126801/diff/1/5#newcode55 Line 55: Should we care

Re: [gwt-contrib] Re: add option to generate overflow checks

2009-12-15 Thread Bruce Johnson
This needs to be its own thread, but heads up: flags that affect compiler output (other than -draftCompile) need to become deferred binding properties so that we can have per-perm flags. Then, we can produce standard sets of module flags such as Release and Debug that would make easy to activate

[gwt-contrib] Re: add option to generate overflow checks

2009-12-15 Thread jat
Ok, I just realized a serious problem with this patch. When compiling a more complicated program, multiple optimization passes will be performed, and this will keep wrapping the expressions each time through. I guess I need to visit method calls and if I see an Overflow.check* call, I need to

[gwt-contrib] Re: add option to generate overflow checks

2009-12-15 Thread scottb
No, you're good. The normalization passes only happen once. Just make sure your transforms don't react with any of the other normalization passes, such as the long emulation. http://gwt-code-reviews.appspot.com/126801 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Problems with UiBinder Internals

2009-12-15 Thread jarrod
I must have completely missed that feature in the documentation. I gave that a try, and I have to say I am impressed! I was even able to use java.lang.String as the provided type! Combined with the ability to use different ui.xml templates documented here:

Re: [gwt-contrib] Re: Problems with UiBinder Internals

2009-12-15 Thread John Tamplin
On Tue, Dec 15, 2009 at 11:29 AM, jarrod jarrod.carl...@gmail.com wrote: Combined with the ability to use different ui.xml templates documented here: http://code.google.com/webtoolkit/doc/latest/DevGuideUiBinder.html#Apply_different_xml I should be able to declare one ui.xml for IE and

Re: [gwt-contrib] Patch for InterfaceGenerator to generate methods for @defs

2009-12-15 Thread Joel Webber
Thanks, Balaji. Ray and/or Bob, want to take a look at this? On Mon, Dec 14, 2009 at 5:10 PM, Balaji Srinivasan srinivas...@google.comwrote: Hi Folks I filed issue http://code.google.com/p/google-web-toolkit/issues/detail?id=4327 and attached a patch to it to make InterfaceGenerator generate

[gwt-contrib] Re: Problems with UiBinder Internals

2009-12-15 Thread jarrod
Actually, I was just struggling with this a bit... I have my two ui.xml templates setup, but I can't seem to get GWT.create() to select the right one. Here's what I tried: @UiTemplate(JavaApplet.ui.xml) interface JavaApplet extends UiBinderElement, UploaderWidget { }

[gwt-contrib] Re: Comment on TroubleshootingOOPHM in google-web-toolkit

2009-12-15 Thread codesite-noreply
Comment by monish.ar: Using development mode in Eclipse 3.5 using GWT 2.0 on Windows XP Pro 64 bit, I'm unable to debug as GWT skips most of my Breakpoints. When I uninstalled the plugin and set my default SDK to 1.7.1, Hosted browser mode doesn't work anymore. I was asked to install a

[gwt-contrib] Re: Comment on TroubleshootingOOPHM in google-web-toolkit

2009-12-15 Thread codesite-noreply
Comment by j...@google.com: 64-bit IE is not currently supported. For more information: http://code.google.com/p/google-web-toolkit/wiki/TroubleshootingOOPHM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Comment on TroubleshootingOOPHM in google-web-toolkit

2009-12-15 Thread codesite-noreply
Comment by monish.ar: I think GWT 2.0 broke my installation of the previous version. I think I have to start a new Eclipse install and stick to 1.7.1 for now. For more information: http://code.google.com/p/google-web-toolkit/wiki/TroubleshootingOOPHM --

[gwt-contrib] Re: Comment on TroubleshootingOOPHM in google-web-toolkit

2009-12-15 Thread codesite-noreply
Comment by j...@google.com: You can have multiple versions of GWT installed at once and the current Eclipse plugin should work with any of them. Also, GWT 1.7.1 isn't going to give you devmode with a 64-bit browser either. For more information:

[gwt-contrib] [google-web-toolkit] r7313 committed - Fix integer overflow in BigInteger calculation.

2009-12-15 Thread codesite-noreply
Revision: 7313 Author: j...@google.com Date: Tue Dec 15 11:15:10 2009 Log: Fix integer overflow in BigInteger calculation. http://code.google.com/p/google-web-toolkit/source/detail?r=7313 Modified: /changes/jat/bigdecimal/user/super/com/google/gwt/emul/java/math/BitLevel.java

Re: [gwt-contrib] Revisiting the script-via-iframe default linkage

2009-12-15 Thread Lex Spoon
Hey, Matt, I've now double checked on several browsers other than Opera, and I agree that onerror works on non-IE and onreadystatechange works on IE. Details here: http://blog.lexspoon.org/2009/12/detecting-download-failures-with-script.html One tricky aspect is that I don't see how to get IE

Re: [gwt-contrib] Revisiting the script-via-iframe default linkage

2009-12-15 Thread John Tamplin
On Tue, Dec 15, 2009 at 2:48 PM, Lex Spoon sp...@google.com wrote: Ideas would be welcome about how to deal with that. Could the fragments include some JS at the end which calls a well-known I loaded successfully method? -- John A. Tamplin Software Engineer (GWT), Google --

Re: [gwt-contrib] Revisiting the script-via-iframe default linkage

2009-12-15 Thread Lex Spoon
On Tue, Dec 15, 2009 at 2:53 PM, John Tamplin j...@google.com wrote: On Tue, Dec 15, 2009 at 2:48 PM, Lex Spoon sp...@google.com wrote: Ideas would be welcome about how to deal with that. Could the fragments include some JS at the end which calls a well-known I loaded successfully method?

[gwt-contrib] Re: Comment on TroubleshootingOOPHM in google-web-toolkit

2009-12-15 Thread codesite-noreply
Comment by monish.ar: Thanks for your reply. Yeah, actually that's what I assumed. I've had 1.7.1 running until now in the hosted mode without any problems. Once I installed version 2.0 and started having problems with debugging, I switched back to 1.7.1 SDK but in vain. The problem still

Re: [gwt-contrib] Revisiting the script-via-iframe default linkage

2009-12-15 Thread Matt Mastracci
On 15-Dec-09, at 12:48 PM, Lex Spoon wrote: I've now double checked on several browsers other than Opera, and I agree that onerror works on non-IE and onreadystatechange works on IE. Details here: http://blog.lexspoon.org/2009/12/detecting-download-failures-with-script.html One tricky

[gwt-contrib] [google-web-toolkit] r7314 committed - Fixing error message on script tag with conditionals in .gwt.xml....

2009-12-15 Thread codesite-noreply
Revision: 7314 Author: sco...@google.com Date: Tue Dec 15 13:07:59 2009 Log: Fixing error message on script tag with conditionals in .gwt.xml. Issue: 3746 Review by: cramsdale http://code.google.com/p/google-web-toolkit/source/detail?r=7314 Modified:

[gwt-contrib] [google-web-toolkit] r7315 committed - Update Scheduler API....

2009-12-15 Thread codesite-noreply
Revision: 7315 Author: b...@google.com Date: Tue Dec 15 13:40:53 2009 Log: Update Scheduler API. - Add EntryCommands - Add repeating FinallyCommand - Always empty the FinallyCommand queue before returning to the browser Add state-getting method to Impl and add a fix for the finally block

Re: [gwt-contrib] Re: Problems with UiBinder Internals

2009-12-15 Thread Arthur Kalmenson
Sorry to jump in here, but that looks almost like data bindings Ray. I missed that feature of uibinder too. I tried it out and you're able to bind from a POJO during initialization, I wonder if that could be used as a starting point to do data bindings on set and get. Thanks! -- Arthur Kalmenson

[gwt-contrib] [google-web-toolkit] r7316 committed - Don't ignore !important when attempting to merge CSS rules by content....

2009-12-15 Thread codesite-noreply
Revision: 7316 Author: b...@google.com Date: Tue Dec 15 13:45:42 2009 Log: Don't ignore !important when attempting to merge CSS rules by content. Resolves issue 4304. Patch by: bobv Review by: rjrjr http://code.google.com/p/google-web-toolkit/source/detail?r=7316 Modified:

[gwt-contrib] Re: Control flow graph abstraction builder for CFG optimizations.

2009-12-15 Thread spoon
LGTM. But gee, Mike, what can the framework actually DO? http://gwt-code-reviews.appspot.com/117805/diff/2047/1046 File dev/core/src/com/google/gwt/dev/util/Either.java (right): http://gwt-code-reviews.appspot.com/117805/diff/2047/1046#newcode28 Line 28: throw new IllegalArgumentException();

[gwt-contrib] [google-web-toolkit] r7317 committed - Make @url and the gwt-image property of @sprite blocks accept dot-path...

2009-12-15 Thread codesite-noreply
Revision: 7317 Author: b...@google.com Date: Tue Dec 15 16:53:51 2009 Log: Make @url and the gwt-image property of @sprite blocks accept dot-path values so that they can be used with nested ClientBundles. Resolves issue 4341. Patch by: bobv Review by: rjrjr

[gwt-contrib] Re: Control flow graph abstraction builder for CFG optimizations.

2009-12-15 Thread mike . aizatsky
Lex, Next patch will contains 3 optimizations. Promise! :) http://gwt-code-reviews.appspot.com/117805/diff/2047/1046 File dev/core/src/com/google/gwt/dev/util/Either.java (right): http://gwt-code-reviews.appspot.com/117805/diff/2047/1046#newcode76 Line 76: return true; On 2009/12/15 23:00:37,

[gwt-contrib] Re: Control flow graph abstraction builder for CFG optimizations.

2009-12-15 Thread mike . aizatsky
Merged into http://gwt-code-reviews.appspot.com/126803 http://gwt-code-reviews.appspot.com/117805 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r7318 committed - Fixes UiBinder IndexOutOfBound errors on public void set() methods....

2009-12-15 Thread codesite-noreply
Revision: 7318 Author: rj...@google.com Date: Tue Dec 15 19:43:09 2009 Log: Fixes UiBinder IndexOutOfBound errors on public void set() methods. http://code.google.com/p/google-web-toolkit/issues/detail?id=4250 contributed by Thomas Matthijs review by rjrjr

[gwt-contrib] [google-web-toolkit] r7319 committed - Fixes Javadoc errors on DislcosurePanels in UiBinder...

2009-12-15 Thread codesite-noreply
Revision: 7319 Author: rj...@google.com Date: Tue Dec 15 19:51:30 2009 Log: Fixes Javadoc errors on DislcosurePanels in UiBinder http://code.google.com/p/google-web-toolkit/issues/detail?id=4329 http://code.google.com/p/google-web-toolkit/source/detail?r=7319 Modified:

[gwt-contrib] [google-web-toolkit] r7320 committed - Merges tr...@7318 and 7319 into releases/2.0...

2009-12-15 Thread codesite-noreply
Revision: 7320 Author: rj...@google.com Date: Tue Dec 15 21:43:16 2009 Log: Merges tr...@7318 and 7319 into releases/2.0 IndexOutOfBounds fix for UiBinder, JavaDoc fixes for DisclosurePanel svn merge --ignore-ancestry -r7317:7319 https://google-web-toolkit.googlecode.com/svn/trunk .

[gwt-contrib] RR : Improve web-mode stack trace presentation for continuous builds

2009-12-15 Thread bobv
Reviewers: jat, Message: Review requested. Description: This patch adds resymbolization to JUnitShell so that stack traces from GWTTestCases change from Unknown.az to com.example.Class.someMethod() Additionally, it turns emulated stack traces on for all browsers to ensure consistent

[gwt-contrib] Re: RR : Improve web-mode stack trace presentation for continuous builds

2009-12-15 Thread jat
LGTM with one question. http://gwt-code-reviews.appspot.com/126806/diff/1/2 File dev/core/src/com/google/gwt/core/linker/SymbolMapsLinker.java (right): http://gwt-code-reviews.appspot.com/126806/diff/1/2#newcode88 Line 88: boolean isJunit = context.getModuleName().endsWith(.JUnit); This is

[gwt-contrib] [google-web-toolkit] r7321 committed - Improve tests for better coverage of BigDecimal/etc.

2009-12-15 Thread codesite-noreply
Revision: 7321 Author: j...@google.com Date: Tue Dec 15 23:07:53 2009 Log: Improve tests for better coverage of BigDecimal/etc. http://code.google.com/p/google-web-toolkit/source/detail?r=7321 Modified: