On 2010/03/03 22:20:16, kozura wrote:
Well, I've seen your arguments on resize/visibility events in other
forums, and
must defer to your judgment on what is possible in the various
browsers and GWT
infrastructure! Just annoying to have to add another nasty bit,
especially one
that creates
Revision: 7664
Author: b...@google.com
Date: Thu Mar 4 07:49:01 2010
Log: Created wiki page through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=7664
Added:
/wiki/SoftPermutations.wiki
===
--- /dev/null
+++
I've been working on allowing certain GWT.create() rebinds to be
implemented at runtime in order to reduce permutation explosion.
Design doc:
http://code.google.com/p/google-web-toolkit/wiki/SoftPermutations
70% implementation, enough to compile Showcase into one permutation:
Whoo-hoo, I want this! It *certainly* helps with adding Application
Cache support!
On Thu, Mar 4, 2010 at 5:24 PM, BobV b...@google.com wrote:
I've been working on allowing certain GWT.create() rebinds to be
implemented at runtime in order to reduce permutation explosion.
Design doc:
Reviewers: jlabanca,
Description:
Add side-by-side trees to the bikeshed
Review by: jlaba...@google.com
Please review this at http://gwt-code-reviews.appspot.com/160802
Affected files:
M
bikeshed/src/com/google/gwt/bikeshed/sample/stocks/client/StockSample.java
M
On Tue, Mar 2, 2010 at 6:23 PM, Scott Blum sco...@google.com wrote:
Meh. I've always thought our selections scripts were too big and
complicated as is. I'd rather we could figure out a way to get rid of meta
properties altogether. :(
That may be, but do we have the time for it? Such a
Revision: 7667
Author: sp...@google.com
Date: Thu Mar 4 09:36:49 2010
Log: Created wiki page through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=7667
Added:
/wiki/WhenLinkerAdded.wiki
===
--- /dev/null
+++
On Wed, Mar 3, 2010 at 6:35 PM, Lex Spoon sp...@google.com wrote:
Sure, will do. The discussions preceding this patch are in several
different places. I can summarize them on the wiki.
It seems like to me, if you have any kind of process for inlining a
selection script into a host page, that that process *ought* to be able to
update the module base URL correctly. I mean... if you have to generate the
correct meta tag to do the exact same thing, while not just modify the
On Thu, Mar 4, 2010 at 12:00 PM, Matt Mastracci matt...@mastracci.com wrote:
One comment: is there a lot of overhead in running a switch each time
GWT.create() is called? The method could modify itself the first time it was
run to select the correct factory method. It would have to happen in
LGTM with one nit.
http://gwt-code-reviews.appspot.com/154811/diff/1/4
File
dev/core/src/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizer.java
(right):
http://gwt-code-reviews.appspot.com/154811/diff/1/4#newcode102
Line 102: throw new RuntimeException(Error optimizing: + methodName,
t);
On 2010/03/04 19:14:47, jlabanca wrote:
LGTM
http://gwt-code-reviews.appspot.com/160803
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
The fix was the generator needed to know which locales were combined
together so it could produce a more optimal shared solution. How would that
fit in here?
Would it be sufficient if the SelectionProperty interface were to
include a getCollapsedValues() that would indicate the other values
On Thu, Mar 4, 2010 at 2:22 PM, BobV b...@google.com wrote:
The fix was the generator needed to know which locales were combined
together so it could produce a more optimal shared solution. How would
that
fit in here?
Would it be sufficient if the SelectionProperty interface were to
committed as r7668
http://gwt-code-reviews.appspot.com/157802
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2010-03-04, at 11:13 AM, BobV wrote:
These factory methods need to live in the Java AST so that we can
use the type tightener to optimize the (usual-case) polymorphic
dispatch. Adding a JHasNameRef node to the AST would allow what
you're describing to be built, but I think that would
committed as r7670
http://gwt-code-reviews.appspot.com/160803
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7670
Author: jlaba...@google.com
Date: Thu Mar 4 09:04:47 2010
Log: Undeprecating DOMImplIE6.isIE6() to avoid compile warnings. The method
and the class are both package protected anyway.
http://gwt-code-reviews.appspot.com/160803
Reviewers: jat,
Description:
If a date string ends in a forward slash, DateTimeFormat can throw an
uncaught IndexOutOfBoundsException when trying to parseInt an expected
integer after the slash. subParseYear has the same problem.
In addition, if an integer is not found for a variety of parts,
On Thu, Mar 4, 2010 at 12:47 PM, Scott Blum sco...@google.com wrote:
It seems like to me, if you have any kind of process for inlining a
selection script into a host page, that that process *ought* to be able to
update the module base URL correctly. I mean... if you have to generate the
On Thu, Mar 4, 2010 at 3:17 PM, Matt Mastracci matt...@mastracci.comwrote:
We use repeated calls to GWT.create() for dependency injection and to
generate code for our internal widget templating framework. Both of them
also use nested GWT.create() calls under the hood in generated code for
LGTM
http://gwt-code-reviews.appspot.com/159802/diff/1/2
File user/test/com/google/gwt/i18n/client/DateTimeFormat_en_Test.java
(right):
http://gwt-code-reviews.appspot.com/159802/diff/1/2#newcode500
Line 500: * IndexOutOfBoundsException.
Should also test for the other checks you just added.
Reviewers: jgw, knorton,
Description:
See issue for explanation.
http://code.google.com/p/google-web-toolkit/issues/detail?id=4586
Webkit has already been modified to use textContent. This patch makes
Opera use it as well.
Testing:
===
I manually verified that innerText works, and the
Straw man let's say when you inject a GWT selection script, you can add
a single line at the very top:
var moduleBaseURL = w00t/
Then at the top of computeScriptBase(), we just look to see if moduleBaseURL
is already defined, and if so we return that.
On Thu, Mar 4, 2010 at 3:31 PM, Lex
Revision: 7671
Author: jlaba...@google.com
Date: Thu Mar 4 11:39:37 2010
Log: Parsing a date string with an ending forward slash can lead to an
uncaught exception.
http://gwt-code-reviews.appspot.com/159802/show
http://code.google.com/p/google-web-toolkit/source/detail?r=7671
Modified:
Revision: 7674
Author: rj...@google.com
Date: Thu Mar 4 13:18:39 2010
Log: Delete .settings garbage
http://code.google.com/p/google-web-toolkit/source/detail?r=7674
Deleted:
/trunk/bikeshed/.settings
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
26 matches
Mail list logo
